[Vtigercrm-developers] Bug reporting vtiger 5.4

[Lajeesh K]

Hi Joe,

 

Empty will check if the value is zero also. Ie, if a value is 0 it will
considered as empty.  I have faced this issues when I have a dropdown which
select value 0 to 10.  And when I select value zero it return the error
required value is not set

 

 

Regards,

Lajeesh

 

From: vtigercrm-developers-bounces at lists.vtigercrm.com
[mailto:vtigercrm-developers-bounces at lists.vtigercrm.com] On Behalf Of Joe
Bordes
Sent: Monday, September 02, 2013 5:38 PM
To: vtigercrm-developers at lists.vtigercrm.com
Subject: Re: [Vtigercrm-developers] Bug reporting vtiger 5.4

 

Can you explain why?
I mean empty checks if the variable is set and if so, if it is different
than any empty or inexistent value, which, I understand, is exactly what it
should be doing to make sure the required fields have a value different than
empty, no?

Joe
TSolucio


 El 02/09/13 12:03, Lajeesh K escribió:

Hi

 

There is bug in vtiger  5.4 module/webforms/capture.php  line 56

 

if(empty($parameters[$webformField->getFieldName()]))  throw new
Exception("Required fields not filled");

 

here its checking empty it should be isset .  I have found this error in
5.10 EA . So I doubt it be present in future 6 version . 

 

Really surprised how this kind of simple errors are still exists in vtiger

 

 

Regards,

Lajeesh






_______________________________________________
http://www.vtiger.com/

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130902/397bcc3c/attachment.html>