[Vtigercrm-developers] Bug reporting vtiger 5.4

[Adrián Granado - Refineria Web]

I agree that vTiger have serious problems with the statement 0 = empty


 


Refineria Web

Adrián Granado 
PROGRAMADOR 
 <mailto:%20adrian at refineriaweb.com> adrian at refineriaweb.com 

 

	
C/ Gran Vía Asima, 20 - 2º Oficina 7

07009 Palma de Mallorca
Teléfono 971 72 98 83 – Ext. 512
Fax 971 780 391 


 <http://www.refineriaweb.com/> Refineria Web

 

	
 <https://www.facebook.com/refineriaweb1> Siguenos en Facebook
<https://twitter.com/refineriaweb> Siguenos en Twitter

 

 

De: vtigercrm-developers-bounces at lists.vtigercrm.com
[mailto:vtigercrm-developers-bounces at lists.vtigercrm.com] En nombre de
Lajeesh K
Enviado el: lunes, 02 de septiembre de 2013 14:33
Para: vtigercrm-developers at lists.vtigercrm.com
Asunto: Re: [Vtigercrm-developers] Bug reporting vtiger 5.4

 

Hi Joe,

 

Empty will check if the value is zero also. Ie, if a value is 0 it will
considered as empty.  I have faced this issues when I have a dropdown which
select value 0 to 10.  And when I select value zero it return the error
required value is not set

 

 

Regards,

Lajeesh

 

From: vtigercrm-developers-bounces at lists.vtigercrm.com
[mailto:vtigercrm-developers-bounces at lists.vtigercrm.com] On Behalf Of Joe
Bordes
Sent: Monday, September 02, 2013 5:38 PM
To: vtigercrm-developers at lists.vtigercrm.com
Subject: Re: [Vtigercrm-developers] Bug reporting vtiger 5.4

 

Can you explain why?
I mean empty checks if the variable is set and if so, if it is different
than any empty or inexistent value, which, I understand, is exactly what it
should be doing to make sure the required fields have a value different than
empty, no?

Joe
TSolucio


 El 02/09/13 12:03, Lajeesh K escribió:

Hi

 

There is bug in vtiger  5.4 module/webforms/capture.php  line 56

 

if(empty($parameters[$webformField->getFieldName()]))  throw new
Exception("Required fields not filled");

 

here its checking empty it should be isset .  I have found this error in
5.10 EA . So I doubt it be present in future 6 version . 

 

Really surprised how this kind of simple errors are still exists in vtiger

 

 

Regards,

Lajeesh





_______________________________________________
http://www.vtiger.com/

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130902/bd9f61e2/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 1934 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130902/bd9f61e2/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 3354 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130902/bd9f61e2/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image003.png
Type: image/png
Size: 1098 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130902/bd9f61e2/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image004.png
Type: image/png
Size: 1186 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130902/bd9f61e2/attachment-0007.png>