[Vtigercrm-developers] Bug in sendNotificationToGroups function in CommonUtils.php

[Xavier Mones]

Hi Asha,

You are right. There is no check for the filestatus field of the 
vtiger_notes table. The function addAllAttachments of 
modules/Emails/mail.php should be modified to check for it.

But anyway, the sendNotificationToGroups is called when a record is 
created, and the attachment is sent for Documents, is unusual that 
somebody creates a new record for Documents which is not active.

Best regards,

<http://www.c3po.es>
*C3PO S.A.*
*Xavier Monés*
*Tel:* +34 934.179.955
*Fax:* +34 932.531.280
Alejandro Goicoechea 6 · Local 9 · 08960 Sant Just Desvern (Spain)
xmm at c3po.es <mailto:xmm at c3po.es> · www.c3po.es <http://www.c3po.es> 
www.c3po.eu <http://www.c3po.eu> www.c3po.cat <http://www.c3po.cat>
------------------------------------------------------------------------
La información contenida en este mensaje y los archivos adjuntos son 
confidenciales. Si usted recibe este mensaje por error debe destruirlo 
sin copiarlo ni comunicarlo e informar inmediatamente por correo 
electrónico al emisor del mensaje. Cualquier comunicación, copia, 
distribución u otro uso de esta información no autorizado expresamente 
por el emisor del mensaje está prohibido legalmente.
------------------------------------------------------------------------
The information contained in this message and its attachments are 
confidential. If you have received this message by mistake, you must 
delete it without making any copy and communication. Furthermore, you 
have to immediately inform by e-mail about this incident to the sender. 
Any disclosure, reproduction, distribution or other of this information 
without the express permission of the sender it is legally prohibited.
------------------------------------------------------------------------

El 08/11/2010 12:55, Asha escribió:
> Hi Xavier,
>
> We have found one issue in our test labs while testing the fix you have
> suggested. It will send attachments for those documents also which are set
> as inactive.
>
>
> On Mon, Nov 8, 2010 at 3:10 PM, Asha<asha at vtiger.com>  wrote:
>
>> Hi Xavier,
>>
>> Thanks for identifying the issue. We will review the issue as well as the
>> fix and update you about it.
>>
>> On Mon, Nov 8, 2010 at 2:03 PM, Xavier Mones<xmm at c3po.es>  wrote:
>>
>>>   Hello,
>>>
>>> the is a bug in the sendNotificationToGroups function in
>>> include\utils\CommonUtils.php that makes that the send_mail function does
>>> not find the attachments for the notification email.
>>>
>>> It applies in 5.1.0 and 5.2.0.
>>>
>>> Solution is to change this line:
>>>
>>>                     $mail_status =
>>> send_mail('Emails',$emailadd,$current_user->user_name,'','Record
>>> created-vTiger Team',$description,'','','all',$focus->id);
>>>
>>> for this one:
>>>
>>>                     $mail_status =
>>> send_mail('Emails',$emailadd,$current_user->user_name,'','Record
>>> created-vTiger Team',$description,'','','all',$crmid);
>>>
>>>
>>> Regards,
>>>
>>>   --
>>>   <http://www.c3po.es>
>>> *C3PO S.A.*
>>> *Xavier Monés*
>>> *Tel:* +34 934.179.955
>>> *Fax:* +34 932.531.280
>>> Alejandro Goicoechea 6 · Local 9 · 08960 Sant Just Desvern (Spain)
>>> xmm at c3po.es · www.c3po.es www.c3po.eu www.c3po.cat
>>>
>>>   ------------------------------
>>> La información contenida en este mensaje y los archivos adjuntos son
>>> confidenciales. Si usted recibe este mensaje por error debe destruirlo sin
>>> copiarlo ni comunicarlo e informar inmediatamente por correo electrónico al
>>> emisor del mensaje. Cualquier comunicación, copia, distribución u otro uso
>>> de esta información no autorizado expresamente por el emisor del mensaje
>>> está prohibido legalmente.
>>> ------------------------------
>>> The information contained in this message and its attachments are
>>> confidential. If you have received this message by mistake, you must delete
>>> it without making any copy and communication. Furthermore, you have to
>>> immediately inform by e-mail about this incident to the sender. Any
>>> disclosure, reproduction, distribution or other of this information without
>>> the express permission of the sender it is legally prohibited.
>>> ------------------------------
>>>
>>> _______________________________________________
>>> http://www.vtiger.com/
>>>
>>
>>
>> --
>> Regards,
>> Asha
>> vtiger Team
>>
>
>
>
> _______________________________________________
> http://www.vtiger.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20101108/171a22db/attachment-0002.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pie.gif
Type: image/gif
Size: 47898 bytes
Desc: not available
Url : http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20101108/171a22db/attachment-0002.gif