[Vtigercrm-developers] Report Error in Fresh Vtiger 8.4 installation

[Vincenzo Bruno]

The Beppo's patch worked for me.

Also your committed patch works, but is a little bit overkill because 
$IS_DUPLICATE is passed correctly at Step 2 and 3

In Step1.tpl we have:

<input type="hidden" name="isDuplicate" value="{if 
isset($IS_DUPLICATE)}{$IS_DUPLICATE}{else}false{/if}" />

In Step2.tpl and Step3.tpl

<input type="hidden" name="isDuplicate" value="{$IS_DUPLICATE}" />

The issue arises at Step 1 where the field value was empty before the patch:

<input type="hidden" name="isDuplicate" value="" />

and that is valued as TRUE in Edit.php at line:

if ($request->get('isDuplicate')) {


Hope this helps

Best regards

Vincenzo


Il 26/02/26 05:24, Prasad ha scritto:
> Can you please share the test-case steps that is not working with the 
> patch?
>
> On Wed, Feb 25, 2026 at 4:47 PM Vincenzo Bruno <v.bruno at vinsoft.it> wrote:
>
>     Hi Beppo,
>
>     thank you very much, the fix works.
>
>     I was working on a different path: searching which commit broke
>     this feature in 8.4, but didn't find it
>
>     Probably the issue arises in handling booleans in new PHP versions
>
>     In step1 of an Edit we have:
>
>
>     In step 1 of a Duplicate instead we had (without your patch):
>
>     whit your patch:
>
>
>     Maybe "false" value is not treated correctly anymore and this
>     could impact many more features in the code.
>
>     Vincenzo
>
>
>
>     Il 23/02/26 16:29, Giuseppe Mazzucato ha scritto:
>>     To solve add just one line in file modules/Reports/views/Edit.php
>>
>>     133        if ($request->get('isDuplicate')) {
>>     134           $viewer->assign('IS_DUPLICATE', true);
>>     135        }
>>      +++       else    $viewer->assign('IS_DUPLICATE', false);     
>>     //this is the line to add
>>      136       $viewer->view('Step1.tpl', $moduleName);
>>
>>     Best regards
>>
>>     Beppo
>>
>>     Il 23/02/26 16:16, Vincenzo Bruno ha scritto:
>>>
>>>     I confirm the issue in 8.4, not present in 8.3
>>>
>>>     Looking for the cause
>>>
>>>     Vincenzo
>>>
>>>     Il 19/02/26 01:09, Alexander Allen ha scritto:
>>>>     Hello Everyone, have you notice that installing a fresh version
>>>>     of Vtiger 8.4 the reports module has this error.
>>>>
>>>>     If you create a Report and then you Edit it, Vtiger creates a
>>>>     new report with the same name and then you get two reports.
>>>>
>>>     -- 
>>>     Vincenzo Bruno
>>>     Coopyleft soc. coop. a r.l.
>>>     www.coopyleft.it <http://www.coopyleft.it>
>>>     tel: 3287252923
>>>          
>>>
>>>     _______________________________________________
>>>     http://www.vtiger.com/
>>
>>
>>     _______________________________________________
>>     http://www.vtiger.com/
>
>     -- 
>     Vincenzo Bruno
>     Coopyleft soc. coop. a r.l.
>     www.coopyleft.it <http://www.coopyleft.it>
>     tel: 3287252923
>          
>
>     _______________________________________________
>     http://www.vtiger.com/
>
>
> _______________________________________________
> http://www.vtiger.com/

-- 
Vincenzo Bruno
Coopyleft soc. coop. a r.l.
www.coopyleft.it
tel: 3287252923
     
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20260226/ac3d17dd/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xtkpbkM76yZ8RWGh.png
Type: image/png
Size: 63452 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20260226/ac3d17dd/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: AK0U1mGwdPmMT7iS.png
Type: image/png
Size: 80411 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20260226/ac3d17dd/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ZYxDyu64HcTb680X.png
Type: image/png
Size: 68627 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20260226/ac3d17dd/attachment-0005.png>