<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><font size="4">The Beppo's patch worked for me.</font></p>
    <p><font size="4">Also your committed patch works, but is a little
        bit overkill because </font><font size="4">$IS_DUPLICATE is
        passed correctly at Step 2 and 3</font></p>
    <p><font size="4">In Step1.tpl we have:</font></p>
    <p><font size="4"><input type="hidden" name="isDuplicate"
        value="{if isset($IS_DUPLICATE)}{$IS_DUPLICATE}{else}false{/if}"
        /></font></p>
    <p><font size="4">In Step2.tpl and Step3.tpl</font></p>
    <p><font size="4"><input type="hidden" name="isDuplicate"
        value="{$IS_DUPLICATE}" /></font></p>
    <p><font size="4">The issue arises at Step 1 where the field value
        was empty before the patch:</font></p>
    <p><font size="4"><input type="hidden" name="isDuplicate"
        value="" /></font></p>
    <p><font size="4">and that is valued as TRUE in Edit.php at line:</font></p>
    <p><font size="4">if ($request->get('isDuplicate')) { </font></p>
    <p><font size="4"><br>
      </font></p>
    <p><font size="4">Hope this helps</font></p>
    <p><font size="4">Best regards</font></p>
    <p><font size="4">Vincenzo</font></p>
    <p><font size="4"><br>
      </font></p>
    <div class="moz-cite-prefix">Il 26/02/26 05:24, Prasad ha scritto:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAMeS7pk3pDFGxKaO_XhWsLPOi+Hqd9y0cAnCneazKnsAmqunWw@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div class="gmail_default"
          style="font-family:arial,helvetica,sans-serif">Can you please
          share the test-case steps that is not working with the patch?</div>
      </div>
      <br>
      <div class="gmail_quote gmail_quote_container">
        <div dir="ltr" class="gmail_attr">On Wed, Feb 25, 2026 at
          4:47 PM Vincenzo Bruno <<a href="mailto:v.bruno@vinsoft.it"
            moz-do-not-send="true" class="moz-txt-link-freetext">v.bruno@vinsoft.it</a>>
          wrote:<br>
        </div>
        <blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
          <div>
            <p><font size="4">Hi Beppo,</font></p>
            <p><font size="4">thank you very much, the fix works.</font></p>
            <p><font size="4">I was working on a different path:
                searching which commit broke this feature in 8.4, but
                didn't find it</font></p>
            <p><font size="4">Probably the issue arises in handling
                booleans in new PHP versions</font></p>
            <p><font size="4">In step1 of an Edit we have:</font></p>
            <p><font size="4"><img
                  src="cid:part1.OIu0HxDz.ce0oM6yd@vinsoft.it" alt=""
                  class=""><br>
              </font></p>
            <p>In step 1 of a Duplicate instead we had (without your
              patch):</p>
            <p><img src="cid:part2.4ltEmBf4.m9PoJTAM@vinsoft.it" alt=""
                class=""></p>
            <p>whit your patch:</p>
            <p><img src="cid:part3.aqJPrufo.oXV01gro@vinsoft.it" alt=""
                class=""></p>
            <p><br>
            </p>
            <p>Maybe "false" value is not treated correctly anymore and
              this could impact many more features in the code.</p>
            <p>Vincenzo</p>
            <p><br>
            </p>
            <p><br>
            </p>
            <div>Il 23/02/26 16:29, Giuseppe Mazzucato ha scritto:<br>
            </div>
            <blockquote type="cite"> To solve add just one line in file 
              modules/Reports/views/Edit.php<br>
              <br>
              133        if ($request->get('isDuplicate')) {<br>
              134           $viewer->assign('IS_DUPLICATE', true);<br>
              135        }<br>
               +++       else    $viewer->assign('IS_DUPLICATE',
              false);      //this is the line to add<br>
               136       $viewer->view('Step1.tpl', $moduleName);<br>
              <br>
              Best regards<br>
              <br>
              Beppo<br>
              <br>
              <div>Il 23/02/26 16:16, Vincenzo Bruno ha scritto:<br>
              </div>
              <blockquote type="cite">
                <p><font size="4">I confirm the issue in 8.4, not
                    present in 8.3</font></p>
                <p><font size="4">Looking for the cause</font></p>
                <p><font size="4">Vincenzo</font></p>
                <p><font size="4"> </font></p>
                <div>Il 19/02/26 01:09, Alexander Allen ha scritto:<br>
                </div>
                <blockquote type="cite">
                  <div dir="ltr">
                    <div>Hello Everyone, have you notice that installing
                      a fresh version of Vtiger 8.4 the reports module
                      has this error.</div>
                    <div><br>
                    </div>
                    <div>If you create a Report and then you Edit it,
                      Vtiger creates a new report with the same name and
                      then you get two reports. </div>
                  </div>
                  <br>
                </blockquote>
                <pre cols="72">-- 
Vincenzo Bruno
Coopyleft soc. coop. a r.l.
<a href="http://www.coopyleft.it" target="_blank" moz-do-not-send="true">www.coopyleft.it</a>
tel: 3287252923
    
</pre>
                <br>
                <fieldset></fieldset>
                <pre>_______________________________________________
<a href="http://www.vtiger.com/" target="_blank" moz-do-not-send="true"
                class="moz-txt-link-freetext">http://www.vtiger.com/</a></pre>
              </blockquote>
              <br>
              <br>
              <fieldset></fieldset>
              <pre>_______________________________________________
<a href="http://www.vtiger.com/" target="_blank" moz-do-not-send="true"
              class="moz-txt-link-freetext">http://www.vtiger.com/</a></pre>
            </blockquote>
            <pre cols="72">-- 
Vincenzo Bruno
Coopyleft soc. coop. a r.l.
<a href="http://www.coopyleft.it" target="_blank" moz-do-not-send="true">www.coopyleft.it</a>
tel: 3287252923
    
</pre>
          </div>
          _______________________________________________<br>
          <a href="http://www.vtiger.com/" rel="noreferrer"
            target="_blank" moz-do-not-send="true"
            class="moz-txt-link-freetext">http://www.vtiger.com/</a></blockquote>
      </div>
      <br>
      <fieldset class="moz-mime-attachment-header"></fieldset>
      <pre wrap="" class="moz-quote-pre">_______________________________________________
<a class="moz-txt-link-freetext" href="http://www.vtiger.com/">http://www.vtiger.com/</a></pre>
    </blockquote>
    <pre class="moz-signature" cols="72">-- 
Vincenzo Bruno
Coopyleft soc. coop. a r.l.
<a class="moz-txt-link-abbreviated" href="http://www.coopyleft.it">www.coopyleft.it</a>
tel: 3287252923
    
</pre>
  </body>
</html>