[Vtigercrm-developers] Let's make 7.4 fruitful

Ing. Matus Sopko sopko at its4you.sk
Mon Sep 14 08:08:19 GMT 2020


Hi,

I will be happy if this enhancements will be done:

1/ Cleanup code + PHP 7.4 compatibility
2/ Upgrade all dependent libraries
3/ Composer

Matus ;-)

S pozdravom / Best regards / Mit freundlichen Grüßen
Ing. Matus SOPKO

IT-Solutions4You s.r.o.
Kancelária: Slovenská 69
Sídlo: Frantiskanske nam.5
080 01 Prešov
SLOVAKIA
Tel./ Fax +421/ 51/ 7732370
email: sopko at its4you.sk
http://www.its4you.sk
skype: matussopko

Dňa 12. 9. 2020 o 12:37 Uma S napísal(a):
> Thanks! for the inputs Ruben, that's really helpful and we acknowledge 
> to prioritize these tasks.
>
> On Sat, Sep 12, 2020 at 12:05 AM Rubén A. Estrada Orozco 
> <rulotec1 at gmail.com <mailto:rulotec1 at gmail.com>> wrote:
>
>     Hi,
>
>     I agree with the following points that were mentioned by Alan and
>     Martin
>
>     * Composer
>     * Unit Tests
>     * PHP compatibility
>     * PSR12
>     * CLI database migration scripts for creating / updating database
>     between different versions
>     * Fix filters so admins can remove/edit all of them and default
>     landing
>     when not "all": #706, #1461
>     * Update online documentation for the Open Source platform. It's not
>     been changed for *ages*. (If you, vtiger don't have the bandwidth,
>     then
>     let us in the community have some level of access to the wiki or
>     whatever and let us write some of it - you could have a
>     moderator's role
>     to approve/deny if you like).
>     * See merge request #585 which added support for customising core
>     language files. Please extend functionality in a way similar to my
>     suggestion
>     https://code.vtiger.com/vtiger/vtigercrm/merge_requests/585#note_8739
>
>     Generally speaking, I think we should focus on making the project
>     more development friendly and extensible. To that end I would just
>     add:
>
>     * Avoid huge functions like Inventory_Edit_View::process() which
>     is almost 200 lines long:
>     https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Inventory/views/Edit.php.
>     The other day I wanted to extend that function in a custom
>     inventory module. But you have to write everything from scratch
>     and duplicate code because there are no helper functions that you
>     can use from the parent class. If instead of a 200 lines function
>     you had 10 or 20 smaller functions, reuse would be easier.
>
>     Also, I think there should be a clear and transparent method for
>     managing open issues in the repository so that we know:
>
>     * what is the process for deciding the priority an issue gets.
>     * what is the order in which issues will be worked on.
>     * what are the issues that are currently being worked on.
>     * what issues are going to be addressed by vtiger and which ones
>     by us external developers.
>     * what are the main priorities for the current release.
>     * make a guidelines document that explains all of the above so
>     that new developers (and also current ones) know how to better
>     contribute to the project and avoid devs having to guess it and
>     getting frustrated.
>
>
>     Finally I would like to mention a few features/fixes that I think
>     are important:
>
>     * fix google integration: contacts, calendar and captcha. It's
>     just broken since a long time ago.
>     * add filtering and searching capabilities to the templates
>     module. It's not very useful once you have more than just a few
>     records.
>     * this one mentioned by Alan: 7. Fix filters so admins can
>     remove/edit all of them and default landing
>     when not "all": #706, #1461
>
>
>
>
>     Saludos
>
>     Rubén
>
>
>     On Fri, Sep 11, 2020 at 10:52 AM Uma S <uma.s at vtiger.com
>     <mailto:uma.s at vtiger.com>> wrote:
>
>         Thank you! Alan, Martin and Nilay for your valuable insight,
>         we will review them and prioritize.
>
>         On Fri, Sep 11, 2020 at 3:05 PM Martin Allen
>         <martin.allen at clystnet.com <mailto:martin.allen at clystnet.com>>
>         wrote:
>
>
>             These may be more appropriate as vTiger 8 aims but still:
>             1) PHP compatibility - as Alan said PHP 7.4 compatibility
>             should be a priority but also thinking about using PHP8
>             which is very close to being released.
>             2) Dependent libraries using Composer to manage, this then
>             handles all updates required, and easy to know which
>             versions of libraries are being used and can be specified
>             which version should be installed.
>             3) PSR 12 (or even PSR 2!) coding style and PSR 4
>             autoloading (https://www.php-fig.org/psr/)
>             4) Installation via Composer?
>             5) Update documentation
>             6) Better logging of Errors and improved Error messages -
>             most of the time we just see a blank screen, or a message
>             that is very misleading e.g. "Something went wrong in a
>             workflow" - would be much nicer if it told me which
>             workflow! (Logging of errors by default as well, rather
>             than having to actively switch it on!)
>             7) Making the codebase suitable to be managed via GIT
>             after installation to allow for customisations - currently
>             the GIT repository on code.vtiger.com
>             <http://code.vtiger.com> contains multiple .zip files
>             which are next to useless being managed in GIT. We
>             maintain our own repository which is the code AFTER it has
>             been installed, and fork that repository for every new
>             installation we do. We also have created our own
>             .gitignore (after MUCH trial and error!) so having a
>             community version would be nice!
>             8) CLI database migration scripts for creating / updating
>             database between different versions
>
>             Oh and all the outstanding bugs ;)
>
>             Martin Allen
>
>             *01392 248692 - Main Office
>             01392 690659 - Direct Line*
>
>             *signature2*
>
>             Have you visited our website recently?
>             http://www.clystnet.com <http://www.clystnet.com/>
>
>
>             The information in this email is confidential If you are
>             not the intended recipient, you must not read or use that
>             information. This email and any attachments are believed
>             to be virus free however no responsibility is accepted by
>             Clystnet for any loss or damage arising in any way from
>             receipt or use thereof. Clystnet Ltd (company reg number
>             7164503) is based at Silverdown Park, Fair Oak Close,
>             Clyst Honiton, EX5 2UX
>
>
>
>             On Fri, 11 Sep 2020 at 09:41, Alan Lord
>             <alanslists at gmail.com <mailto:alanslists at gmail.com>> wrote:
>
>                 Thanks for reaching out Uma,
>
>                 Here are some of my suggestions (not in any
>                 preferential order):
>
>                 1. Get vtiger up-to-date in terms of requirements for
>                 PHP etc. And then
>                 have a process/plan to keep it up-to-date, i.e. using
>                 unit tests,
>                 linters etc. FWIW, php7.3 ends active support in 2
>                 months. 7.4 has been
>                 out for nearly a year already.
>
>                 2. Improve the server/rest APIs so they provide better
>                 information (i.e.
>                 optional user-level formatting of returned, data, see
>                 http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2020-August/038853.html
>
>                 and
>                 http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2020-August/038838.html).
>
>                 Maybe move the REST API to json format like vtiger cloud?
>
>                 3. Import the webhook workflow functionality from Cloud
>
>                 4. Add support to vtws_retrieve so any user can get
>                 "safe" information
>                 about _any_ other user. See #1155 and
>                 http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2020-April/038517.html
>
>                 5. Fix #676, #1003 and try to remove that horrible hack
>                 vtlib_setup_modulevars(). All the necessary
>                 information should be in the
>                 respective modules' class file anyway. I really fail
>                 to see what the
>                 point of this is and it continues to cause problems.
>
>                 6. Code cleanup. There are multiple copies of the long
>                 and complex
>                 date/time structures such as in
>                 modules/Vtiger/models/Field.php line
>                 653, modules/Reports/ReportRun.php line 1740,
>                 modules/Reports/Report.php
>                 line 990, modules/CustomView/models/Record.php line 805,
>                 modules/CustomView/CustomView.php line 569... There
>                 are so many
>                 instances of code duplication (not just the above)...
>                 Put it all in ONE
>                 place, then there's only one place we have to fix
>                 later on.
>
>                 7. Fix filters so admins can remove/edit all of them
>                 and default landing
>                 when not "all": #706, #1461
>
>                 8. #1240
>
>                 9. See merge request #585 which added support for
>                 customising core
>                 language files. Please extend functionality in a way
>                 similar to my
>                 suggestion
>                 https://code.vtiger.com/vtiger/vtigercrm/merge_requests/585#note_8739
>
>                 10. Update online documentation for the Open Source
>                 platform. It's not
>                 been changed for *ages*. (If you, vtiger don't have
>                 the bandwidth, then
>                 let us in the community have some level of access to
>                 the wiki or
>                 whatever and let us write some of it - you could have
>                 a moderator's role
>                 to approve/deny if you like).
>
>                 That should do for now ;-)
>
>                 Cheers
>
>                 Al
>
>                 On 11/09/2020 06:58, Uma S wrote:
>                 > Dear Developer,
>                 >
>                 > We are happy to accept more ideas from the community
>                 on what are the top
>                 > 10 wish enhancements for 7.4? So that we can make
>                 the release fruitful.
>                 >
>                 > I would request all the community members to take
>                 part in this to share
>                 > their thoughts.
>                 _______________________________________________
>                 http://www.vtiger.com/
>
>             _______________________________________________
>             http://www.vtiger.com/
>
>
>
>         -- 
>         With
>         Best Regards
>         Uma.S
>         Vtiger Team
>         _______________________________________________
>         http://www.vtiger.com/
>
>     _______________________________________________
>     http://www.vtiger.com/
>
>
>
> -- 
> With
> Best Regards
> Uma.S
> Vtiger Team
>
> _______________________________________________
> http://www.vtiger.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200914/742eba7e/attachment-0001.html>


More information about the vtigercrm-developers mailing list