<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<tt>Hi,<br>
<br>
I will be happy if this </tt><tt>enhancements will be done:<br>
<br>
1/ C</tt><tt>leanup code + PHP 7.4 compatibility<br>
</tt><tt>2/ Upgrade all dependent libraries<br>
3/ </tt><tt>Composer<br>
<br>
Matus ;-)<br>
<br>
</tt>
<pre class="moz-signature" cols="72">S pozdravom / Best regards / Mit freundlichen Grüßen
Ing. Matus SOPKO
IT-Solutions4You s.r.o.
Kancelária: Slovenská 69
Sídlo: Frantiskanske nam.5
080 01 Prešov
SLOVAKIA
Tel./ Fax +421/ 51/ 7732370
email: <a class="moz-txt-link-abbreviated" href="mailto:sopko@its4you.sk">sopko@its4you.sk</a>
<a class="moz-txt-link-freetext" href="http://www.its4you.sk">http://www.its4you.sk</a>
skype: matussopko</pre>
<div class="moz-cite-prefix">Dňa 12. 9. 2020 o 12:37 Uma S
napísal(a):<br>
</div>
<blockquote type="cite"
cite="mid:CAH83UoL+Y=O1C2fcEQek5v9uimLRo7Cj6hgjcN4a1kAeVexC=Q@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">Thanks! for the inputs Ruben, that's really helpful
and we acknowledge to prioritize these tasks.<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, Sep 12, 2020 at 12:05
AM Rubén A. Estrada Orozco <<a
href="mailto:rulotec1@gmail.com" moz-do-not-send="true">rulotec1@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Hi,
<div><br>
</div>
<div>I agree with the following points that were mentioned
by Alan and Martin<br>
<div><br>
</div>
<div>* Composer </div>
<div>* Unit Tests</div>
<div>* PHP compatibility</div>
<div>* PSR12</div>
<div><span style="font-family:verdana,sans-serif">* CLI
database migration scripts for creating / updating
database between different versions</span><br>
</div>
<div>* Fix filters so admins can remove/edit all of them
and default landing<br>
when not "all": #706, #1461</div>
<div>* Update online documentation for the Open Source
platform. It's not<br>
been changed for *ages*. (If you, vtiger don't have the
bandwidth, then<br>
let us in the community have some level of access to the
wiki or<br>
whatever and let us write some of it - you could have a
moderator's role<br>
to approve/deny if you like).<br>
</div>
<div>* See merge request #585 which added support for
customising core<br>
language files. Please extend functionality in a way
similar to my<br>
suggestion<br>
<a
href="https://code.vtiger.com/vtiger/vtigercrm/merge_requests/585#note_8739"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://code.vtiger.com/vtiger/vtigercrm/merge_requests/585#note_8739</a><br>
</div>
<div><br>
</div>
<div>Generally speaking, I think we should focus on making
the project more development friendly and extensible. To
that end I would just add:</div>
<div><br>
</div>
<div>* Avoid huge functions
like Inventory_Edit_View::process() which is almost 200
lines long: <a
href="https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Inventory/views/Edit.php"
target="_blank" moz-do-not-send="true">https://code.vtiger.com/vtiger/vtigercrm/blob/master/modules/Inventory/views/Edit.php</a>.
The other day I wanted to extend that function in a
custom inventory module. But you have to write
everything from scratch and duplicate code because there
are no helper functions that you can use from the parent
class. If instead of a 200 lines function you had 10 or
20 smaller functions, reuse would be easier.</div>
<div><br>
</div>
<div>Also, I think there should be a clear and transparent
method for managing open issues in the repository so
that we know:</div>
<div><br>
</div>
<div>* what is the process for deciding the priority an
issue gets.</div>
<div>* what is the order in which issues will be worked
on.</div>
<div>* what are the issues that are currently being worked
on.</div>
<div>* what issues are going to be addressed by vtiger and
which ones by us external developers.</div>
<div>* what are the main priorities for the current
release.</div>
<div>* make a guidelines document that explains all of the
above so that new developers (and also current ones)
know how to better contribute to the project and avoid
devs having to guess it and getting frustrated.</div>
<div><br>
</div>
<div><br>
</div>
<div>Finally I would like to mention a few features/fixes
that I think are important:</div>
<div><br>
</div>
<div>* fix google integration: contacts, calendar and
captcha. It's just broken since a long time ago.</div>
<div>* add filtering and searching capabilities to the
templates module. It's not very useful once you have
more than just a few records.</div>
<div>* this one mentioned by Alan: 7. Fix filters so
admins can remove/edit all of them and default landing</div>
when not "all": #706, #1461
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br clear="all">
<div>
<div dir="ltr">
<div dir="ltr">Saludos
<div><br>
</div>
<div>Rubén</div>
</div>
</div>
</div>
<br>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Sep 11, 2020 at
10:52 AM Uma S <<a href="mailto:uma.s@vtiger.com"
target="_blank" moz-do-not-send="true">uma.s@vtiger.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Thank you! Alan, Martin and Nilay for your
valuable insight, we will review them and prioritize.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Sep 11, 2020
at 3:05 PM Martin Allen <<a
href="mailto:martin.allen@clystnet.com"
target="_blank" moz-do-not-send="true">martin.allen@clystnet.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_default"
style="font-family:verdana,sans-serif"><br>
</div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">These may
be more appropriate as vTiger 8 aims but still:</div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">1) PHP
compatibility - as Alan said PHP 7.4 compatibility
should be a priority but also thinking about using
PHP8 which is very close to being released. </div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">2)
Dependent libraries using Composer to manage, this
then handles all updates required, and easy to
know which versions of libraries are being used
and can be specified which version should be
installed.</div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">3) PSR 12
(or even PSR 2!) coding style and PSR 4
autoloading (<a
href="https://www.php-fig.org/psr/"
target="_blank" moz-do-not-send="true">https://www.php-fig.org/psr/</a>) </div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">4)
Installation via Composer?</div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">5) Update
documentation</div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">6) Better
logging of Errors and improved Error messages -
most of the time we just see a blank screen, or a
message that is very misleading e.g. "Something
went wrong in a workflow" - would be much nicer if
it told me which workflow! (Logging of errors by
default as well, rather than having to actively
switch it on!) </div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">7) Making
the codebase suitable to be managed via GIT after
installation to allow for customisations -
currently the GIT repository on <a
href="http://code.vtiger.com" target="_blank"
moz-do-not-send="true">code.vtiger.com</a>
contains multiple .zip files which are next to
useless being managed in GIT. We maintain our own
repository which is the code AFTER it has been
installed, and fork that repository for every new
installation we do. We also have created our own
.gitignore (after MUCH trial and error!) so having
a community version would be nice! </div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">8) CLI
database migration scripts for creating / updating
database between different versions</div>
<div class="gmail_default"
style="font-family:verdana,sans-serif"><br>
</div>
<div class="gmail_default"
style="font-family:verdana,sans-serif">Oh and all
the outstanding bugs ;)</div>
<div>
<div dir="ltr">
<div dir="ltr">
<div>
<div dir="ltr">
<p
style="font-size:12.8px;color:rgb(80,0,80)"><span
style="color:navy;font-family:Verdana,sans-serif;font-size:10pt">Martin
Allen</span></p>
<p
style="font-size:12.8px;color:rgb(80,0,80)"><b
style="font-size:12.8px"><span
style="font-size:10pt;font-family:Verdana,sans-serif;color:rgb(51,51,153)"
lang="EN-US">01392 248692 - Main
Office<br>
01392 690659 - Direct Line</span></b><br>
</p>
<p
style="font-size:12.8px;color:rgb(80,0,80)"><b><span
style="font-size:10pt;font-family:Verdana,sans-serif;color:rgb(51,51,153)"><img
alt="signature2"
moz-do-not-send="true" width="288"
height="65"></span></b><span
style="color:rgb(31,73,125)"></span></p>
<p
style="font-size:12.8px;color:rgb(80,0,80)"><span
style="font-size:10pt;font-family:Verdana,sans-serif;color:navy"
lang="EN-US">Have you visited our
website recently? <a
href="http://www.clystnet.com/"
style="color:rgb(17,85,204)"
target="_blank"
moz-do-not-send="true">http://www.clystnet.com</a></span><span
style="color:rgb(31,73,125)"></span></p>
<p
style="font-size:12.8px;color:rgb(80,0,80)"><span
style="font-size:10pt;font-family:Verdana,sans-serif;color:navy"
lang="EN-US"><br>
</span><span
style="font-size:10pt;font-family:Verdana,sans-serif;color:rgb(153,153,153)"
lang="EN-US">The information in this
email is confidential If you are not
the intended recipient, you must not
read or use that information. This
email and any attachments are believed
to be virus free however no
responsibility is accepted by Clystnet
for any loss or damage arising in any
way from receipt or use thereof.
Clystnet Ltd (company reg number
7164503) is based at Silverdown Park,
Fair Oak Close, Clyst Honiton, EX5 2UX</span></p>
</div>
</div>
</div>
</div>
</div>
<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, 11 Sep
2020 at 09:41, Alan Lord <<a
href="mailto:alanslists@gmail.com"
target="_blank" moz-do-not-send="true">alanslists@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px
0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">Thanks for
reaching out Uma,<br>
<br>
Here are some of my suggestions (not in any
preferential order):<br>
<br>
1. Get vtiger up-to-date in terms of requirements
for PHP etc. And then <br>
have a process/plan to keep it up-to-date, i.e.
using unit tests, <br>
linters etc. FWIW, php7.3 ends active support in 2
months. 7.4 has been <br>
out for nearly a year already.<br>
<br>
2. Improve the server/rest APIs so they provide
better information (i.e. <br>
optional user-level formatting of returned, data,
see <br>
<a
href="http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2020-August/038853.html"
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2020-August/038853.html</a>
<br>
and <br>
<a
href="http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2020-August/038838.html"
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2020-August/038838.html</a>).
<br>
Maybe move the REST API to json format like vtiger
cloud?<br>
<br>
3. Import the webhook workflow functionality from
Cloud<br>
<br>
4. Add support to vtws_retrieve so any user can
get "safe" information <br>
about _any_ other user. See #1155 and <br>
<a
href="http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2020-April/038517.html"
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://lists.vtigercrm.com/pipermail/vtigercrm-developers/2020-April/038517.html</a><br>
<br>
5. Fix #676, #1003 and try to remove that horrible
hack <br>
vtlib_setup_modulevars(). All the necessary
information should be in the <br>
respective modules' class file anyway. I really
fail to see what the <br>
point of this is and it continues to cause
problems.<br>
<br>
6. Code cleanup. There are multiple copies of the
long and complex <br>
date/time structures such as in
modules/Vtiger/models/Field.php line <br>
653, modules/Reports/ReportRun.php line 1740,
modules/Reports/Report.php <br>
line 990, modules/CustomView/models/Record.php
line 805, <br>
modules/CustomView/CustomView.php line 569...
There are so many <br>
instances of code duplication (not just the
above)... Put it all in ONE <br>
place, then there's only one place we have to fix
later on.<br>
<br>
7. Fix filters so admins can remove/edit all of
them and default landing <br>
when not "all": #706, #1461<br>
<br>
8. #1240<br>
<br>
9. See merge request #585 which added support for
customising core <br>
language files. Please extend functionality in a
way similar to my <br>
suggestion <br>
<a
href="https://code.vtiger.com/vtiger/vtigercrm/merge_requests/585#note_8739"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://code.vtiger.com/vtiger/vtigercrm/merge_requests/585#note_8739</a><br>
<br>
10. Update online documentation for the Open
Source platform. It's not <br>
been changed for *ages*. (If you, vtiger don't
have the bandwidth, then <br>
let us in the community have some level of access
to the wiki or <br>
whatever and let us write some of it - you could
have a moderator's role <br>
to approve/deny if you like).<br>
<br>
That should do for now ;-)<br>
<br>
Cheers<br>
<br>
Al<br>
<br>
On 11/09/2020 06:58, Uma S wrote:<br>
> Dear Developer,<br>
> <br>
> We are happy to accept more ideas from the
community on what are the top <br>
> 10 wish enhancements for 7.4? So that we can
make the release fruitful.<br>
> <br>
> I would request all the community members to
take part in this to share <br>
> their thoughts.<br>
_______________________________________________<br>
<a href="http://www.vtiger.com/" rel="noreferrer"
target="_blank" moz-do-not-send="true">http://www.vtiger.com/</a><br>
</blockquote>
</div>
_______________________________________________<br>
<a href="http://www.vtiger.com/" rel="noreferrer"
target="_blank" moz-do-not-send="true">http://www.vtiger.com/</a></blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr">
<div dir="ltr">With<br>
Best Regards<br>
Uma.S<br>
<div>Vtiger Team</div>
</div>
</div>
_______________________________________________<br>
<a href="http://www.vtiger.com/" rel="noreferrer"
target="_blank" moz-do-not-send="true">http://www.vtiger.com/</a></blockquote>
</div>
_______________________________________________<br>
<a href="http://www.vtiger.com/" rel="noreferrer"
target="_blank" moz-do-not-send="true">http://www.vtiger.com/</a></blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">With<br>
Best Regards<br>
Uma.S<br>
<div>Vtiger Team</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
<a class="moz-txt-link-freetext" href="http://www.vtiger.com/">http://www.vtiger.com/</a></pre>
</blockquote>
<br>
</body>
</html>