[Vtigercrm-developers] closing php tag and corrupted excel files

[Rubén A. Estrada Orozco]

Hi,

Today I had to fix a  problem with excel files downloaded from the
documents module.  The files didn't display correctly, just a bunch of
unreadable characters like these:

[image: image.png]

The problem was that there was a new line at the end of the config.inc.php
file.

Wouldn't it be a good idea to get rid of the closing "?>" part of the php
tag?

I think that in general it would be good to avoid closing php tags. There
are projects like prestashop that set it as a coding guideline.



Saludos

Rubén
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200903/71af8368/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 95206 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200903/71af8368/attachment-0001.png>