[Vtigercrm-developers] New Customer Portal for V7.1

[Satish Dvnk]

Hi Alan,

> What does *$site_URL* mean? Is the the CRM url or the portal url?
CRM Url (from config.inc.php)

Earlier, we have used the variables $server_Path and $authenticate_Path for
customer portal. Current version, We liked to deprecate these variables so
we have retained it. We used $site_URL instead of $server_Path as
Client.php(vtlib/Net/) depending on the site url. So we can ignore those
older variables. I will update these in the next commit

> It is a "bomb". That means it has no top-level directory, e.g.
customer-portal/. This is not good practice.
Thank you for letting us know, I will reconstruct the zip on top-level
directory

> Once unzipped, all files and directories are created with rwxrwxrwx. this
is definitely not good practice. No files should need to be executable in
this package from what I can see.
Thank you. We will check file permission while updating the zip.




*regards,Satish.Dvnk*

On Thu, Feb 1, 2018 at 3:53 PM, Alan Lord <alanslists at gmail.com> wrote:

> In PortalConfig.php:
>
> global $server_Path;
>> global $portal_Path; *Doesn't seem to exist anywhere else*
>>
>> //CRM URL without trialing/
>> //Example: http://yourdomain.com/crm
>> $server_Path = "";
>>
>> //Portal URL without trialing/
>> //Example: http://yourdomain.com/portal
>> $authenticate_Path = "";
>>
>
> Then in config.php we get:
>
>         protected static function getData() {
>>                 global $site_URL; *is referenced in a few places but not
>> configured anywhere*
>>                 global $maxFileSize;
>>                 global $defaultUiLanguage;
>>                 global $availableLanguages;
>>                 $crmUrl = self::$data['crm.url'];
>>
>>                 if (!empty($site_URL) && strpos($crmUrl, $site_URL) ===
>> false) {
>>                         self::$data['crm.url'] = $site_URL.$crmUrl;
>>                 }
>>                 self::$data['upload_max_filesize'] = $maxFileSize;
>>                 self::$data['ui.Language'] = $defaultUiLanguage;
>>                 self::$data['languages'] = $availableLanguages;
>>                 self::$data['server_Path'] = $server_Path; *server?* What
>> "server?
>>                 self::$data['authenticate_Path'] = $authenticate_Path;
>> *authenticate*? again confusing.
>>                 return self::$data;
>>
>
> I have no idea what is supposed to be what?
>
> What does $site_URL mean? Is the the CRM url or the portal url? Giving
> your variables some sensible descriptive names would be a help ;-)
>
> I don't really understand what authenticate_url means either? Surely the
> person logging in authenticates against what is configured in vtiger?
>
> Confused.
>
> Al
>
>
> _______________________________________________
> http://www.vtiger.com/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20180201/db77ed41/attachment.html>