[Vtigercrm-developers] notices, warnings, deprecations, stricts

[Tim Mohrbach]

Thanks a lot for the feedback! Also really cool to see so much positive
feedback!
I wasn't exactly sure about that topic, but this feedback encourages me to
spend some time on it every now and then. I also think this will improve
quality and performance and I'm happy to contribute some time. The process
will take a while and will be done gradually...

I started a [WIP] merge request, open for anyone to contribute, review,
comment: http://code.vtiger.com/vtiger/vtigercrm/merge_requests/25

On 2 February 2016 at 18:40, Sutharsan Jeganathan <ajstharsan at gmail.com>
wrote:

> Hi Tim
>
> What I feel is the "Warning" is the essential stuff has to be fixed. Also
> in PHP7 the warnings are some how merging with Fatal errors. Others such as
> strict and notices might not be serious issue, if disabled at php.ini, but
> anyway impact on memory usages, thus performance too.
>
> I think  code optimization (and cleanup too) has to be considered as a
> separate project, since there are thousands of php files scattered with
> different standards.
>
> Thanks
> Sutharsan Jeganathan
>
> On Tue, Feb 2, 2016 at 3:10 PM, Stacey Johnson <
> stacey.johnson110 at gmail.com> wrote:
>
>> Great stuff Tim. Lets watch merging performance ..
>>
>> Stacey
>>
>> On Tue, Feb 2, 2016 at 12:02 AM, Tim Mohrbach <preexo at googlemail.com>
>> wrote:
>>
>>> As everyone knows, vtiger is throwing notices, warnings, deprecation
>>> warnings and strict errors all over the place. I always thought it would
>>> improve the overall quality of the project if the code lines which cause
>>> this were improved someday. I was a little bored in the last hour (don’t
>>> ask) and tackled all of those notices that were thrown only when vtiger is
>>> being opened the very first time, for installation. It’s only a couple of
>>> changes and they were gone.
>>>
>>> @vtiger core developer team: Now I’m wondering if this would actually be
>>> of any interest to the vtiger team? Would such changes actually stand any
>>> chance of making it into the master?
>>> @vtiger core developer team: Also, I’m wondering which way of securing
>>> the lines would be preferred. I used a few different approaches, sometimes
>>> declaring a return variable beforehand with default values, sometimes
>>> returning a ternary expression, some changes make the code longer, some
>>> easier to read, some are obviously dull, but please could you comment which
>>> way of securing those code lines you would prefer?
>>> @Everyone else: what do you think about this topic? Interesting, boring,
>>> good, stupid?
>>>
>>> So if I’m wasting my time here, please let me know then I won’t do this
>>> again next time I’m bored, but in case you are interested, let me know some
>>> feedback on the way those things should be adjusted.
>>>
>>> I commited all changes to make the install start page notice and warning
>>> free to this branch:
>>> http://code.vtiger.com/preexo/vtigercrm/commit/7f7486074d0fb4549ca9524cf36f65d8e4bd5bab
>>>
>>>
>>>
>>> _______________________________________________
>>> http://www.vtiger.com/
>>
>>
>>
>> _______________________________________________
>> http://www.vtiger.com/
>>
>
>
> _______________________________________________
> http://www.vtiger.com/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20160203/70a19766/attachment.html>