[Vtigercrm-developers] notices, warnings, deprecations, stricts

[Prasad]

This is a great idea - but demands plenty of time to achieve across the
product
and extensions already developed.For now tuning PHP configuration looks
better.

By all means continue with the changes - we would be happy to work on the
merge-request.

Regards,
Prasad

--
FB <http://www.facebook.com/vtiger> I Twit <http://twitter.com/vtigercrm> I
LIn <https://www.linkedin.com/company/1270573?trk=tyah> I Blog
<https://blogs.vtiger.com> I Website <https://www.vtiger.com/>

On Mon, Feb 1, 2016 at 10:41 PM, Alan Bell <alan.bell at libertus.co.uk> wrote:

> excellent idea, something I have been meaning to do for ages, I am sure
> that in some places, in the tighter loops, the process of evaluating the
> error and deciding whether to log it probably causes a performance hit, so
> fixing this probably makes things faster. It certainly makes real problems
> easier to find if you can turn on error reporting and not get tons of cruft
> from minor issues.
>
>
>
> On 01/02/16 17:02, Tim Mohrbach wrote:
>
>> As everyone knows, vtiger is throwing notices, warnings, deprecation
>> warnings and strict errors all over the place. I always thought it would
>> improve the overall quality of the project if the code lines which cause
>> this were improved someday. I was a little bored in the last hour (don’t
>> ask) and tackled all of those notices that were thrown only when vtiger is
>> being opened the very first time, for installation. It’s only a couple of
>> changes and they were gone.
>>
>> @vtiger core developer team: Now I’m wondering if this would actually be
>> of any interest to the vtiger team? Would such changes actually stand any
>> chance of making it into the master?
>> @vtiger core developer team: Also, I’m wondering which way of securing
>> the lines would be preferred. I used a few different approaches, sometimes
>> declaring a return variable beforehand with default values, sometimes
>> returning a ternary expression, some changes make the code longer, some
>> easier to read, some are obviously dull, but please could you comment which
>> way of securing those code lines you would prefer?
>> @Everyone else: what do you think about this topic? Interesting, boring,
>> good, stupid?
>>
>> So if I’m wasting my time here, please let me know then I won’t do this
>> again next time I’m bored, but in case you are interested, let me know some
>> feedback on the way those things should be adjusted.
>>
>> I commited all changes to make the install start page notice and warning
>> free to this branch:
>> http://code.vtiger.com/preexo/vtigercrm/commit/7f7486074d0fb4549ca9524cf36f65d8e4bd5bab
>>
>>
>>
>> _______________________________________________
>> http://www.vtiger.com/
>>
>
> _______________________________________________
> http://www.vtiger.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20160202/597cd175/attachment.html>