[Vtigercrm-developers] Finding more info regarding fix trac ticket

Tue Jul 8 07:11:40 GMT 2014

Hi,

As I can see, this bug is from vt5.2 and not from 5.4. Actually, is supossed
that in 5.4 vtiger team fixed this.

So, I think is the main reason in coreBOS works, just because is an
extension from vt5.4.

I wanted to clarify this for Joe don't get mad trying to find the fix among
coreBOS commits :).

To OP, try to parse some core files (include/home.php?) with 5.4 files but
you must be, very very lucky to make it works. The besy way is debugging and
see what is happening and why this $query is doing a bad query.

Greetings.

De: vtigercrm-developers-bounces at lists.vtigercrm.com
[mailto:vtigercrm-developers-bounces at lists.vtigercrm.com] En nombre de
Sreenivas Kanumuru
Enviado el: martes, 8 de julio de 2014 8:35
Para: Joe Bordes; vtigercrm-developers at lists.vtigercrm.com
Asunto: Re: [Vtigercrm-developers] Finding more info regarding fix trac
ticket

This issue is something I have asked many times, vtiger PLEASE document the
changes, it is useless to say "it works in the current code", we need to see
what you are doing to be able to evaluate and help.

Joe, Since January, we have been adding the change-sets in trac when fixing
issues. We weren't following this earlier. I apologize.

Regards,

Sreenivas

On Fri, Jul 4, 2014 at 3:02 PM, Joe Bordes <joe at tsolucio.com
<mailto:joe at tsolucio.com> > wrote:

This issue is something I have asked many times, vtiger PLEASE document the
changes, it is useless to say "it works in the current code", we need to see
what you are doing to be able to evaluate and help.

@Rami, I had a look to see if I could see it but I have no idea where the
change is, all I can say is that it works in coreBOS, so we must have
applied the fix along the way. I tried comparing the most obvious places:
modules/CustomView, include/utils/ListViewUtils, modules/Home,
include/home.php but I couldn't find it.

All the action happens in include/home.php, on the lines 258-263:

                if($modname == "Calendar"){
                    $listquery = getListQuery($modname);
                    if(trim($listquery) == ''){
                        $listquery = $focus->getListQuery($modname);
                    }
                    $query =
$oCustomView->getModifiedCvListQuery($cvid,$listquery,$modname);

in my install and test, the $query variable contains a correct SQL command
for my filter.

Hope that helps...

Joe
TSolucio

On 04/07/14 08:29, Rami Addady wrote:

Hello,

Thank you for your replay

> Can you please check this issue here in vtiger 6.1.0
<http://trac.vtiger.com/svn/vtiger/vtigercrm/branches/6.1.0/>  . If its
reproducible, please get back to us.

But V6.1 not relevant to my question.

It say the ticket was fix in V5.4.
How can I find which files where involve?

Regards,
Rami Addady

On 07/03/2014 03:44 PM, Uma S wrote:

Hi, 

Can you please check this issue here in vtiger 6.1.0
<http://trac.vtiger.com/svn/vtiger/vtigercrm/branches/6.1.0/>  . If its
reproducible, please get back to us.

On Thu, Jul 3, 2014 at 6:05 PM, Rami Addady <rami at active.co.il
<mailto:rami at active.co.il> > wrote:

Hello,

I'm trying to find the fix to a bug. Bug that was reported as fixed in the
trac.

The ticket mention it was fix in v5.4:
http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7074#no2

How can I locate the file / lines which where involve?

Regards,
Rami Addady

_______________________________________________
http://www.vtiger.com/

-- 

With
Best Regards
Uma.S

Vtiger Team

_______________________________________________
http://www.vtiger.com/

_______________________________________________
http://www.vtiger.com/

-- 
Un saludo
Joe
TSolucio

_______________________________________________
http://www.vtiger.com/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20140708/a7b17654/attachment.html>