[Vtigercrm-developers] RecurringType.fromUserRequest vs vt_DateTime.getThisweekDaysbyIndex

[Adam Heinz]

I'm going to fix this one way or another.  This is good opportunity for the
vtiger team to get it fixed the way they prefer, if they respond.  ;)


On Tue, May 28, 2013 at 10:55 AM, Adam Heinz <amh at metricwise.net> wrote:

> I'm seeing a discrepancy in how day in week index is used.
>  The getThisweekDaysbyIndex function expects [1,7] whereas fromUserRequest
> sets [0,6].  I've done the obvious off-by-one tweaks, but it still tends to
> die with, "day is invalid".  It looks like Asha merged this behavior in
> change 13835 for 5.4.0.  Any chance you guys could sift out the specific
> diffs for me that modified this behavior?  The massive 5.4.0 diff is too
> much for me to sift through.  I would also happily accept read-only access
> to whatever Subversion repository the work was done in.  ;)
>
> Steps to reproduce (on demo.vtiger.com):
> 1. Login as admin
> 2. Open Calendar, Add Meeting
> Event name = OOO
> Event starts at = 03:00 PM 2013-06-02
> Event ends on = 04:00 PM 2013-06-30
> 3. Repeat tab
> Enable repeat
> Repeat once every 1 Week(s) Until: 2013-06-30
> Check Sun
> 4. Save
> FAIL: day is invalid
>
> You can also use this GET URL [3] to generate the error, which is normally
> an AJAX POST.
>
> [1]
> http://trac.vtiger.com/cgi-bin/trac.cgi/browser/vtigercrm/branches/6.0.0/include/utils/RecurringType.php#L82
> [2]
> http://trac.vtiger.com/cgi-bin/trac.cgi/browser/vtigercrm/branches/6.0.0/modules/Calendar/Date.php#L128
> [3]
> https://demo.vtiger.com/index.php?action=Save&activity_mode=Events&activitytype=Meeting&assigned_group_id=3&assigned_user_id=1&assigntype=U&calendar_repeat_limit_date=2013-06-30&contactidlist=&date_start=2013-06-02&dateformat=%25Y-%25m-%25d&day=28&del_actparent_rel=&deletecntlist=&description=&due_date=2013-06-30&duration_hours=673&duration_minutes=0&endfmt=pm&endhr=05&endmin=50&eventsave=Save&eventstatus=Planned&followup_date=2013-05-05&followup_due_date=&followup_startfmt=pm&followup_starthr=05&followup_startmin=50&followup_time_end=&followup_time_start=&hour=14&inviteesid=&location=&maintab=Calendar&mode=create&module=Calendar&month=5&parent_id=&parent_name=&parent_type=Leads&parenttab=My%20Home%20Page&record=&recurringcheck=on&recurringtype=Weekly&remdays=0&remhrs=0&remmin=1&repeatMonth=date&repeatMonth_date=2&repeatMonth_day=1&repeatMonth_daytype=first&repeat_frequency=1&return_action=index&return_module=Calendar&startfmt=pm&starthr=04&startmin=50&subject=OOO&subtab=event&sun_flag=sunday&taskpriority=High&time_end=17%3A50&time_start=16%3A50&view=week&viewOption=hourview&year=2013
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130604/9797ecc9/attachment.html>