<div dir="ltr">I'm going to fix this one way or another.  This is good opportunity for the vtiger team to get it fixed the way they prefer, if they respond.  ;)</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, May 28, 2013 at 10:55 AM, Adam Heinz <span dir="ltr"><<a href="mailto:amh@metricwise.net" target="_blank">amh@metricwise.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div>I'm seeing a discrepancy in how day in week index is used.  The getThisweekDaysbyIndex function expects [1,7] whereas fromUserRequest sets [0,6].  I've done the obvious off-by-one tweaks, but it still tends to die with, "day is invalid".  It looks like Asha merged this behavior in change 13835 for 5.4.0.  Any chance you guys could sift out the specific diffs for me that modified this behavior?  The massive 5.4.0 diff is too much for me to sift through.  I would also happily accept read-only access to whatever Subversion repository the work was done in.  ;)<br>

</div><div><br></div><div>Steps to reproduce (on <a href="http://demo.vtiger.com" target="_blank">demo.vtiger.com</a>):</div><div>1. Login as admin</div><div>2. Open Calendar, Add Meeting</div><div>Event name = OOO</div>
<div>Event starts at = 03:00 PM 2013-06-02</div>
<div>Event ends on = 04:00 PM 2013-06-30</div><div>3. Repeat tab</div><div>Enable repeat</div><div>Repeat once every 1 Week(s) Until: 2013-06-30</div><div>Check Sun</div><div>4. Save</div><div>
FAIL: day is invalid</div><div><br></div><div>You can also use this GET URL [3] to generate the error, which is normally an AJAX POST.</div><div><br></div><div>[1] <a href="http://trac.vtiger.com/cgi-bin/trac.cgi/browser/vtigercrm/branches/6.0.0/include/utils/RecurringType.php#L82" target="_blank">http://trac.vtiger.com/cgi-bin/trac.cgi/browser/vtigercrm/branches/6.0.0/include/utils/RecurringType.php#L82</a><br>

</div><div><div>[2] <a href="http://trac.vtiger.com/cgi-bin/trac.cgi/browser/vtigercrm/branches/6.0.0/modules/Calendar/Date.php#L128" target="_blank">http://trac.vtiger.com/cgi-bin/trac.cgi/browser/vtigercrm/branches/6.0.0/modules/Calendar/Date.php#L128</a><br>

</div></div><div>[3] <a href="https://demo.vtiger.com/index.php?action=Save&activity_mode=Events&activitytype=Meeting&assigned_group_id=3&assigned_user_id=1&assigntype=U&calendar_repeat_limit_date=2013-06-30&contactidlist=&date_start=2013-06-02&dateformat=%25Y-%25m-%25d&day=28&del_actparent_rel=&deletecntlist=&description=&due_date=2013-06-30&duration_hours=673&duration_minutes=0&endfmt=pm&endhr=05&endmin=50&eventsave=Save&eventstatus=Planned&followup_date=2013-05-05&followup_due_date=&followup_startfmt=pm&followup_starthr=05&followup_startmin=50&followup_time_end=&followup_time_start=&hour=14&inviteesid=&location=&maintab=Calendar&mode=create&module=Calendar&month=5&parent_id=&parent_name=&parent_type=Leads&parenttab=My%20Home%20Page&record=&recurringcheck=on&recurringtype=Weekly&remdays=0&remhrs=0&remmin=1&repeatMonth=date&repeatMonth_date=2&repeatMonth_day=1&repeatMonth_daytype=first&repeat_frequency=1&return_action=index&return_module=Calendar&startfmt=pm&starthr=04&startmin=50&subject=OOO&subtab=event&sun_flag=sunday&taskpriority=High&time_end=17%3A50&time_start=16%3A50&view=week&viewOption=hourview&year=2013" target="_blank">https://demo.vtiger.com/index.php?action=Save&activity_mode=Events&activitytype=Meeting&assigned_group_id=3&assigned_user_id=1&assigntype=U&calendar_repeat_limit_date=2013-06-30&contactidlist=&date_start=2013-06-02&dateformat=%25Y-%25m-%25d&day=28&del_actparent_rel=&deletecntlist=&description=&due_date=2013-06-30&duration_hours=673&duration_minutes=0&endfmt=pm&endhr=05&endmin=50&eventsave=Save&eventstatus=Planned&followup_date=2013-05-05&followup_due_date=&followup_startfmt=pm&followup_starthr=05&followup_startmin=50&followup_time_end=&followup_time_start=&hour=14&inviteesid=&location=&maintab=Calendar&mode=create&module=Calendar&month=5&parent_id=&parent_name=&parent_type=Leads&parenttab=My%20Home%20Page&record=&recurringcheck=on&recurringtype=Weekly&remdays=0&remhrs=0&remmin=1&repeatMonth=date&repeatMonth_date=2&repeatMonth_day=1&repeatMonth_daytype=first&repeat_frequency=1&return_action=index&return_module=Calendar&startfmt=pm&starthr=04&startmin=50&subject=OOO&subtab=event&sun_flag=sunday&taskpriority=High&time_end=17%3A50&time_start=16%3A50&view=week&viewOption=hourview&year=2013</a></div>

</div>
</blockquote></div><br></div>