[Vtigercrm-developers] module/Emails/mail.php

[Adam Heinz]

This is the function that VTEmailTask uses, which we use for
workflow-driven transactional emails.  It hasn't given us any trouble.


On Fri, Apr 19, 2013 at 3:14 AM, Alan Lord <alanslists at gmail.com> wrote:

> Just noticed some odd stuff in the above file.
>
> in function send_email around line 93:
>
>         $mail_error = getMailError($mail,$mail_**status,$mailto);
>
> $mailto is not defined anywhere.
>
> In the function getMailError($mail,$mail_**status,$to)
>
> $to is never examined!
>
> Also $error_msg is not set in the final else block (It's commented out) so
> the return $error_msg will return NULL I guess.
>
> This all looks very dodgy and old code from what I can tell.
>
> Should I be using a different mailer tool for sending emails from custom
> cron scripts?
>
> Cheers
>
> Al
>
>
>
> ______________________________**_________________
> http://www.vtiger.com/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130419/3d2a6fb1/attachment.html>