[Vtigercrm-developers] [Fwd: Regarding Patch 4 Rlease]
Brian Devendorf
developer at infointegrated.com
Sun Feb 12 16:30:52 PST 2006
Not sure where we are with the branch at this point. I had some time
and decided to try this patch on the 4.2.3 code. There were a few
problems...
Here's what I found:
/include/utils.php (line 812) in function get_group_options:
$sql = "select groupname from groups";
(The patch changes the field from "name" to "groupname". Not sure
why, nor if there are other changes. It seemed to work changing this
line to "name", as well as updating the SQL table to "groupname" -
which is the option I chose. This fix corrects the "New Ticket"
option, which was not displaying at all.)
/modules/Home/index.php (line 157:160) add new line:
$list .= $row["type"];
$list .= '</td>';
+ $list .= '<td WIDTH="1" class="blackLine"><IMG SRC="'.
$image_path.'blank.gif"></td>';
$list .= '</tr>';
$i++;
(This patch corrects the missing right border on the My Group
Allocations section on the Home module.)
/modules/HelpDesk/ListTickets.php (line 107):
$list.='</tr>';
(This didn't cause any problems, but clearly should be a </tr>, not
the <tr> it was originally in the script).
With a bit of free time from the normal day-to-day business support,
I have setup a development instance on my server for v4.2 branches.
Once the branch is on the new CVS, I'd like to start helping in
testing and troubleshooting. I'm new to CVS (not PHP), so I would
also need some simple instructions on how to pull a distribution from
CVS. Also, if there is a preferred format for posting patch code,
please let me know.
Thanks,
Brian
On Feb 3, 2006, at 5:11 PM, Mike Fedyk wrote:
> Matthew Brichacek wrote:
>
>> Yea I wanted to start breaking this down into sub-patches with
>> diffs and
>> then send those to the list, from there we can check them in one-
>> by-one
>> with the proper comments. I thought I would post it anyways so other
>> people can start reviewing it.
>>
> I don't think posting the patch will be very helpful, but here's the
> diffstat.
>
> This might be what is in the 4.5 branch in cvs/svn. Dunno if that
> will
> be any better.
>
> Mike
>
> 422_to_424.php |only
>
> Release_Notes.html |only
>
> SendReminder.php | 2
>
> bin/startvTiger.bat | 28
>
> bin/startvTiger.sh | 10
>
> bin/stopvTiger.bat | 8
>
> bin/uninstallvtiger.sh | 28
>
> contactserialize.php | 219
>
> cron/send_mail.php | 2
>
> data/CRMEntity.php | 108
>
> include/Calc.php | 2
>
> include/ColorPicker2.js |only
>
> include/ComboStrings.php | 3
>
> include/CustomFieldUtil.php | 37
>
> include/RelatedListView.php | 280
>
> include/database/PearDatabase.php | 49
>
> include/dd |only
>
> include/general.js | 64
>
> include/images/bgcolor.gif |only
>
> include/language/en_us.lang.php | 17
>
> include/nusoap/changelog | 682
>
> include/nusoap/class.nusoap_base.php | 1561 -
>
> include/nusoap/class.soap_fault.php | 149
>
> include/nusoap/class.soap_parser.php | 1127 -
>
> include/nusoap/class.soap_server.php | 1864 +-
>
> include/nusoap/class.soap_transport_http.php | 1798 +
>
> include/nusoap/class.soap_val.php | 163
>
> include/nusoap/class.soapclient.php | 1496 -
>
> include/nusoap/class.wsdl.php | 3026 +--
>
> include/nusoap/class.wsdlcache.php | 344
>
> include/nusoap/class.xmlschema.php | 1671 -
>
> include/nusoap/nusoap.php |12836 ++
> +++++-------
>
> include/nusoap/nusoapmime.php | 723
>
> include/submenu.js | 6
>
> include/uifromdbutil.php | 59
>
> include/utils.php | 1009 +
>
> install/0welcome.php | 2558 ++
>
> install/1checkSystem.php | 261
>
> install/2setConfig.php | 285
>
> install/3confirmConfig.php | 757
>
> install/4createConfigFile.php | 344
>
> install/5createTables.php | 274
>
> install/images |only
>
> install/install.css | 10
>
> install/populateSeedData.php | 17
>
> log4php/appenders/LoggerAppenderFile.php | 2
>
> modules/Accounts/Account.php | 75
>
> modules/Accounts/Delete.php | 6
>
> modules/Accounts/DetailView.html | 2
>
> modules/Accounts/EditView.html | 1
>
> modules/Accounts/EditView.php | 1
>
> modules/Accounts/Forms.php | 124
>
> modules/Accounts/ListView.html | 146
>
> modules/Accounts/ListView.php | 73
>
> modules/Accounts/ListViewTop.php | 8
>
> modules/Accounts/Merge.php | 245
>
> modules/Accounts/Popup.html | 186
>
> modules/Accounts/Save.php | 6
>
> modules/Accounts/SearchForm.html | 14
>
> modules/Accounts/language/en_us.lang.php | 4
>
> modules/Activities/Activity.php | 34
>
> modules/Activities/Delete.php | 6
>
> modules/Activities/DetailView.html | 2
>
> modules/Activities/EditView.html | 9
>
> modules/Activities/EditView.php | 1
>
> modules/Activities/Forms.php | 295
>
> modules/Activities/ListView.php | 29
>
> modules/Activities/OpenListView.html | 17
>
> modules/Activities/OpenListView.php | 40
>
> modules/Activities/Save.php | 46
>
> modules/Activities/SendReminder.php | 2
>
> modules/Calendar/UserCalendar.php | 2
>
> modules/Calendar/appointment.pinc | 4
>
> modules/Calendar/calendar_day.php | 26
>
> modules/Calendar/calendar_month.php | 27
>
> modules/Calendar/calendar_week.php | 49
>
> modules/Contacts/AddBusinessCard.php | 23
>
> modules/Contacts/Contact.php | 142
>
> modules/Contacts/Delete.php | 5
>
> modules/Contacts/DetailView.html | 5
>
> modules/Contacts/DetailView.php | 5
>
> modules/Contacts/EditView.html | 1
>
> modules/Contacts/EditView.php | 4
>
> modules/Contacts/Forms.php | 135
>
> modules/Contacts/ListView.html | 136
>
> modules/Contacts/ListView.php | 54
>
> modules/Contacts/Merge.php | 219
>
> modules/Contacts/Popup.html | 17
>
> modules/Contacts/RenderRelatedListUI.php | 4
>
> modules/Contacts/Save.php | 74
>
> modules/CustomView/CustomView.php | 50
>
> modules/CustomView/EditView.html | 1
>
> modules/CustomView/ListViewTop.php | 10
>
> modules/CustomView/PopulateCustomView.php | 2
>
> modules/CustomView/language/en_us.lang.php | 5
>
> modules/Dashboard/Chart_my_pipeline_by_sales_stage.php | 2
>
> modules/Dashboard/Chart_outcome_by_month.php | 2
>
> modules/Dashboard/Chart_pipeline_by_sales_stage.php | 2
>
> modules/Emails/Choose.php |only
>
> modules/Emails/ChooseEmail.php |only
>
> modules/Emails/Delete.php | 5
>
> modules/Emails/DetailView.html | 3
>
> modules/Emails/DetailView.php | 18
>
> modules/Emails/EditView.html | 7
>
> modules/Emails/EditView.php | 663
>
> modules/Emails/Email.php | 33
>
> modules/Emails/Forms.php | 131
>
> modules/Emails/ListView.html | 9
>
> modules/Emails/ListView.php | 20
>
> modules/Emails/Save.php | 748
>
> modules/Emails/SelectEmails.php |only
>
> modules/Emails/mail.php |only
>
> modules/Emails/mailsend.php |only
>
> modules/Emails/sendmail.php | 4
>
> modules/Faq/DetailView.html | 2
>
> modules/Faq/EditView.php | 2
>
> modules/Faq/ListView.php | 8
>
> modules/Help/index.php | 2
>
> modules/HelpDesk/Delete.php | 8
>
> modules/HelpDesk/DetailView.html | 2
>
> modules/HelpDesk/DetailView.php | 18
>
> modules/HelpDesk/EditView.html | 1
>
> modules/HelpDesk/EditView.php | 3
>
> modules/HelpDesk/Forms.php | 123
>
> modules/HelpDesk/HelpDesk.php | 80
>
> modules/HelpDesk/ListTickets.php | 2
>
> modules/HelpDesk/ListView.html | 56
>
> modules/HelpDesk/ListView.php | 54
>
> modules/HelpDesk/Merge.php | 246
>
> modules/HelpDesk/Save.php | 62
>
> modules/HelpDesk/TicketStatisticsUtil.php | 15
>
> modules/Home/home_rss.php |only
>
> modules/Import/ImportContact.php | 9
>
> modules/Import/ImportStep1.php | 2
>
> modules/Import/ImportStep2.php | 2
>
> modules/Import/ImportStep3.php | 4
>
> modules/Import/ImportStep4.php | 2
>
> modules/Import/UsersLastImport.php | 2
>
> modules/Import/language/en_us.lang.php | 2
>
> modules/Invoice/CreatePDF.php | 38
>
> modules/Invoice/Delete.php | 8
>
> modules/Invoice/DetailView.html | 2
>
> modules/Invoice/EditView.html | 1
>
> modules/Invoice/EditView.php | 3
>
> modules/Invoice/Invoice.php | 57
>
> modules/Invoice/ListView.php | 20
>
> modules/Invoice/Save.php | 7
>
> modules/Invoice/language/en_us.lang.php | 3
>
> modules/Leads/Delete.php | 7
>
> modules/Leads/DetailView.html | 6
>
> modules/Leads/DetailView.php | 5
>
> modules/Leads/EditView.html | 1
>
> modules/Leads/EditView.php | 2
>
> modules/Leads/Forms.php | 133
>
> modules/Leads/Lead.php | 80
>
> modules/Leads/LeadConvertToEntities.php | 9
>
> modules/Leads/ListView.html | 119
>
> modules/Leads/ListView.php | 50
>
> modules/Leads/Merge.php | 180
>
> modules/Leads/Popup.html | 20
>
> modules/Leads/RenderRelatedListUI.php | 3
>
> modules/Leads/Save.php | 6
>
> modules/Notes/Delete.php | 6
>
> modules/Notes/DetailView.html | 2
>
> modules/Notes/EditView.html | 3
>
> modules/Notes/EditView.php | 2
>
> modules/Notes/Forms.php | 108
>
> modules/Notes/ListView.php | 11
>
> modules/Notes/Save.php | 6
>
> modules/Orders/CreatePDF.php | 10
>
> modules/Orders/CreateSOPDF.php | 4
>
> modules/Orders/Delete.php | 7
>
> modules/Orders/DeleteSalesOrder.php | 7
>
> modules/Orders/DetailView.html | 2
>
> modules/Orders/EditView.html | 1
>
> modules/Orders/EditView.php | 3
>
> modules/Orders/ListView.php | 21
>
> modules/Orders/Order.php | 63
>
> modules/Orders/Popup.php | 149
>
> modules/Orders/PopupSearchForm.html |only
>
> modules/Orders/SalesOrder.php | 56
>
> modules/Orders/SalesOrderDetailView.html | 2
>
> modules/Orders/SalesOrderEditView.html | 1
>
> modules/Orders/SalesOrderEditView.php | 3
>
> modules/Orders/SalesOrderListView.php | 19
>
> modules/Orders/Save.php | 25
>
> modules/Orders/SaveSalesOrder.php | 8
>
> modules/Potentials/Delete.php | 5
>
> modules/Potentials/DetailView.html | 2
>
> modules/Potentials/EditView.html | 1
>
> modules/Potentials/EditView.php | 4
>
> modules/Potentials/Forms.php | 142
>
> modules/Potentials/ListView.html | 10
>
> modules/Potentials/ListView.php | 27
>
> modules/Potentials/ListViewTop.php | 5
>
> modules/Potentials/Opportunity.php | 58
>
> modules/Potentials/RenderRelatedListUI.php | 8
>
> modules/Potentials/Save.php | 5
>
> modules/Products/Delete.php | 8
>
> modules/Products/DeleteVendor.php | 7
>
> modules/Products/DetailView.html | 2
>
> modules/Products/EditView.html | 1
>
> modules/Products/EditView.php | 1
>
> modules/Products/Forms.php | 136
>
> modules/Products/ListView.php | 16
>
> modules/Products/PriceBookDetailView.html | 2
>
> modules/Products/PriceBookListView.php | 9
>
> modules/Products/Product.php | 40
>
> modules/Products/ProductDetailView.html | 2
>
> modules/Products/RenderRelatedListUI.php | 17
>
> modules/Products/Save.php | 21
>
> modules/Products/SaveVendor.php | 8
>
> modules/Products/VendorDetailView.html | 2
>
> modules/Products/VendorEditView.html | 1
>
> modules/Products/VendorEditView.php | 1
>
> modules/Products/VendorListView.php | 19
>
> modules/Products/VendorSearchForm.html | 4
>
> modules/Products/index.php | 2
>
> modules/Products/language/en_us.lang.php | 3
>
> modules/Quotes/CreatePDF.php | 4
>
> modules/Quotes/Delete.php | 8
>
> modules/Quotes/DetailView.html | 2
>
> modules/Quotes/EditView.html | 1
>
> modules/Quotes/EditView.php | 3
>
> modules/Quotes/ListView.php | 20
>
> modules/Quotes/Quote.php | 401
>
> modules/Quotes/Save.php | 8
>
> modules/Reports/CreatePDF.php | 6
>
> modules/Reports/CreateXL.php | 3
>
> modules/Reports/PopulateReports.php | 4
>
> modules/Reports/ReportRun.php | 260
>
> modules/Reports/Reports.php | 47
>
> modules/Reports/SaveAndRun.php | 19
>
> modules/Reports/language/en_us.lang.php | 2
>
> modules/Settings/AddCustomFieldToDB.php | 8
>
> modules/Settings/EditFieldBlock.php |only
>
> modules/Settings/EditModuleOwners.html |only
>
> modules/Settings/EditModuleOwners.php |only
>
> modules/Settings/EmailConfig.php | 11
>
> modules/Settings/Forms.php | 131
>
> modules/Settings/ListMailAccount.php | 6
>
> modules/Settings/ListModuleOwners.html |only
>
> modules/Settings/ListModuleOwners.php |only
>
> modules/Settings/Save.php | 25
>
> modules/Settings/SaveModuleOwners.php |only
>
> modules/Settings/index.html | 81
>
> modules/Settings/language/en_us.lang.php | 23
>
> modules/Settings/vtigerCRM.CAB |binary
>
> modules/System/includes/XPath.class.php | 2
>
> modules/System/includes/class.Template.inc.php | 2
>
> modules/System/includes/common_functions.php | 2
>
> modules/System/includes/system_footer.php | 2
>
> modules/System/includes/system_header.php | 2
>
> modules/System/language/en_us.lang.php | 2
>
> modules/System/systemconfig.php | 2
>
> modules/Users/Authenticate.php | 1
>
> modules/Users/DeleteGroup.php |only
>
> modules/Users/DetailView.html | 2
>
> modules/Users/DetailView.php | 2
>
> modules/Users/EditHomeOrder.php |only
>
> modules/Users/EditTermsandConditions.html |only
>
> modules/Users/EditTermsandConditions.php |only
>
> modules/Users/EditView.html | 23
>
> modules/Users/EditView.php | 5
>
> modules/Users/GroupDetailView.html |only
>
> modules/Users/GroupDetailView.php |only
>
> modules/Users/OrganizationTermsandConditions.html |only
>
> modules/Users/OrganizationTermsandConditions.php |only
>
> modules/Users/RoleDetailView.php | 64
>
> modules/Users/Save.php | 4
>
> modules/Users/SaveGroup.php |only
>
> modules/Users/UpdateProfileChanges.php |only
>
> modules/Users/User.php | 13
>
> modules/Users/language/en_us.lang.php | 55
>
> modules/Users/profilePrivileges.html |only
>
> modules/Users/profilePrivileges.php |only
>
> modules/Users/savetermsandconditions.php |only
>
> modules/Users/upload.php | 8
>
> modules/squirrelmail-1.4.4/config/config.php | 4
>
> modules/squirrelmail-1.4.4/functions/date.php | 2
>
> modules/squirrelmail-1.4.4/functions/imap_general.php | 20
>
> modules/squirrelmail-1.4.4/functions/mailbox_display.php | 2
>
> modules/squirrelmail-1.4.4/functions/mime.php | 2
>
> modules/squirrelmail-1.4.4/move_messages.php | 24
>
> modules/squirrelmail-1.4.4/plugins/info/options.php | 2
>
> modules/squirrelmail-1.4.4/plugins/info/setup.php | 2
>
> modules/squirrelmail-1.4.4/plugins/mail_fetch/options.php | 2
>
> modules/squirrelmail-1.4.4/plugins/mail_fetch/setup.php | 2
>
> modules/squirrelmail-1.4.4/read_body.php | 6
>
> modules/squirrelmail-1.4.4/right_main.php | 6
>
> modules/uploads/downloadfile.php | 24
>
> phprint.php | 4
>
> test/upload/vtigercrm.txt | 2
>
> themes/Aqua/header.html | 2
>
> themes/Aqua/header.php | 205
>
> themes/Aqua/images/prvPrfBottomLeft.gif |only
>
> themes/Aqua/images/prvPrfBottomRight.gif |only
>
> themes/Aqua/images/prvPrfHdrArrow.gif |only
>
> themes/Aqua/images/prvPrfLine.gif |only
>
> themes/Aqua/images/prvPrfSelectedTab.gif |only
>
> themes/Aqua/images/prvPrfSelectedTick.gif |only
>
> themes/Aqua/images/prvPrfTexture1.gif |only
>
> themes/Aqua/images/prvPrfTopLeft.gif |only
>
> themes/Aqua/images/prvPrfTopRight.gif |only
>
> themes/Aqua/images/prvPrfUnSelectedTab.gif |only
>
> themes/Aqua/images/vtigerDevDocs.gif |only
>
> themes/Aqua/style.css | 54
>
> themes/blue/header.html | 4
>
> themes/blue/header.php | 201
>
> themes/blue/images/prvPrfBottomLeft.gif |only
>
> themes/blue/images/prvPrfBottomRight.gif |only
>
> themes/blue/images/prvPrfHdrArrow.gif |only
>
> themes/blue/images/prvPrfLine.gif |only
>
> themes/blue/images/prvPrfSelectedTab.gif |only
>
> themes/blue/images/prvPrfSelectedTick.gif |only
>
> themes/blue/images/prvPrfTexture1.gif |only
>
> themes/blue/images/prvPrfTopLeft.gif |only
>
> themes/blue/images/prvPrfTopRight.gif |only
>
> themes/blue/images/prvPrfUnSelectedTab.gif |only
>
> themes/blue/images/vtigerDevDocs.gif |only
>
> themes/blue/style.css | 53
>
> themes/images/vtiger-paw.jpg |only
>
> themes/images/vtiger.jpg |only
>
> themes/nature/header.html | 2
>
> themes/nature/header.php | 202
>
> themes/nature/images/prvPrfBottomLeft.gif |only
>
> themes/nature/images/prvPrfBottomRight.gif |only
>
> themes/nature/images/prvPrfHdrArrow.gif |only
>
> themes/nature/images/prvPrfLine.gif |only
>
> themes/nature/images/prvPrfSelectedTab.gif |only
>
> themes/nature/images/prvPrfSelectedTick.gif |only
>
> themes/nature/images/prvPrfTexture1.gif |only
>
> themes/nature/images/prvPrfTopLeft.gif |only
>
> themes/nature/images/prvPrfTopRight.gif |only
>
> themes/nature/images/prvPrfUnSelectedTab.gif |only
>
> themes/nature/images/vtigerDevDocs.gif |only
>
> themes/nature/style.css | 43
>
> themes/orange/header.html | 2
>
> themes/orange/header.php | 200
>
> themes/orange/images/prvPrfBottomLeft.gif |only
>
> themes/orange/images/prvPrfBottomRight.gif |only
>
> themes/orange/images/prvPrfHdrArrow.gif |only
>
> themes/orange/images/prvPrfLine.gif |only
>
> themes/orange/images/prvPrfSelectedTab.gif |only
>
> themes/orange/images/prvPrfSelectedTick.gif |only
>
> themes/orange/images/prvPrfTexture1.gif |only
>
> themes/orange/images/prvPrfTopLeft.gif |only
>
> themes/orange/images/prvPrfTopRight.gif |only
>
> themes/orange/images/prvPrfUnSelectedTab.gif |only
>
> themes/orange/images/vtigerDevDocs.gif |only
>
> themes/orange/style.css | 36
>
> vtiger_logger.php | 13
>
> vtigerolservice.php |only
>
> vtigerpatch.php |only
>
> 354 files changed, 27546 insertions(+), 15292 deletions(-)
>
>
> _______________________________________________
> vtigercrm-developers mailing list
> vtigercrm-developers at lists.vtigercrm.com
> http://lists.vtigercrm.com/mailman/listinfo/vtigercrm-developers
More information about the vtigercrm-developers
mailing list