[Vtigercrm-developers] [Vtigercrm-commits] [vtiger-commits]r9127 -/vtigercrm/tags/vtigercrm-4.2.4/modules/Leads/LeadConvertToEntities.php

[Mike Fedyk]

And how do we prevent this from happening in the future?  Reducing
permissions on the tags folder sounds like a good idea to me.  It looks like
someone needs to re-read the svn book.

Allan, a merge with this commit reversed should take care of this problem.

-----Original Message-----
From: vtigercrm-developers-bounces at lists.vtigercrm.com
[mailto:vtigercrm-developers-bounces at lists.vtigercrm.com] On Behalf Of Allan
Bush
Sent: Monday, August 28, 2006 7:59 AM
To: vtigercrm-developers at lists.vtigercrm.com
Subject: Re: [Vtigercrm-developers] [Vtigercrm-commits]
[vtiger-commits]r9127
-/vtigercrm/tags/vtigercrm-4.2.4/modules/Leads/LeadConvertToEntities.php

Any word on this?

Jeff what's the best way to revert these changes?  I guess since
there's no way to remove a change completely any method which reverts
this change (merge, checkout old revision, etc..) would work equally
well.

On 8/24/06, Allan Bush <allan.bush+vtiger_dev at gmail.com> wrote:
> Please please please, do not ever make changes to anything in the "tags"
folder.
>
> The proper procedure is to create a branch off of the tag and apply
> the fixes to that.  In fact if you looked you'd see that a branch has
> already been made from that tag (4.2.4.1, before the current naming
> conversion discussion) and this very fix was already applied.
>
> On 8/24/06, vtigercrm-commits at vtiger.fosslabs.com
> <vtigercrm-commits at vtiger.fosslabs.com> wrote:
> > Author: saraj
> > Date: Thu Aug 24 06:46:15 2006
> > New Revision: 9127
> >
> > Log:
> > removed extra quote
> >
> > Modified:
> >
vtigercrm/tags/vtigercrm-4.2.4/modules/Leads/LeadConvertToEntities.php
> >
> > Modified:
vtigercrm/tags/vtigercrm-4.2.4/modules/Leads/LeadConvertToEntities.php
> >
============================================================================
==
> > ---
vtigercrm/tags/vtigercrm-4.2.4/modules/Leads/LeadConvertToEntities.php
(original)
> > +++
vtigercrm/tags/vtigercrm-4.2.4/modules/Leads/LeadConvertToEntities.php Thu
Aug 24 06:46:15 2006
> > @@ -279,7 +279,7 @@
> >  $adb->query($sql_insert_contact);
> >
> >
> > -$sql_insert_contactsubdetails = "INSERT INTO contactsubdetails
(contactsubscriptionid,homephone,otherphone,leadsource) VALUES
(".$contact_id.",'','','".$adb->quote($row['leadsource'])."')";
> > +$sql_insert_contactsubdetails = "INSERT INTO contactsubdetails
(contactsubscriptionid,homephone,otherphone,leadsource) VALUES
(".$contact_id.",'','',".$adb->quote($row['leadsource']).")";
> >
> >  $adb->query($sql_insert_contactsubdetails);
> >
> >
> >
> > _______________________________________________
> > vtigercrm-commits mailing list
> > vtigercrm-commits at lists.vtigercrm.com
> > http://lists.vtigercrm.com/mailman/listinfo/vtigercrm-commits
> >
>
_______________________________________________
Get started with creating presentations online - http://zohoshow.com?vt