[Vtigercrm-commits] [vtiger development] #7348: adhoc reporting parameters for created and modified time fail

[vtiger development]

#7348: adhoc reporting parameters for created and modified time fail
------------------------+---------------------------------------------------
 Reporter:  joebordes   |       Owner:  developer
     Type:  defect      |      Status:  new      
 Priority:  unassigned  |   Milestone:  5.4.0    
Component:  vtigercrm   |     Version:  5.3.0    
 Severity:  Medium      |    Keywords:           
------------------------+---------------------------------------------------
 In the database these two fields are marked as typeofdata T
 When the fields are created in their compact/report format, this T is set
 as their type value.
 Then in the ReportRun.php::RunTimeAdvFilter() function the code on lines
 977-986:

 {{{
 if($column_info[4] == 'D') {
     $date = new DateTimeField(trim($temp_val[$x]));
     $val[$x] = $date->getDBInsertDateValue();
 } elseif($column_info[4] == 'DT') {
     $date = new DateTimeField(trim($temp_val[$x]));
     $val[$x] = $date->getDBInsertDateTimeValue();
 } else {
     $date = new DateTimeField(trim($temp_val[$x]));
     $val[$x] = $date->getDBInsertTimeValue();
 }
 }}}

 will apply the getDBInertTimeValue() instead of getDBInsertDateTimeValue()
 causing a condition like this:

 {{{
 (( vtiger_crmentity.createdtime > '15:40:34' ) )
 }}}

 instead of the desired

 {{{
 (( vtiger_crmentity.createdtime > '2012-02-05 15:40:34' ) )
 }}}

 I don't know if this affects other fields nor if the correct fix is to
 modify the database typeofdata or add code here to treat these two fields
 correctly (both solutions work).

-- 
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7348>
vtiger development <http://trac.vtiger.com/>
vtiger CRM