[Vtigercrm-commits] [vtiger development] #6167: Single quote error in get_where_clause during import

vtiger development vtiger-tickets at trac.vtiger.com
Wed Jul 15 14:26:41 EDT 2009


#6167: Single quote error in get_where_clause during import
------------------------+---------------------------------------------------
 Reporter:  R.Cohen     |       Owner:  developer
     Type:  defect      |      Status:  new      
 Priority:  unassigned  |   Milestone:  5.1.0    
Component:  vtigercrm   |     Version:  5.1.0-rc 
 Keywords:              |  
------------------------+---------------------------------------------------
 Single quote "'" in field value causes the where clause produced by
 modules/Import/ImportSave.php/get_where_clause
 to produce an invalid SQL.
 For example
 {{{
 ... = ifnull('O'Brien','') .....
 }}}


 Problem in line 468

 {{{
 $where_clause .= " AND ifnull(". $col_name .",'') =
 ifnull('".$field_value."','') ";

 }}}

 should be something like

 {{{
         $where_clause .= " AND ifnull(". $col_name .",'') =
 ifnull(\"".$field_value."\",'') ";

 }}}

-- 
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/6167>
vtiger development <http://trac.vtiger.com/>
vtigerCRM




More information about the vtigercrm-commits mailing list