<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Reverted fix <a href="https://code.vtiger.com/vtiger/vtigercrm/-/commit/0b104a642d1966a6d0995cdf53507fd9c3d5031c">in commit</a></div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Mon, Feb 24, 2025 at 10:23 PM Rubén A. Estrada Orozco <<a href="mailto:rulotec1@gmail.com">rulotec1@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Dear Prasad, if you can't implement the suggested approach, do you think we could at least revert that change?<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 18, 2025 at 10:34 AM Rubén A. Estrada Orozco <<a href="mailto:rulotec1@gmail.com" target="_blank">rulotec1@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Based on the comments in this thread, my suggestion would be:<br><div><br></div><div>1. Separate currency format from numeric format. This would imply having a field in the user's profile where you can specify the number of decimals for numeric non-currency fields.</div><div>2. The established format should only affect how numbers are displayed. When editing, all available decimals should be used. Otherwise, this would have the undesired effect of losing decimals whenever someone with a fewer decimals setting edits a record created/edited by someone with a higher decimals setting, EVEN if that field was left untouched. </div><div><br></div><div>For me, that is the most reasonable/expected behavior.</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 18, 2025 at 4:41 AM Prasad <<a href="mailto:prasad@vtiger.com" target="_blank">prasad@vtiger.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Is there a suggested fix for quick review (or) few more test-cases to assess?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Feb 16, 2025 at 1:25 AM Rubén A. Estrada Orozco <<a href="mailto:rulotec1@gmail.com" target="_blank">rulotec1@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Prasad, can you please look into this?<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 14, 2025 at 9:01 PM Alan Lord <<a href="mailto:alanslists@gmail.com" target="_blank">alanslists@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div>
<div>I'm sure there is a ticket on
<a href="http://code.vtiger.com" target="_blank">code.vtiger.com</a> for this or something very similar but I couldn't
find it. It's a shame that the commit didn't reference a ticket.<br>
</div>
<div><br>
</div>
<div>I agree though, currency fields should
be treated completely separately from normal decimal fields.</div>
<div><br>
</div>
<div>Al<br>
</div>
<div><br>
</div>
<div>On 14/02/2025 05:44, Rubén A. Estrada
Orozco wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Hi everyone,<br clear="all">
</div>
<div><br>
</div>
<div>I see this change was introduced about 9 months ago: <a href="https://code.vtiger.com/vtiger/vtigercrm/-/merge_requests/1185/diffs" target="_blank">https://code.vtiger.com/vtiger/vtigercrm/-/merge_requests/1185/diffs</a></div>
<div><br>
</div>
<div><img src="cid:ii_1950b1d84a7cb971f161" alt="image.png" width="542" height="172"><br>
</div>
<div><br>
</div>
<div>This change has important/serious implications for the
behavior of Vtiger. </div>
<div><br>
</div>
<div>It formats all decimal fields according to the "Number of
Currency Decimals" parameter in the user's preferences. Such
preferences can vary from user to user.</div>
<div><br>
</div>
<div><img src="cid:ii_1950b1d84a7cb971f162" alt="image.png" width="542" height="390"><br>
</div>
<div><br>
</div>
<div>If you create a field such as this one:</div>
<div><br>
</div>
<div><img src="cid:ii_1950b1d84a7cb971f163" alt="image.png" width="542" height="512"><br>
</div>
<div><br>
</div>
<div>You expect it to have 4 decimals. You also expect that the
<u>currency</u> number format would not impact such other
fields. But guess what? it does!!!</div>
<div><br>
</div>
<div>There is a big problem with this. If a user with 4 decimals
format sets a field value of a record to say 0.1234, and then
a user with 2 decimals format edits the same record without
touching said field, then its value will change to 0.12. Not
the expected behavior, right?</div>
<div><br>
</div>
<div>Moreover, if you come from a Vtiger version prior to 8.2
and upgrade, then this will potentially mess up your data
little by little, removing decimals from such fields. Because,
the default number of decimals for currency fields is 2, so
most probably, you'll be losing decimals.</div>
<div><br>
</div>
<div>This was not carefully thought through. Vtiger team, please
consider reverting that change.</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">Saludos
<div><br>
</div>
<div>Rubén</div>
</div>
</div>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
<a href="http://www.vtiger.com/" target="_blank">http://www.vtiger.com/</a></pre>
</blockquote>
<p><br>
</p>
</div>
_______________________________________________<br>
<a href="http://www.vtiger.com/" rel="noreferrer" target="_blank">http://www.vtiger.com/</a></blockquote></div>
_______________________________________________<br>
<a href="http://www.vtiger.com/" rel="noreferrer" target="_blank">http://www.vtiger.com/</a></blockquote></div>
_______________________________________________<br>
<a href="http://www.vtiger.com/" rel="noreferrer" target="_blank">http://www.vtiger.com/</a></blockquote></div>
</blockquote></div>
_______________________________________________<br>
<a href="http://www.vtiger.com/" rel="noreferrer" target="_blank">http://www.vtiger.com/</a></blockquote></div>