<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>If i change here</p>
<p>if (selectedFieldsEles.length > 15) {
app.helper.showErrorNotification({message:app.vtranslate('JS_ADD_MAX_15_ITEMS')});<br>
return false;
<br>
}
</p>
<p>this does not effect in selection of columns at create or edit
filter. <br>
</p>
<p>We can define globally this value in config.inc.php like page per
record <br>
</p>
<div style="color: #d4d4d4;background-color: #1e1e1e;font-family: 'Droid Sans Mono', 'monospace', monospace, 'Droid Sans Fallback';font-weight: normal;font-size: 14px;line-height: 19px;white-space: pre;"><div><span style="color: #9cdcfe;">$list_max_entries_per_page</span><span style="color: #d4d4d4;"> = </span><span style="color: #ce9178;">'20'</span><span style="color: #d4d4d4;">;</span></div></div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix"> 5/16/20 10:29 PM, Alan Lord wrote:<br>
</div>
<blockquote type="cite" cite="mid:r9otbo$217f$1@ciao.gmane.io">This
bit of code in Vtiger_List_Js (from line 2352) could be better
IMHO.
<br>
<br>
if (selectedFieldsEles.length > 15) {
app.helper.showErrorNotification({message:app.vtranslate('JS_ADD_MAX_15_ITEMS')});<br>
return false;
<br>
}
<br>
<br>
I see 2 issues:
<br>
<br>
1. The limit is hardcoded here AND it is hardcooded in the
CustomView_JS class as below (there should be only ONE place this
is set.
<br>
<br>
2. The translation label above basically means you can't change
the value if you wanted to anyway as the value is also hardcoded
into the translatable message label.
<br>
<br>
<br>
Al
<br>
<br>
<br>
<br>
On 16/05/2020 15:12, Alan Lord wrote:
<br>
<blockquote type="cite">And here then:
<br>
<br>
<a class="moz-txt-link-freetext" href="https://code.vtiger.com/vtiger/vtigercrm/blob/master/layouts/v7/modules/Vtiger/resources/List.js#L2352">https://code.vtiger.com/vtiger/vtigercrm/blob/master/layouts/v7/modules/Vtiger/resources/List.js#L2352</a>
<br>
<br>
This parameter should only be in one place at least (if not
configurable) and not in multiple locations...
<br>
<br>
Al
<br>
<br>
<br>
On 16/05/2020 14:13, Jitu wrote:
<br>
<blockquote type="cite">check this file
layouts/v7/modules/CustomView/resources/CustomView.js
<br>
<br>
/**
<br>
* Function which will register the select2 elements for
columns selection
<br>
*/
<br>
registerSelect2ElementForColumnsSelection:function() {
<br>
varselectElement= this.getColumnSelectElement();
<br>
vtUtils.showSelect2ElementView(selectElement,{maximumSelectionSize:15});
<br>
},
<br>
On 5/16/20 5:01 PM, Alan Lord wrote:
<br>
</blockquote>
</blockquote>
<br>
<br>
_______________________________________________
<br>
<a class="moz-txt-link-freetext" href="http://www.vtiger.com/">http://www.vtiger.com/</a>
<br>
<br>
<br>
</blockquote>
</body>
</html>