<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body><br>Tim, absolutely right!<div>The possible explanation was just a quick fix to alow installation success. </div><div>I hope that workaround in not definitive because as you said feels dodgy and doesnt solve other areas.<div dir="auto"><br></div><div dir="auto"><br dir="auto">Best regards.<br dir="auto"></div></div><br><br>-------- Mensagem original --------<br>De : Tim Mohrbach <noreply@code.vtiger.com> <br>Data: 10/05/2016 09:19 (GMT+00:00) <br>Para: ptdesigner@gmail.com <br>Assunto: Re: vtigercrm | PHP 7 compatibility (#197) <br><br>
<div class="content">
<div>
<p><a href="http://code.vtiger.com/u/prasad" class="gfm gfm-project_member">@prasad</a>: Good stuff, thanks for trying hard and succeeding with PHP7!
Regarding your fix in <a href="http://code.vtiger.com/vtiger/vtigercrm/commit/db3ef7f986ab667ce9f7919a080eedfaad5dcb47" title="Commit: prasad - PHP 7 - split function defined." class="gfm gfm-commit">db3ef7f9</a>, yes this will make split work. But I don't like it at all... it's dodgy and just working around the problem instead of tackling it properly. Instead of bloating up vtiger with code that will make deprecated code work, why not change the original cause of the problem and get rid of all split in vtiger code? </p>
<p>I hope you can comment why you chose this approach to fix things in this particular case... Looking forward to it.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p>
—
<br>
<a href="http://code.vtiger.com/vtiger/vtigercrm/issues/197#note_1256">View it on GitLab</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"http://code.vtiger.com/vtiger/vtigercrm/issues/197#note_1256"}}</script>
You're receiving this notification because you are a member of the vtiger / vtigercrm project team.
</p>
</div>
</body></html>