<div dir="ltr"><div>Hi Istvan,<br><br></div>Sorry for the misperception, I took in general perspective. Thanks for your example which clearly explained the real objective. This we might solve through the module object. Will keep a note of this here in <a href="http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/8118">trac</a>. will fix it soon.<br>
<div class="gmail_extra"><br><br></div><div class="gmail_extra">With<br></div><div class="gmail_extra">Best Regards<br></div><div class="gmail_extra">Uma S<br></div><div class="gmail_extra">Vtiger Team<br><br><br></div><div class="gmail_extra">
<div class="gmail_quote">On Tue, Jul 1, 2014 at 9:04 PM, Holbok István <span dir="ltr"><<a href="mailto:holbok@gmail.com" target="_blank">holbok@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>Hi Uma,<br>
<br>
Thank you for the answer.<br>
May my English should be improved and I could not describe the
issue well. :-)<div><br>
<br>
<font color="#000099"><b>(1) if you will create a Custom module </b><br>
In this case, if your custom module has relevant translations
and in tpl while calling vtranslate() api for translation, If
the second parameter is CustomModuleName and whose parent is
Settings. Then translations will be picked from
/languages/en_us/Settings/Custommodule.php, If this doesn't
contain expected key value pair, then fallback for
/languages/en_us/Settings/Vtiger.php.</font><br>
<br></div>
Yes, it is true and I understand the above described statement and
this feature works as you described here above.<br>
<br>
<b>The other direction does not work.</b><br>
You are in the place <b><vtiger>/index.php?module=Vtiger&parent=Settings&view=Index</b>
and this is the setting page main view using factory language
files and factory template files.<br>
Your custom module inserted a LINK to the setting page with
command "INSERT INTO vtiger_settings_field(fieldid, blockid, name,
iconpath, description, linkto, sequence, active)"<br>
and you give name as 'LBL_CUSTOMMODULE' and give description as
'LBL_CUSTOMMODULE_DESC', and both of this language keys are
defined in your custom language files.<br>
<br>
And vtiger tranlsation engine, because your are not in the custom
module view (you are in the Vtiger module, parent Settings) will
not pick the translated key from the right file. The missing key -
label only - will show.<br>
<br>
An example: /modules/PBXManager/PBXManager.php at the line 236 in
function addSettingsLinks() uses the to same method to add
settings link.<br>
'LBL_PBXMANAGER' is translated because this label is in the
/languages/en_us/Settings/Vtiger.php file. in line 124. <br>
<br>
But how the 'LBL_CUSTOMMODULE' key will be in the
/languages/en_us/Settings/Vtiger.php file? Only by manual insert
after installing. <br>
And this is the reason why I wrote.<br>
<br>
Kindest regards:<br>
Istvan<div><br>
<br>
<br>
<div>üdvözlettel:<br>
<br>
<b>Holbok István</b><br>
<br>
+3670-342-0900<br>
<b>e-mail:</b> <a href="mailto:holbok@gmail.com" target="_blank">holbok@gmail.com</a><br>
<b>SkyPe:</b> holboki<br>
<br>
</div></div>
2014.07.01. 14:40 keltezéssel, Uma S írta:<br>
</div><div><div>
<blockquote type="cite">
<div dir="ltr">Hi Istvan,
<div><br>
</div>
<div><b style="font-family:arial,sans-serif;font-size:13px">(1)
if you will create a Custom module </b><br>
</div>
<div><b style="font-family:arial,sans-serif;font-size:13px"><br>
</b></div>
<div><font face="arial, sans-serif">In this case, if your custom
module has relevant translations and in tpl while calling
vtranslate() api for translation, If the second parameter is
CustomModuleName and whose parent is Settings. Then
translations will be picked from </font><span style="font-size:13px;font-family:arial,sans-serif">/languages/en_us/Settings/</span><span style="font-size:13px;font-family:arial,sans-serif">Custommodule.php,
If this doesn't contain expected key value pair, then
fallback for </span><span style="font-size:13px;font-family:arial,sans-serif">/languages/en_us/Settings/</span><span style="font-size:13px;font-family:arial,sans-serif">Vtiger.php.</span></div>
<div><span style="font-size:13px;font-family:arial,sans-serif"><br>
</span></div>
<div><b style="font-family:arial,sans-serif;font-size:13px">(2)
Translation engine issues </b><b><font face="arial,
sans-serif">with pick-list texts.</font></b><span style="font-size:13px;font-family:arial,sans-serif"><br>
</span></div>
<div><b style="font-family:arial,sans-serif;font-size:13px"><br>
</b></div>
<div><font face="arial, sans-serif">For any custom pick-list we
create, What ever the value given by the user will be saved
into database, While rendering these pick-list. For example
in picklist.tpl file where we render pick-list,
which requests for getPicklistValues() in
modules/Vtiger/models/Field.php file. Here the key is
non-translated value as stored in database, but value is
translated value. So on form submit key values will sent
which remains same in all languages.</font></div>
<div><font face="arial, sans-serif"><br>
</font></div>
<div><font face="arial, sans-serif"><br>
</font></div>
<div><font face="arial, sans-serif">With</font></div>
<div><font face="arial, sans-serif">Best Regards</font></div>
<div>
<font face="arial, sans-serif">Uma S</font></div>
<div><font face="arial, sans-serif">Vtiger Team</font></div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Tue, Jul 1, 2014 at 4:11 PM, Holbok
István <span dir="ltr"><<a href="mailto:holbok@gmail.com" target="_blank">holbok@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Dear Vtiger Team,<br>
<br>
There are a small, minor issues in the translation system
of vtiger 6.<br>
<br>
<b>(1) if you will create a Custom module</b> with
necessary en_us language files still will be missing
language keys from the <br>
/languages/en_us/Vtiger.php<br>
/languages/en_us/Settings/Vtiger.php<br>
For example the Custom module has settings page, and
defined the Links e.g. under Integration menu on the left
panel, there will be a LABEL e.g. LABEL_CUSTOM_MODULE but
not a translated string.<br>
<br>
The reason is: vtiger translation engine is looking for
the string in the /languages/en_us/Settings/Vtiger.php
file if you are in the <br>
place
<vtiger>/index.php?module=Vtiger&parent=Settings&view=Index<br>
And the translation engine will not find the translated
keys in the file
/languages/en_us/Settings/Custommodule.php<br>
<br>
This issue also valid for the main menu system that uses
keys from the /languages/en_us/Vtiger.php file.<br>
<br>
<b>Bad solution today is:</b> adding manually - after
install - the missing language keys => value pairs to
the /languages/en_us/Vtiger.php &
/languages/en_us/Settings/Vtiger.php .<br>
But this solution is against the vtiger store policy
changing core files. (You can see in the
/languages/hu_hu/Vtiger.php &
/languages/hu_hu/Settings/Vtiger.php these added dozens of
plus keys.)<br>
<br>
<b>Suggested solutions:</b> create a vtlib function and a
/languages/en_us/Common.php &
/languages/hu_hu/Settings/Common.php files to handle this
issue.<br>
The vtlib function simple will open the Common.php
language files (for the named language) and will append
the provided missing key => value pairs to the end of
the file (if the provided keys are not exist already).<br>
<br>
<b>(2) Translation engine issues </b><b>with picklist
texts.</b><br>
Unfortunately the picklist (and multi-select picklist)
fields data will store in the database in text form and
these texts are subject of translation.<br>
The translations are necessary, but there is better
storage form then text.<br>
<br>
For example the vtiger system uses 2 languages (Hungarian
and English). <br>
Note: the multi-language usage in Central Europe is very
widespread. For example my consultant association works in
10 CE countries, and our vtiger users from these countries
and they use this vtiger instance in English, German,
Hungarian, Romanian, etc. languages.<br>
<br>
So, there is a 2 language vtiger system and there is a
picklist with words 'big', 'medium', 'small' and in the
language file there are translation in order 'nagy',
'közepes', 'kicsi'.<br>
<br>
If the English user will pick the 1st item, the field will
store 'big' as a content. In multi-select will be stored
e.g. 'big |##| medium'. The Hungarian user will pick the
1st item the field will store 'nagy' as a content. In
multi-select will be stored e.g. 'nagy |##| közepes'.<br>
<br>
And this case will cause <b>IMPOSSIBILITY </b>to search
in the database.<br>
<br>
My suggestion is to store in the database the picklist ID
but not the picklist label. The picklis ID will be too
same using different languages.<br>
For example here is the activitytype picklist.<br>
<p><b>SQL
lekérdezés:</b><span> </span>SELECT * FROM
`vtiger_activitytype` LIMIT 0, 25 ;<br>
<b>Sorok:</b><span> </span>3</p>
<div>
<table style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);border-collapse:collapse;border-spacing:0px;background-color:rgb(255,255,255)">
<thead><tr>
<th style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;font-weight:bold;background-color:rgb(229,229,229)">activitytypeid</th>
<th style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;font-weight:bold;background-color:rgb(229,229,229)">activitytype</th>
<th style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;font-weight:bold;background-color:rgb(229,229,229)">presence</th>
<th style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;font-weight:bold;background-color:rgb(229,229,229)">picklist_valueid</th>
<th style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;font-weight:bold;background-color:rgb(229,229,229)">sortorderid</th>
</tr>
</thead><tbody>
<tr>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">1</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;background-color:rgb(255,255,255)">Call</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">0</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">12</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">0</td>
</tr>
<tr>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">2</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;background-color:rgb(255,255,255)">Meeting</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">0</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">13</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">1</td>
</tr>
<tr>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">3</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;background-color:rgb(255,255,255)">Mobile
Call</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">0</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">321</td>
<td style="color:rgb(0,0,0);border:0.1em solid rgb(0,0,0);padding:0.2em;white-space:nowrap;background-color:rgb(255,255,255)">1</td>
</tr>
</tbody>
</table>
</div>
<br>
If we will store in the database the activitytypeid as
picklist ID, it will be too same for every language.<br>
For the multi-select we can store '1 |##| 2' instead of
the confused translated or not translated labels from the
second column.<br>
<br>
Of course these solutions will change the UIType handling
engines and the search engine also.<br>
So, the database will contain the indexes (from the 1st
column), the translating engine will show the labels from
the second column or labels from the language files.<br>
<br>
Kindest regards:<br>
Istvan<span><font color="#888888"><br>
<br>
<div>-- <br>
üdvözlettel:<br>
<br>
<b>Holbok István</b><br>
<br>
+3670-342-0900<br>
<b>e-mail:</b> <a href="mailto:holbok@gmail.com" target="_blank">holbok@gmail.com</a><br>
<b>SkyPe:</b> holboki<br>
<br>
</div>
</font></span></div>
<br>
_______________________________________________<br>
<a href="http://www.vtiger.com/" target="_blank">http://www.vtiger.com/</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr">With<br>
Best Regards<br>
Uma.S<br>
<div>Vtiger Team</div>
</div>
</div>
</blockquote>
<br>
<br>
</div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">With<br>Best Regards<br>Uma.S<br><div>Vtiger Team</div></div>
</div></div>