<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Wed, Feb 20, 2013 at 4:04 AM, Prasad <span dir="ltr"><<a href="mailto:prasad@vtiger.com" target="_blank">prasad@vtiger.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div>Vtiger6 provides fallback implementation to standard actions and views for Entity modules, and let the module override this if required. The Entity module (following vtlib guidelines on Vtiger 5) should continue to work without much changes on Vtiger6. </div>
</div></blockquote><div><br></div><div>Reading through the wiki documentation you posted yesterday, I see what you describe, but I haven't seen anything of the sort working on my test vt6 server. I'll try to take a closer look later this week and report back.</div>
<div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div></div><div>Can you please share details on the vt5 patches you are referring too.</div>
</div>
</blockquote><div><br></div><div>Start with my two dozen or so unaccepted patches in Trac, then add several hundred more that I haven't bothered to (or am unable to) submit.</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div></div><div><div style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif">Vtiger 6 is completely rewritten from ground up following the MVC design. So, we are puzzled as to what you mean by "largest bowl of copy paste". We would love to understand it</div>
</div></div></blockquote><div><br></div><div style>Sorry, I wasn't clear -- vt5 = copy pasta, not vt6. The point I was trying to make wasn't bashing the vt6 codebase; I was attempting to point out that you're making this MVC refactoring more difficult than it needs to be.</div>
<div style><br></div><div style>In 5.4, I saw you guys start to do the kind of refactoring that I like to see: you went through all the modules and replaced ListView.php copy pasta with require_once('modules/Vtiger/ListView.php'); It's not glamorous, it doesn't feel like you're accomplishing as much as "rip and replace", but guess what? That change didn't cause any disruption. Everyone got a leaner, more maintainable codebase and barely noticed! You could have done the same thing with a MVC refactoring; built only the "fallback to vt5" piece, and shipped it! There would be no vt5/vt6 toggle, vt6 would always be in fallback mode! Instead you have put yourself in a position where nobody trusts the virgin, untested vt6 code.</div>
<div style><br></div><div style>One of my college professors taught me a great lesson years ago, that no complex system (that works) is built from scratch. You can only build it from a simpler system (that works).</div></div>
</div></div>