Adam,<div><br></div><div>Thank you for quick review - we follow up on this thread.</div><div><br></div><div>Regards,</div><div>Prasad</div><div><br><div class="gmail_quote">On Wed, Oct 10, 2012 at 8:22 PM, Adam Heinz <span dir="ltr"><<a href="mailto:amh@metricwise.net" target="_blank">amh@metricwise.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Since I just smashed the new phpmailer over top, I'm reviewing the<br>
changes made to it over the years [1]. Even going back in the source<br>
code as far as 4.0, I couldn't find a pristine phpmailer 1.7.2 source<br>
file. Even the phpmailer site only has source as far back as 2.0, so<br>
there was no good way to apply the phpmailer 1.7.2 - 5.1.0 delta.<br>
<br>
I think the best course of action is to use a pristine phpmailer so<br>
that subsequent changes are easier to include, and to reimplement the<br>
following changes outside of the phpmailer files.<br>
<br>
Review required:<br>
@12734 - default timeout set, reapply<br>
@11832 - default language set, reapply<br>
@11362 - charset set, reapply<br>
@11210 - html entity decoding, not sure<br>
@9762 - html entity decoding, not sure<br>
<br>
Reviewed, but no follow up necessary:<br>
@13487 - similar change made, no action<br>
@11389 - code no longer exists, no action<br>
@10378 - charset set, no action<br>
@10370 - charset set, no action<br>
@7150 - file size, no action<br>
@7003 - bad search/replace, no action<br>
@3329 - version upgrade, no action<br>
@83 - error messaging, no action<br>
<br>
I also just noticed that there is a second copy of the files in cron?<br>
This is somewhat concerning, as the majority of the fixes were only<br>
applied to the modules/Emails files.<br>
<br>
[1] <a href="http://trac.vtiger.com/cgi-bin/trac.cgi/log/vtigercrm/branches/5.4.0/modules/Emails/class.phpmailer.php?action=stop_on_copy&rev=13577&stop_rev=&mode=follow_copy" target="_blank">http://trac.vtiger.com/cgi-bin/trac.cgi/log/vtigercrm/branches/5.4.0/modules/Emails/class.phpmailer.php?action=stop_on_copy&rev=13577&stop_rev=&mode=follow_copy</a><br>
_______________________________________________<br>
<a href="http://www.vtiger.com/" target="_blank">http://www.vtiger.com/</a><br>
</blockquote></div><br></div>