Alan,<div><br></div><div>Do accept the apology for pushing in getReturnPath API we failed to cover exhaustive</div><div>case while having the SMTP as localdomain, we indeed targeted only sub-domain level.</div><div><br></div>
<div>This was an attempt to fix the <a href="http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7325">mail ending up with SPAM folder</a> due to invalid SPF.</div><div><br></div><div>Please review the suggested fix and share your feedback:</div>
<div><div><a href="http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7325#comment:3">http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7325#comment:3</a></div><div><br></div><div>Regards.</div><div>Prasad</div><div><br><div class="gmail_quote">
On Sat, Jun 16, 2012 at 1:19 AM, Joe Bordes <span dir="ltr"><<a href="mailto:joe@tsolucio.com" target="_blank">joe@tsolucio.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I couldn't agree more. In fact we have changed getReturnPath() function<br>
directly to return a correct email for each client.<br>
<br>
I wanted to add one comment to your debugging procedure on the cron. You<br>
can execute the script directly, no need to wait for the cron, this way<br>
not only do you have control of when to launch it but you can get errors<br>
or debug messages on the command line interface screen.<br>
<br>
Joe<br>
TSolucio<br>
<br>
<br>
El 15/06/12 17:03, Alan Lord escribió:<br>
<div><div class="h5">> I've spent most of the day looking at a problem with a customer not<br>
> getting Scheduled Reports from vtiger 5.4.0.<br>
><br>
> The new function introduced in 5.4.0 getReturnPath() (bottom of<br>
> CommonUtils) is a *REALLY* bad idea. (I thought I'd already fixed it<br>
> once in modules/Emails/mail.php - see<br>
> <a href="https://forums.vtiger.com/viewtopic.php?f=139&t=53251" target="_blank">https://forums.vtiger.com/viewtopic.php?f=139&t=53251</a>)<br>
><br>
> Our customers frequently use their ISP to relay their emails. Setting<br>
> the Return Path of the outbound emails from vtiger to<br>
> "<a href="mailto:noreply@my-isp.com">noreply@my-isp.com</a>" triggers some spam prevention and stops emails<br>
> getting sent by the relay.<br>
><br>
> This getReturnPath() function is being called in three separate email<br>
> sending code paths (cron/send_mail.php, modules/Emails/mail.php,<br>
> vtlib/Vtiger/Mailer.php) and is a pig to fix properly. Please make this<br>
> a priority for 6.0.0. I do not want to have to hack code all over vtiger<br>
> just so we can send emails!<br>
><br>
> Today has been very frustrating. It is very hard to debug external,<br>
> authenticated SMTP connections on remote servers. Please can you try not<br>
> to break this functionality so badly next time...<br>
><br>
> With specific regards to the Scheduled Reports functionality I have two<br>
> further observations:<br>
><br>
> 1. On sending, there is no "from address" added to the email if the<br>
> Outgoing Server's from address not configured. (This will also cause<br>
> some SMTP servers to not send the email). The offending code is in<br>
> modules/Reports/ScheduledReoports.php. In vtiger_reports, every report<br>
> has an "owner" id and in my opinion the "from email" should be taken<br>
> from there initially and if it is empty, use the SMTP from field, if<br>
> that fails, make something up that is useful like "vtiger@hostname.domain".<br>
><br>
> 2. Scheduled reports are a PITA to test: If you edit a scheduled report<br>
> and change the time on a daily report. It doesn't update the<br>
> next_trigger_time row so the report will not run again until whatever<br>
> the last settings were... This means the easiest way to test is to have<br>
> a SQL query lined up like:<br>
><br>
> UPDATE `vtiger_scheduled_reports` SET `next_trigger_time` = '2012-06-15<br>
> 15:43:00' WHERE `vtiger_scheduled_reports`.`reportid` = 24;<br>
><br>
> And then set the scheduler and cron job to run every minute! It would be<br>
> really helpful to add a tool of some kind to make it easier to test a<br>
> scheduled anything (report, workflow etc...).<br>
><br>
><br>
><br>
> Al<br>
><br>
><br>
> _______________________________________________<br>
> <a href="http://www.vtiger.com/" target="_blank">http://www.vtiger.com/</a><br>
<br>
</div></div>_______________________________________________<br>
<a href="http://www.vtiger.com/" target="_blank">http://www.vtiger.com/</a><br>
</blockquote></div><br></div></div>