Adam,<div><br></div><div>Good to see your refactoring work progress. I'm curious about your approach of testing the changes made?</div><div><br></div><div>Are you using any phpunit test cases?</div><div><br></div><div>
Regards,</div><div>Prasad</div><div><br></div><div><span style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px"><b>Connect with us on: </b><a href="http://twitter.com/#!/vtigercrm" style="color:rgb(0,0,204)" target="_blank">Twitter</a> <b>I</b> <a href="http://www.facebook.com/pages/vtiger/226866697333578?sk=wall" style="color:rgb(0,0,204)" target="_blank">Facebook</a> <b>I</b> <a href="http://blog.vtiger.com/" style="color:rgb(0,0,204)" target="_blank">Blog</a><b> I</b> <a href="http://wiki.vtiger.com/index.php/Main_Page" style="color:rgb(0,0,204)" target="_blank">Wiki</a> <b>I </b><a href="http://forums.vtiger.com/" style="color:rgb(0,0,204)" target="_blank">Forums </a><b>I</b> <a href="http://vtiger.com/" style="color:rgb(0,0,204)" target="_blank">Website</a></span><br>
<br><br><div class="gmail_quote">On Sat, Mar 17, 2012 at 1:25 AM, Adam Heinz <span dir="ltr"><<a href="mailto:amh@metricwise.net">amh@metricwise.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Second patch added!<br>
<a href="http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7379" target="_blank">http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7379</a><br>
<br>
I went ahead and split out the role privileges into a new Roles class,<br>
which surprisingly was the majority of the privileges. This suggests<br>
that the user_privilege files have contained a lot of redundant data,<br>
that the new hierarchical implementation has done away with. I also<br>
dipped my toe into the water refactoring functions in UserInfoUtils to<br>
use Roles. It definitely shows promise, but I didn't want to get too<br>
sidetracked from my goal.<br>
<br>
Next up, sharing privileges!<br>
_______________________________________________<br>
<a href="http://www.vtiger.com/" target="_blank">http://www.vtiger.com/</a><br>
</blockquote></div><br></div>