Hi,<div><br></div><div>Smarty is theoretically extensible, I'm thinking about using Smarty.register_function(...), not hacking into the Smarty base, of course. :)</div><div><br></div><div>Maybe something more general like</div>
<div><br></div><div>{vtiger_translate $APP.ADD_NEW $APP.Contact}</div><div><br></div><div>and</div><div><br></div><div>'Contact' => 'Contact',<br></div><div><div>'ADD_NEW' => 'Add %s',</div>
<div><br></div><div><div>'Contact' => 'Kontakt',<br></div><div>'ADD_NEW' => '%s Hinzufügen',<br></div><div><br></div><div></div></div><div class="gmail_quote">What would you think?</div>
<div class="gmail_quote"><br></div><div class="gmail_quote">(In the process, introducing new context based (not reused) keys is also a must-have, just as you say.)</div><div class="gmail_quote"><br></div><div class="gmail_quote">
Kristóf</div><div class="gmail_quote"><br></div><div class="gmail_quote">On Mon, Nov 24, 2008 at 4:25 PM, Prasad <span dir="ltr"><<a href="mailto:prasad@vtiger.com">prasad@vtiger.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Kristof,<br><br>I would suggest not adding too much hack to any Smarty functions it will pose difficulty to upgrade the library later.<br><br>Coming up with context based language keys is a way to go (as I can think of now).<br>
We need to clean up TPL files in the beginning and add required language translation key this will make sure other<br>language translators put in proper values based on the context. <br><br>Regards,<br><font color="#888888">Prasad<br>
vtiger Team</font><div><div></div><div class="Wj3C7c"><br>
<br><div><span class="gmail_quote">On 11/24/08, <b class="gmail_sendername">Kristóf KOVÁCS</b> <<a href="mailto:kristof.kovacs@onlineprojects.hu" target="_blank">kristof.kovacs@onlineprojects.hu</a>> wrote:</span><blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">
Hello Prasad,<div><br></div><div>thanks for your answer! Of course, I don't wish to force a language cleanup on your team. :) I'm merely thinking about developing the foundation, the infrastructure for such a change, and then, I hope, individual translators of different languages would do the modifications in both the TPL and the language files. I would certainly do our own part, Hungarian translation requires different word order at several places.</div>
<div><br></div><div>But I want to discuss the concepts with you guys, since for such a change, it requires consensus (I also would like to hear opinions from veteran translators of the project). Also it would be very bad if our development tree would diverge from yours, both in terms of maintenance (for us), and in opportunity lost (for everybody).</div>
<div><br></div><div>Prasad, we all know and trust you as one of the best core developers, so just one question: what do You say, just from the top of your head, would there be any better solution for the problem, or should we go think forward with the "added-Smarty-printf-function" solution? (Would you accept into the codebase the patches we would be starting to send in of modified TPL files and language files?)</div>
<div><br></div><span><div>Kristóf</div></span><div><span><div><br><div class="gmail_quote">On Mon, Nov 24, 2008 at 3:52 PM, Prasad <span dir="ltr"><<a href="mailto:prasad@vtiger.com" target="_blank">prasad@vtiger.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">
Hi Kristof,<br><br>This issues has been brought up earlier as well. To make the translation clean up all-over the product it could<br>take more effort both in terms of development and validation. Currently we are focusing on getting in new features<br>
as we go along we can better plan for language cleanup's as well. This give us more focused work items.<br><br>We would appreciate community help in identifying such language or translation issues.<br><br>Regards,<br>
Prasad<br><br><div><div><div></div><div><span class="gmail_quote">On 11/24/08, <b class="gmail_sendername">Kristóf KOVÁCS</b> <<a href="mailto:kristof.kovacs@onlineprojects.hu" target="_blank">kristof.kovacs@onlineprojects.hu</a>> wrote:</span></div>
</div><blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex"><div><div></div><div>
Hello Tigers,<div><br></div><div>I was talking with Dávid of CafeOpen about vTiger translations, and there is one issue which my team often faces with, and this is word order. Let me illustrate it with an example (using German instead of Hungarian to make it more clear, but the concept is the same).</div>
<div><br></div><div>For example, in ActivityEditView.tpl there is the following code:</div><div><br></div><div><div><input title="{$APP.LBL_ADD_NEW} {$APP.Contact}" .....</div><div><br></div><div>And this shows a button called "Add Contact". It seems all well since "$APP.LBL_ADD_NEW" is "Add" and "$APP.Contact" is "Contact". </div>
<div><br></div><div>But "Add Contact" in German is "Kontakt hinzufügen" (notice that the words are in a different order). Now we have a problem since "{$APP.LBL_ADD_NEW} {$APP.Contact}" can not be forced to display this, and saying "hinzufügen Kontakt" does not sound quite right (it sounds very bad indeed).</div>
<div><br></div><div>Translation quirks can circumvent some of such problems (one could write "Neue Contact"), but often these strings are reused at other parts of the code, and fixing it in one place often destroys grammar at other places.</div>
<div><br></div><div>One idea would be to use printf()-like format strings to correct such issues, even if it may require an introduction of a now Smarty function. I'm thinking along the lines of something like this:</div>
<div><br></div><div><div>{a_smarty_printf_function $APP.ADD_NEW_SOMETHING_FORMATSTRING, $APP.LBL_ADD_NEW, $APP.Contact}</div><div><br></div><div>Then, in english, the .lang file would read:</div><div>[...]</div><div>'LBL_ADD_NEW' = 'Add',</div>
<div>'Contact' => 'Contact',</div><div>'ADD_NEW_SOMETHING_FORMATSTRING' => "'%s %s", // Very simple format string, no surprise here</div><div>[...]</div><div><br></div><div>And in german, it would be:</div>
<div><div>[...]</div>
<div>'LBL_ADD_NEW' = 'Hinzufügen',</div><div>'Contact' => 'Kontakt',</div><div>'ADD_NEW_SOMETHING_FORMATSTRING' => "'%2$s %1$s", // Notice how I used "1$" and "2$" to access arguments in different order</div>
<div>[...]</div><div><br></div><div>I don't feel it elegant enough (but more elegant than the original), so comments, suggestions, ideas, better solutions are very much welcome. Please all brainstorm this ever the next coffee. :o) </div>
<div><br></div><span><div>Kristóf</div>
</span></div></div></div>
<br></div></div>_______________________________________________<br>
Reach hundreds of potential candidates - <a href="http://jobs.vtiger.com" target="_blank">http://jobs.vtiger.com</a> <br></blockquote></div><br>
<br>_______________________________________________<br>
Reach hundreds of potential candidates - <a href="http://jobs.vtiger.com" target="_blank">http://jobs.vtiger.com</a> <br></blockquote></div><br></div>
</span></div><br>_______________________________________________<br>
Reach hundreds of potential candidates - <a href="http://jobs.vtiger.com" target="_blank">http://jobs.vtiger.com</a> <br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
Reach hundreds of potential candidates - <a href="http://jobs.vtiger.com" target="_blank">http://jobs.vtiger.com</a> <br></blockquote></div><br></div>