Enrico,<br><br>> Please try to move the RDBMS specific things into some separate<br>>source file, maybe some separate class. This gives an central<br>>point for RDBMS specific things and makes further porting much
<br>>easier. (I did similar things on my branch, which are not yet<br>>ported back.)<br><br>I understand what you are asking for (I think). But I don't see how what you want differs from the what is in the 5.0.3
code already. ADOdb does what you are speaking of (I think).<br><br> Joey<br><br><div><span class="gmail_quote">On 9/21/07, <b class="gmail_sendername">Enrico Weigelt</b> <<a href="mailto:weigelt@metux.de">weigelt@metux.de
</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">* Joey Novak <<a href="mailto:joey.novak@gmail.com">joey.novak@gmail.com
</a>> schrieb:<br><br>hi,<br><br>> So, I am 99% finished porting the non-MSSQL compliant SQL into<br>> Compatible SQL.<br><br>Please try to move the RDBMS specific things into some separate<br>source file, maybe some separate class. This gives an central
<br>point for RDBMS specific things and makes further porting much<br>easier. (I did similar things on my branch, which are not yet<br>ported back.)<br><br>For example:<br><br>Some base class "VT_DB_Driver" where several individual drivers
<br>(ie. for mysql, mssql, pgsql) are derived from.<br><br>It should have those functions:<br><br>* QueryRecords($query_string) -> give back an array of recods<br>* SequenceNextVal($seq_name)<br>* SQL_Encode_int($i)<br>
* SQL_Encode_date($d)<br>* SQL_Encode_text($t)<br>...<br><br><br>Ah, and please document your changes in the code and give tell us<br>something about what you did on the list :)<br><br>> Again, I don't know what the best way to go about this is, but my Company
<br>> is willing to invest resources into merging the braches of vTiger into one<br>> branch that works on postGres, MSSQL, and MySQL.<br><br>Is your company willing to hire some of us? ;-O<br><br>> how would I submit my work?
<br><br>Post an patch to the list ;-P<br><br>> told me I should create a new branch, as I browsed the code, I could not<br>> find the seperate postgres branch he spoke of. Is it not clearly labeled?<br><br>It's in the jens_5_1 branch. But last time I checked, it wasn't
<br>the whole of Jens's work, and he sent me his personal copy.<br>Mine has also several changes, some maybe already committed,<br>some maybe not.<br><br>BTW: we already have dozens of branches, we really should get<br>
them together. Why not forking from the latest stable, and<br>intensively try to get in all the changes laying around into it ?<br>An clean DB abstraction seems to be an key point for me.<br><br><br>cu<br>--<br>----------------------------------------------------------------------
<br> Enrico Weigelt, metux IT service -- <a href="http://www.metux.de/">http://www.metux.de/</a><br><br> cellphone: +49 174 7066481 email: <a href="mailto:info@metux.de">info@metux.de</a> skype: nekrad666<br>----------------------------------------------------------------------
<br> Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme<br>----------------------------------------------------------------------<br>_______________________________________________<br>Reach hundreds of potential candidates -
<a href="http://jobs.vtiger.com">http://jobs.vtiger.com</a><br></blockquote></div><br><br clear="all"><br>-- <br>---<br> <a href="http://www.joeynovak.com">http://www.joeynovak.com</a><br><br><br> C) 803-409-9969 (Work Cell)
<br> W) 757-233-0834<br> H) 757-383-8523 (SkypeIn)<br>"Very funny, Scotty. Now beam down my clothes."<br><br>Be nice to nerds. Chances are you'll end up working for one. <br> --Bill Gates<br><br>Your most unhappy customers are your greatest source of learning.
<br> --Bill Gates<br><br>Cope with Life, go buy a slurpee!<br><a href="http://www.slurpee.com/games.html">http://www.slurpee.com/games.html</a>