<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head><meta content="text/html;charset=UTF-8" http-equiv="Content-Type"></head><body >Hi Jens,<br><br>This issue is fixed as in your patch and the files are checked into the SVN.<br><br>Thanks,<br>Don<br><br><br><br><br>---- On Wed, 13 Sep 2006 Jens Hamisch <jens@Strawberry.COM> wrote ---- <br><br><br>Don,<br><br><br>however please have a look at my fixes to<br>DefaultDataPopulator.php and 5createTables.inc.php.<br><br>The current implementation violates the database<br>layout constraints. The installation of vtiger will<br>definitely fail unless the database engine ignores<br>those violations (it should not, otherwise the<br>constraint does not make any sense).<br><br>Also there's a typo in one of the source files<br>(User.php: '-' at the beginning of the line).<br><br>At least one community member already is facing<br>installation probles with one of the latest SVN<br>revisions ...<br><br>Regardless the remaining postgres fixes I'd tag<br>those 'critical' with the potential of blocking<br>GA.<br><br><br><br>Jens<br><br><br><br>On Wed, Sep 13, 2006 at 03:45:10AM -0700, don wrote:<br>> Hi Jens,<br>> <br>> Thanks for your patches. However we have freezed the development activities for the vtigerCRM 5 release.<br>> We are expecting the v5 release to be happening in another 24 hours.<br>> <br>> <br>> We will definitely integrate these patches post 5.0 GA<br>> <br>> Thanks for your understanding,<br>> Don<br>> <br>> <br>> <br>> <br>> <br>> ---- On Mon, 11 Sep 2006 Jens Hamisch <jens@Strawberry.COM> wrote ---- <br>> <br>> Sorry, typo!<br>> <br>> -- Jens<br>> <br>> --------------------------------------------------------------------------------<br>> /<br>> +##+|##+ STRAWBERRY Jens Hamisch<br>> +v#+v v##+ EDV-Systeme GmbH Managing director<br>> / v v\v<br>> | . . . | Waldeckstr. 9a Car (Voice): (+49 172) 81 04 162<br>> | . | D-82515 Wolfratshausen Voice: (+49 8171) 41805-0<br>> | . | Fax: (+49 8171) 41805-59<br>> \ . / Tel.: (+49 8171) 41805-0 Email: jens@Strawberry.COM<br>> \____/ Strawberry@Strawberry.COM <br>> <br>> <br>> <br>> ========================= Forwarded Mail =========================<br>> <br>> Subject: Re: [Vtigercrm-developers] vtiger 5: Installation Manual for<br>> PostgreSQL DB<br>> From: Jens Hamisch <jens@Strawberry.COM><br>> Date: Mon, 11 Sep 2006 22:55:25 +0200<br>> To: gopals@vtiger.com, don@vctiger.com<br>> CC: vtigercrm-developers@lists.vtigercrm.com<br>> <br>> ------------------------- Contents -------------------------<br>> <br>> Hi Gopal,<br>> hi Don,<br>> <br>> <br>> > It will be of more helpful if you could point the exact postgreSQL URL and php.ini settings as well in the installation document. Please let me know if you need any assistance.<br>> <br>> <br>> I hadn't had the time to look at this. I'll come back to you.<br>> <br>> Regarding the current integration of the postgres fixes into the SVN<br>> I had a closer look at SVN revision 9402. My fixes were almost present,<br>> however I figured out the following:<br>> <br>> <br>> <br>> include/database/PearDatabase.php<br>> install/5createTables.inc.php<br>> - The fix regarding the SEQUENCE mapping is missing<br>> <br>> include/database/Postgres8.php<br>> - I've reworked my fix in a way that removes the column names<br>> from this source file. The rework has not been implemented.<br>> <br>> install/4createConfigFile.php<br>> - The check against $_REQUEST['db_type'] must be done before<br>> handling the database type. Otherwise $dbType will be undefined.<br>> <br>> modules/Potentials/Opportunity.php<br>> modules/SalesOrder/SalesOrder.php<br>> modules/Leads/Lead.php<br>> modules/Invoice/Invoice.php<br>> modules/PurchaseOrder/PurchaseOrder.php<br>> modules/Quotes/Quote.php<br>> - PostgreSQL does not support the && operator. AND must be used<br>> instead.<br>> <br>> modules/Campaigns/ListView.php<br>> - The OFFSET/LIMIT fix was applied. However the old code was not<br>> deleted.<br>> <br>> modules/Products/ListView.php<br>> modules/Activities/ListView.php<br>> modules/Quotes/ListView.php<br>> modules/HelpDesk/Save.php<br>> - You forgot these files entirely<br>> <br>> modules/Calendar/Appointment.php<br>> - New problem figured out today. The fixPostgresQuery function<br>> needs to be added.<br>> <br>> modules/Calendar/calendarLayout.php<br>> - One fixPostgresQuery was missing<br>> <br>> modules/Home/index.php<br>> - New problem figured out today. Another 'AS' was missing.<br>> <br>> modules/Users/User.php<br>> - A misleading comment was removed<br>> <br>> install/5createTables.inc.php<br>> modules/Users/DefaultDataPopulator.php<br>> - New problem figured out today. The user2group entries introduced<br>> in DefaultDataPopulator.php were tried to be inserted into the<br>> database before the user records were created. This violates<br>> the layout constraint:<br>> Key (userid)=(2) is not present in table "vtiger_users"<br>> <br>> I've split off this code into two parts, one in 5createTables.inc.php<br>> and the other one in DefaultDataPopulator.php.<br>> <br>> modules/Faq/ListView.php<br>> - Duplicate comment<br>> <br>> themes/blue/style.css<br>> <br>> <br>> <br>> There's a patch containing all changes mentioned above attached to this mail.<br>> I'll also document this in TRAC#2033.<br>> <br>> <br>> Kind regards<br>> -- Jens<br>> <br>> --------------------------------------------------------------------------------<br>> /<br>> +##+|##+ STRAWBERRY Jens Hamisch<br>> +v#+v v##+ EDV-Systeme GmbH Managing director<br>> / v v\v<br>> | . . . | Waldeckstr. 9a Car (Voice): (+49 172) 81 04 162<br>> | . | D-82515 Wolfratshausen Voice: (+49 8171) 41805-0<br>> | . | Fax: (+49 8171) 41805-59<br>> \ . / Tel.: (+49 8171) 41805-0 Email: jens@Strawberry.COM<br>> \____/ Strawberry@Strawberry.COM <br>> <br>> _______________________________________________<br>> Get started with creating presentations online - http://zohoshow.com?vt <br>> <br>> <br>> ====================== End of Forwarded Mail ======================<br>> <br><br>-- <br><br>--------------------------------------------------------------------------------<br> /<br> +##+|##+ STRAWBERRY Jens Hamisch<br>+v#+v v##+ EDV-Systeme GmbH Managing director<br>/ v v\v<br>| . . . | Waldeckstr. 9a Car (Voice): (+49 172) 81 04 162<br>| . | D-82515 Wolfratshausen Voice: (+49 8171) 41805-0<br> | . | Fax: (+49 8171) 41805-59<br> \ . / Tel.: (+49 8171) 41805-0 Email: jens@Strawberry.COM<br> \____/ Strawberry@Strawberry.COM <br></body></html>