[Vtigercrm-developers] *** SPAM *** Re: Vtiger CRM - 7.5.0 Release Planning

[Alan Lord]

On 24/09/2022 03:33, Prasad wrote:
> Please suggest a static analysis tool that works well.

PHPStan seems to be the easiest to use IMHO. It doesn't find everything 
but it certainly helps...

I just ran it on the vtiger codebase with the config file at the end of 
this mail.

Unfortunately, if I include the vtiger Loader, e.g.

>     bootstrapFiles:
>         - includes/Loader.php

the analysis crashes rather quickly :-(

>  -- -------------------------------------------------------------------------------------------------- 
>      Error                                                                                             
>  -- -------------------------------------------------------------------------------------------------- 
>      Reached internal errors count limit of 50, exiting...                                             
>      Internal error: Internal error: Call to undefined function checkFileAccessForInclusion() in file  
>      /home/test/Development/vtiger/include/Webservices/VtigerModuleOperation.php                       
>      Run PHPStan with -v option and post the stack trace to:                                           
>      https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md 


phpstan.neon:

> parameters:
>     level: 9
>     paths:
>         - cron
>         - data
>         - include
>         - includes
>         - modules
>         - pkg/vtiger
>         - vtlib
>     fileExtensions:
>         - inc
>     scanDirectories:
>         - kcfinder
>         - libraries

HTH

Al