[Vtigercrm-developers] Error to delete lists Vtiger 7.3 (06/2021)

[Henry Cumbicus Rivera]

It doesn't show an error, it visually removes the list, but when it
refreshes the page it shows again, when I open the browser's network it
shows the Permission Denied error.
After the modification (&&) it already removes correctly.


El mar, 8 jun 2021 a las 20:25, Rubén A. Estrada Orozco (<rulotec1 at gmail.com>)
escribió:

> I mean, before the modification you made, did you get an error when trying
> to delete a report as a non-admin user?
>
> Saludos
>
> Rubén
>
>
> On Tue, Jun 8, 2021 at 12:49 PM Henry Cumbicus Rivera <
> hcumbicusr at gmail.com> wrote:
>
>> Yes Rubén, it works correctly.
>> Now each user can delete their own lists.
>>
>>
>>
>> El mar, 8 jun 2021 a las 11:53, Rubén A. Estrada Orozco (<
>> rulotec1 at gmail.com>) escribió:
>>
>>> Did you test it Henry? Is it the case that currently, users owning lists
>>> can't delete them (unless they are admins)? To me, that would be the
>>> implication, but I haven't tested it.
>>> Saludos
>>>
>>> Rubén
>>>
>>>
>>> On Tue, Jun 8, 2021 at 11:40 AM Henry Cumbicus Rivera <
>>> hcumbicusr at gmail.com> wrote:
>>>
>>>> I agree with you Rubén, with that condition only admin users can delete
>>>> lists (but only their lists).
>>>> It should have *&&*
>>>>
>>>> El mar, 8 jun 2021 a las 11:19, Sukhdev Mohan (<s.mohan at myti.it>)
>>>> escribió:
>>>>
>>>>> I support Rubén. Didn't feels right.
>>>>>
>>>>> Il mar 8 giu 2021, 18:14 Rubén A. Estrada Orozco <rulotec1 at gmail.com>
>>>>> ha scritto:
>>>>>
>>>>>> To me, this condition (line 28) still seems wrong:
>>>>>>
>>>>>> [image: image.png]
>>>>>> file in 7.4:
>>>>>> https://code.vtiger.com/vtiger/vtigercrm/blob/7.4.0/modules/CustomView/actions/Delete.php
>>>>>>
>>>>>> Or am I missing something?
>>>>>>
>>>>>> Saludos
>>>>>>
>>>>>> Rubén
>>>>>>
>>>>>>
>>>>>> On Tue, Jun 8, 2021 at 2:48 AM Sukhdev Mohan <s.mohan at myti.it> wrote:
>>>>>>
>>>>>>> This is nice!
>>>>>>>
>>>>>>> I remembered I asked here for the same issue some time ago and there
>>>>>>> were analysis going on.
>>>>>>>
>>>>>>> It’d be great to delete the tags too or at least the admin could
>>>>>>> delete them.
>>>>>>>
>>>>>>> Best Regards,
>>>>>>> *Sukhdev Mohan* | *Software Developer*
>>>>>>> https://www.myti.it
>>>>>>> On 8 Jun 2021, 09:43 +0200, Alan Lord <alanslists at gmail.com>, wrote:
>>>>>>>
>>>>>>> This was fixed for 7.4.0 with the merge request:
>>>>>>>
>>>>>>> https://code.vtiger.com/vtiger/vtigercrm/merge_requests/727
>>>>>>>
>>>>>>> It was discussed at length here:
>>>>>>>
>>>>>>> https://code.vtiger.com/vtiger/vtigercrm/issues/706
>>>>>>>
>>>>>>> HTH
>>>>>>>
>>>>>>> Al
>>>>>>>
>>>>>>>
>>>>>>> On 08/06/2021 00:43, Henry Cumbicus Rivera wrote:
>>>>>>>
>>>>>>> Hello,
>>>>>>> When I try to delete a list from a non-ADMIN user I get a permission
>>>>>>> denied error, I see this is due to the condition of the file
>>>>>>> \modules\CustomView\actions\Delete.php:28
>>>>>>>
>>>>>>> *Error*:
>>>>>>> image.png
>>>>>>>
>>>>>>> *Corrected*:
>>>>>>> image.png
>>>>>>>
>>>>>>> I honestly do not understand why the condition validates if it is
>>>>>>> admin
>>>>>>> or NO to delete a list.
>>>>>>> It would be very useful if users with ADMIN privilege could delete
>>>>>>> any
>>>>>>> list from the system.
>>>>>>>
>>>>>>> image.png
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> ---------------------------------------------------------------
>>>>>>> Henry C.
>>>>>>> Tel.: 956727976
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> http://www.vtiger.com/
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> http://www.vtiger.com/
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> http://www.vtiger.com/
>>>>>>
>>>>>> _______________________________________________
>>>>>> http://www.vtiger.com/
>>>>>
>>>>> _______________________________________________
>>>>> http://www.vtiger.com/
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> ---------------------------------------------------------------
>>>> Henry C.
>>>> Tel.: 956727976
>>>> _______________________________________________
>>>> http://www.vtiger.com/
>>>
>>> _______________________________________________
>>> http://www.vtiger.com/
>>
>>
>>
>> --
>>
>> ---------------------------------------------------------------
>> Henry C.
>> Tel.: 956727976
>> _______________________________________________
>> http://www.vtiger.com/
>
> _______________________________________________
> http://www.vtiger.com/



-- 

---------------------------------------------------------------
Henry C.
Tel.: 956727976
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210608/6d91142b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 41857 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210608/6d91142b/attachment-0001.png>