[Vtigercrm-developers] 711 to 720 update

[Uma S]

Hi All,

We made this change to remove the call
for Install_Utils_Model::installModules() from individual scripts as part
of code cleanup. Making sure that not disturbing the existing migration
flows

 That is if the Migration flow depends on package install or update that
has been retained as is. Only the scripts which look to update the modules
at last have been cleaned up to address in common place. That's in the last
step of migration applyDBChanges() api.

On reviewing the reported issue
<https://code.vtiger.com/vtiger/vtigercrm/issues/846> by Alan, It's good
that we need to have a brainstorming session in cleaning up the process to
make the migration bug free and smooth.

I have copied the reference to this thread on the issue to capture more
details, Please do update the issue about failed test-cases.

Will be picking this for next release 7.5.0

On Wed, Jul 7, 2021 at 3:29 AM Steve Kenow <skenow at rdspos.com> wrote:

> That call has been removed in the 7.3.0 version, but only the full
> package. The 720_to_730 patch still has the call.
>
> *Steve Kenow*
> Retail Data Systems of Minnesota
> End-User Services & Support Manager
> Direct: (952) 392-2686
> Office: (952) 934-4002
> skenow at rdspos.com
>
>
>
>
>
>
> On Thu, Jul 1, 2021 at 1:13 PM Angelo Paglialonga <
> info at angelopaglialonga.com> wrote:
>
>> In my experience it could be much better to avoid any possible problem by
>> just migrating the database after disabling custom modules and using new
>> unzipped vtiger 7.3 files, and then just copy back custom modules files and
>> enable them again in module manager. What do you think?
>>
>> _______________
>>
>> Angelo Paglialonga
>> Consulente per soluzioni CRM ad alto ROI.
>>
>> Telefono: 3386077866
>> Skype: angelo.paglialonga
>> Web: https://www.angelopaglialonga.com
>>
>>
>> Il giorno 1 lug 2021, alle ore 16:59, Alan Lord <alanslists at gmail.com>
>> ha scritto:
>>
>> Yep. There are a whole heap of issues with the way the migration
>> process works...
>>
>> I just came across this one I added 3 years ago.
>>
>> https://code.vtiger.com/vtiger/vtigercrm/issues/846
>>
>> No comments from anyone else though :-(
>>
>> I'll keep to my heavily customised [i.e. bastardised] cli-based migration
>> scripts for now then.
>>
>> Al
>>
>>
>> On 01/07/2021 15:45, Martin Allen wrote:
>>
>> So by calling the Install_Utils_Model::installModules(); function it is
>> basically re-installing certain modules (any modules that have a schema in
>> the zip files in /packages directories) and part of that process is that
>> for related lists, as you guessed Alan, it deletes ALL related Lists before
>> then rebuilding all the related lists from the schema in the zip files -
>> which are set on installation of vTiger?
>>
>> -----Original Message-----
>>
>> From: vtigercrm-developers-bounces at lists.vtigercrm.com <
>> vtigercrm-developers-bounces at lists.vtigercrm.com> On Behalf Of Alan Lord
>>
>> Sent: 01 July 2021 15:34
>>
>> To: vtigercrm-developers at lists.vtigercrm.com
>>
>> Subject: Re: [Vtigercrm-developers] 711 to 720 update
>>
>> Anything to do with this one?
>>
>> https://code.vtiger.com/vtiger/vtigercrm/issues/1003
>>
>> If not it is probably because part of the module install routine maybe
>> called remove related lists before recreating them?
>>
>> Check the various module install and enable/disable events passed to the
>> vtlib_handler in the module's class file.
>>
>> Al
>>
>> On 01/07/2021 15:28, Martin Allen wrote:
>>
>> Okay - so digging into this further whenever the 711 to 720 update is
>>
>> run (so if your updating vTiger from any version before 711 to 720 or
>>
>> higher) then the following modules will have ALL related lists deleted,
>>
>> and ONLY the default related lists are restored....
>>
>>
>> ServiceContracts
>>
>> ProjectTasks
>>
>>
>> Services
>>
>>
>> Assets
>>
>>
>> Project
>>
>>
>> SMSNotifier
>>
>>
>> Again - WHY??
>>
>>
>> *From:*vtigercrm-developers-bounces at lists.vtigercrm.com
>>
>> <vtigercrm-developers-bounces at lists.vtigercrm.com> *On Behalf Of *Martin
>>
>> Allen
>>
>> *Sent:* 01 July 2021 15:10
>>
>> *To:* vtigercrm-developers at lists.vtigercrm.com
>>
>> *Subject:* [Vtigercrm-developers] 711 to 720 update
>>
>>
>> Does anyone know why I the 711_to_720.php migration schema there is a
>>
>> call to Install_Utils_Model::installModules();
>>
>>
>> We've just updated some CRMs and afterwards we have multiple Related
>>
>> Lists in Project Tasks module that are deleted, and also related lists
>>
>> that are now duplicated, and so far we have narrowed it down to being
>>
>> caused by this function...?
>>
>>
>> *Martin Allen*
>>
>>
>> **
>>
>>
>> **
>>
>>
>> 01392 690659 (Direct)
>>
>> 01392 248692 (Main Office)
>>
>>
>> The information in this email is confidential If you are not the
>>
>> intended recipient, you must not read or use that information. This
>>
>> email and any attachments are believed to be virus free however no
>>
>> responsibility is accepted by Exe Squared Ltd for any loss or damage
>>
>> arising in any way from receipt or use thereof. Exe Squared Ltd Company
>>
>> Reg Number 12185709, is based at Silverdown Park, Fair Oak Close, Exeter
>>
>> Airport Business Park EX5 2UX.
>>
>>
>>
>> _______________________________________________
>>
>> http://www.vtiger.com/
>>
>>
>> _______________________________________________
>>
>> http://www.vtiger.com/
>>
>> _______________________________________________
>>
>> http://www.vtiger.com/
>>
>> _______________________________________________
>> http://www.vtiger.com/
>>
>> _______________________________________________
>> http://www.vtiger.com/
>
> _______________________________________________
> http://www.vtiger.com/



-- 
With
Best Regards
Uma.S
Vtiger Team
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210707/376e0e22/attachment.html>