[Vtigercrm-developers] Static analysis for vtiger 7.4

[Prasad]

MR Contributions are welcome.

On Mon, Aug 2, 2021 at 12:25 PM Mariusz Krzaczkowski | YetiForce Sp. z o.o.
<m.krzaczkowski at yetiforce.com> wrote:

> @Sukhdev Mohan
>
> See here (you can see what needs to be improved)
>
>
> https://insight.symfony.com/projects/df801b71-93c7-42cc-b67c-eba1e9e02e37/analyses/1?status=stats
>
>
>
> https://insight.symfony.com/projects/df801b71-93c7-42cc-b67c-eba1e9e02e37/analyses/1
>
> --
> Z poważaniem / Kind regards
> Mariusz Krzaczkowski
> Director of Product Development
> +48 884 998 123 | m.krzaczkowski at yetiforce.com
> www.yetiforce.com
>
> [image: YetiForce] [image: linkedin]
> <https://linkedin.com/company/yetiforce> [image: facebook]
> <https://facebook.com/YetiForceCRM/> [image: twitter]
> <https://twitter.com/yetiforceen> [image: youtube]
> <https://www.youtube.com/channel/UCnt7DLyYtcSBkC2sk2CJBXw> [image: github]
> <https://github.com/YetiForceCompany/YetiForceCRM>
> [image: Nagrody / Awards: HIGH PERFORMER IN CRM CATEGORY, MOST AFFORDABLE
> CRM SYSTEM IN THE WORLD IN 2017, SUPPLIER OF THE YEAR 2017 IN THE IT
> CATEGORY, GUARANTEE OF USER SATISFACTION, RISING STAR AMONG CRM SYSTEMS,
> PLATINIUM MEDAL FROM THE SENSIOLABINSIGHTS]
> The content of this message is confidential and must not be disclosed. If
> the recipient of this message is not the intended recipient, employee, or
> intermediary authorized to forward it to the intended recipient, please
> note that all distribution, copying, or any other use of this message is
> forbidden. If you received this message by mistake, please inform the
> sender immediately by responding to this message, and delete all copies of
> this message.
>
>
> W dniu 2021-08-02 08:43, Prasad napisał(a):
>
> Great to hear that.
>
> On Mon, Aug 2, 2021 at 11:28 AM Sukhdev Mohan <s.mohan at myti.it> wrote:
>
> I've just done a preliminary analysis. Work has yet to be started, given
> that there is a lot to work on, there will be MRs coming your way. It
> should be a team effort thoughm
>
> Il lun 2 ago 2021, 07:42 Prasad <prasad at vtiger.com> ha scritto:
>
> Submit MR to increase the compatibility.
>
> On Mon, Aug 2, 2021 at 2:59 AM Sukhdev Mohan <s.mohan at myti.it> wrote:
>
> Hi all,
>
> I've done a static analysis for the new release. The idea is to highlight
> are of interventions, defining a starting point to decrease the technical
> debt this project has piled up.
>
> I've tried to run the project (clean install) with php7.4 and mysql 8 +
> docker, install started unfortunately I had 504 during the installation but
> I'm working on it, when it's finished I'll be sharing my GitHub repo with a
> working docker file with LEMP. I've tried PHP8 too just out of curiosity.
> As expected it doesn't even launch the wizard: a lot of fatal errors. For
> the moment I can tell these 2:
> 1. PearDatabase: use of curly braces instead of []
> 2. AntlrLexer: them Ian class seems to be extending a base class but it's
> following the definition in the base class for matchAny and Re. I couldn't
> find the php version for this project, so if you guys wrote it, look at it.
>
> Now coming back to static Analysis, I've done it with PHPInsights for the
> modules folder (launch this command from cam root folder - after install
> through composer - : php -d memory_limit=4000M ./vendor/bin/phpinsights
> analyse modules ), you can find it zipped as a json file, the tool did
> truncated some but since it's easy to launch please do relaunch it. -
> although it will take a bit... the generated file is about 85MB...
>
> Some thoughts:
> As expected there is no proper implementation of  OOP (No visibility
> keywords, no namespaces), there is extensive use of global variables and
> super global variables such as $_REQUEST - which is needless to say
> harmful. Other than this there are too many nested loops (in some part
> nested loop level is 7 whereas recommended is 2 or 3, this has huge
> implications on performance!), many declared and unused variables.
>
> It's safe to say that if PHP7.4 is still letting some of the old practices
> go on, PHP8 will break the code badly, since most of the code is legacy. I
> was hoping that at least there would be composer but that's for the next
> release, hopefully.
>
> What are your thoughts? How can we start to approach?
>
> *Sukhdev Mohan*
> *Developer*
> _______________________________________________
> http://www.vtiger.com/
>
> _______________________________________________
> http://www.vtiger.com/
>
> _______________________________________________
> http://www.vtiger.com/
>
>
> _______________________________________________
> http://www.vtiger.com/
>
> _______________________________________________
> http://www.vtiger.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210802/327ae033/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0a6d45ea.png
Type: image/png
Size: 1326 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210802/327ae033/attachment-0008.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 5c55cc01.png
Type: image/png
Size: 94 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210802/327ae033/attachment-0009.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 24e87b3b.png
Type: image/png
Size: 489 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210802/327ae033/attachment-0010.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 86c867ec.png
Type: image/png
Size: 621 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210802/327ae033/attachment-0011.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: c1f05931.png
Type: image/png
Size: 745 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210802/327ae033/attachment-0012.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 9fe5767b.png
Type: image/png
Size: 598 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210802/327ae033/attachment-0013.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3fa545cd.png
Type: image/png
Size: 815 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210802/327ae033/attachment-0014.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3260ac43.png
Type: image/png
Size: 18115 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20210802/327ae033/attachment-0015.png>