[Vtigercrm-developers] Mass edit on Vtiger 7.3 custom module error

Tue Sep 22 01:27:38 GMT 2020

I've spotted the bug.
Please go to vtigercrm/layouts/v7/modules/Vtiger/resources/List.js and
replace line 1382

From:
[image: image.png]

To:
[image: image.png]

Uma, I think this is an important issue to fix. I made the MR for branch
7.4 but I was wondering if there would be a "hotfix" branch for 7.4.

Saludos

Rubén

On Sun, Sep 20, 2020 at 11:24 PM Uma S <uma.s at vtiger.com> wrote:

> Thanks! Ruben.
>
> On Mon, Sep 21, 2020 at 7:46 AM Rubén A. Estrada Orozco <
> rulotec1 at gmail.com> wrote:
>
>> That's true Tony, the same happens with check boxes.
>> I'll look into it.
>>
>>
>> On Sun, Sep 20, 2020 at 8:31 PM Tony Sandman <tonysandman999 at gmail.com>
>> wrote:
>>
>>> Here if you mass edit and safe without changes and without ticking it
>>> clearing all UI10 fields.
>>> Can you guys test it pls?
>>>
>>> On Sun, Sep 20, 2020 at 4:35 PM Uma S <uma.s at vtiger.com> wrote:
>>>
>>>> Hi Patrick,
>>>>
>>>> As Ruben said please do check this by clearing browser cache and also
>>>> against default Vtiger module. If the functionality works fine then let's
>>>> debug  for a custom module. Make sure that the above mentioned changes are
>>>> present in your source.
>>>>
>>>> On Sat, Sep 19, 2020 at 11:33 PM Rubén A. Estrada Orozco <
>>>> rulotec1 at gmail.com> wrote:
>>>>
>>>>> Patrick,
>>>>>
>>>>> If you do a similar edit on vtiger's native modules, does the same
>>>>> happen? (i.e relation fields get deleted)
>>>>>
>>>>> I have 3 hypothesis:
>>>>>
>>>>> 1. You have an old JS cached file (try deleting your borwser's cache).
>>>>> 2. Your custom modules have a custom List.js file that override
>>>>> behavior of layout/v7/modules/Vtiger/resources/List.js
>>>>> 3. There is a bug in the mass edit functionality in vt7.3.
>>>>>
>>>>> This is the relevant commit for mass edit in 7.3:
>>>>> https://code.vtiger.com/vtiger/vtigercrm/commit/47694b79fb01d68717f21288b59b9c740db31533
>>>>>
>>>>>
>>>>> Saludos
>>>>>
>>>>> Rubén
>>>>>
>>>>>
>>>>> On Sat, Sep 19, 2020 at 12:47 PM Patrick Allen Zulueta <
>>>>> alexander.allenz at gmail.com> wrote:
>>>>>
>>>>>> Hello Uma. I don’t want to update this field, for that reason it is
>>>>>> not enable the checkbox, but even without selected this field is updated.
>>>>>> This is the error, that I don’t want to update this field.
>>>>>>
>>>>>> El sábado, 19 de septiembre de 2020, Uma S <uma.s at vtiger.com>
>>>>>> escribió:
>>>>>>
>>>>>>> Hi Patrick,
>>>>>>>
>>>>>>> Yes! as Ruben suggested, only checked fields are considered for Mass
>>>>>>> Save operation.
>>>>>>>
>>>>>>> Looking at the given screen i have a question that, related-to field
>>>>>>> value is newly selected but corresponding check-box is not enabled in such
>>>>>>> case value saved will be blank. To save related-to field value please
>>>>>>> enable the check-box.
>>>>>>>
>>>>>>> On Sat, Sep 19, 2020 at 9:02 AM Patrick Allen Zulueta <
>>>>>>> alexander.allenz at gmail.com> wrote:
>>>>>>>
>>>>>>>> Hello Ruben. Thanks for the response.  I tried in computer.  The
>>>>>>>> field "Gestion" is not checked but after save it gets blanck. I just upload
>>>>>>>> "Ingreso manual". I also stop all workflows related with this module in
>>>>>>>> case, but is the same behavior.
>>>>>>>>
>>>>>>>> I already fix it not including this field in mass edit but maybe is
>>>>>>>> an error in vtiger.  See picture below.
>>>>>>>>
>>>>>>>> El vie., 18 sept. 2020 a las 12:31, Rubén A. Estrada Orozco (<
>>>>>>>> rulotec1 at gmail.com>) escribió:
>>>>>>>>
>>>>>>>>> In 7.3 mass edit, only fields that are checked should be mass
>>>>>>>>> edited. If the checkbox is checked and the field is empty, it will get
>>>>>>>>> erased:
>>>>>>>>>
>>>>>>>>> [image: image.png]
>>>>>>>>>
>>>>>>>>> Please provide more information/screenshots if the behavior is not
>>>>>>>>> consistent with the above explanation. Does it happen both in desktop and
>>>>>>>>> mobile?
>>>>>>>>>
>>>>>>>>> Saludos
>>>>>>>>>
>>>>>>>>> Rubén
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Sep 18, 2020 at 1:18 PM Patrick Allen Zulueta <
>>>>>>>>> alexander.allenz at gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Hello, first of all I have to tell you that Vtiger layout in this
>>>>>>>>>> version is very responsive. Well done.
>>>>>>>>>>
>>>>>>>>>> Now, I have a question, after migrate from 6.5 to 7.2 everything
>>>>>>>>>> goes good but after migration to 7.3 when I make a mass edit for my custom
>>>>>>>>>> module it erase one field related to HelpDesk module in records I edit.
>>>>>>>>>> Does anyone had the same issue?
>>>>>>>>>> _______________________________________________
>>>>>>>>>> http://www.vtiger.com/
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> http://www.vtiger.com/
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> http://www.vtiger.com/
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> With
>>>>>>> Best Regards
>>>>>>> Uma.S
>>>>>>> Vtiger Team
>>>>>>>
>>>>>> _______________________________________________
>>>>>> http://www.vtiger.com/
>>>>>
>>>>> _______________________________________________
>>>>> http://www.vtiger.com/
>>>>
>>>>
>>>>
>>>> --
>>>> With
>>>> Best Regards
>>>> Uma.S
>>>> Vtiger Team
>>>> _______________________________________________
>>>> http://www.vtiger.com/
>>>
>>> _______________________________________________
>>> http://www.vtiger.com/
>>
>> _______________________________________________
>> http://www.vtiger.com/
>
>
>
> --
> With
> Best Regards
> Uma.S
> Vtiger Team
> _______________________________________________
> http://www.vtiger.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200921/708746f0/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 16363 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200921/708746f0/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 31219 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200921/708746f0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 31489 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200921/708746f0/attachment-0005.png>