[Vtigercrm-developers] Git repository structure

[Uma S]

Hi Martin,

I have reported this issue
<https://code.vtiger.com/vtiger/vtigercrm/issues/1492>, Please do update
your observations here.

On Mon, Sep 21, 2020 at 4:30 PM Uma S <uma.s at vtiger.com> wrote:

> That's a good suggestion, let's review this and get back to you.
>
> On Mon, Sep 21, 2020 at 1:08 PM Martin Allen <martin.allen at clystnet.com>
> wrote:
>
>> Thanks for pointing that location out, had never seen that.
>> Still slightly mystified as to why that structure is used, as now after
>> installation I have the ModTracker files (and MANY others) in 3x locations,
>> 1x in the packages/vtiger directories (in .zip format) , 1x in the
>> pkg/vtiger/modules/ (now unzipped) and then in its actual location when in
>> use /modules/ModTracker .
>> My original point still stands that surely it makes much more sense to
>> just put the files in the location that they are required to be in!
>>
>> Martin Allen
>>
>>
>> *01392 248692 - Main Office01392 690659 - Direct Line*
>>
>> *[image: signature2]*
>>
>> Have you visited our website recently? http://www.clystnet.com
>>
>>
>> The information in this email is confidential If you are not the intended
>> recipient, you must not read or use that information. This email and any
>> attachments are believed to be virus free however no responsibility is
>> accepted by Clystnet for any loss or damage arising in any way from receipt
>> or use thereof. Clystnet Ltd (company reg number 7164503) is based at
>> Silverdown Park, Fair Oak Close, Clyst Honiton, EX5 2UX
>>
>>
>> On Sat, 19 Sep 2020 at 18:37, Uma S <uma.s at vtiger.com> wrote:
>>
>>> Hi Martin,
>>>
>>> Yes! changes to Modtracker can be tracked through pkg/ folder. zip files
>>> have many used during installation and migrations.
>>>
>>> On Sat, Sep 19, 2020 at 6:01 AM Rubén A. Estrada Orozco <
>>> rulotec1 at gmail.com> wrote:
>>>
>>>> Take a look at
>>>> pkg/vtiger/modules/ModTracker/modules/ModTracker/ModTrackerHandler.php
>>>>
>>>> I agree that keeping those zip files in the repository is of no use.
>>>>
>>>> Saludos
>>>>
>>>> Rubén
>>>>
>>>>
>>>> On Fri, Sep 18, 2020 at 6:49 PM Martin Allen <martin.allen at clystnet.com>
>>>> wrote:
>>>>
>>>>> Just had to raise an issue with Modtracker (
>>>>> https://code.vtiger.com/vtiger/vtigercrm/issues/1490)
>>>>> but due to the fact that the repository store the ModTracker module
>>>>> (and many other) files in /packages directory as ZIP files it is impossible
>>>>> to track the changes that have been made to these files that have led to it
>>>>> now being broken.
>>>>>
>>>>> There is also little point in having the files in ZIP's and then later
>>>>> zipping the whole repository again!
>>>>>
>>>>> Just take them all out into their normal location and zip all
>>>>> repository files,  so we can track changes. Also because of this I cannot
>>>>> do a merge request with a suggested fix for the issue in the
>>>>> Modtracker files (unless you want me to extract the zip file, make an
>>>>> undocumented change, zip it back up and merge request the zip file for you
>>>>> to unpack and try to find my change !)
>>>>>
>>>>> Martin Allen
>>>>>
>>>>>
>>>>> *01392 248692 - Main Office01392 690659 - Direct Line*
>>>>>
>>>>> *[image: signature2]*
>>>>>
>>>>> Have you visited our website recently? http://www.clystnet.com
>>>>>
>>>>>
>>>>> The information in this email is confidential If you are not the
>>>>> intended recipient, you must not read or use that information. This email
>>>>> and any attachments are believed to be virus free however no responsibility
>>>>> is accepted by Clystnet for any loss or damage arising in any way from
>>>>> receipt or use thereof. Clystnet Ltd (company reg number 7164503) is based
>>>>> at Silverdown Park, Fair Oak Close, Clyst Honiton, EX5 2UX
>>>>> _______________________________________________
>>>>> http://www.vtiger.com/
>>>>
>>>> _______________________________________________
>>>> http://www.vtiger.com/
>>>
>>>
>>>
>>> --
>>> With
>>> Best Regards
>>> Uma.S
>>> Vtiger Team
>>> _______________________________________________
>>> http://www.vtiger.com/
>>
>> _______________________________________________
>> http://www.vtiger.com/
>
>
>
> --
> With
> Best Regards
> Uma.S
> Vtiger Team
>


-- 
With
Best Regards
Uma.S
Vtiger Team
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200921/0974f4e6/attachment.html>