[Vtigercrm-developers] closing php tag and corrupted excel files

[Uma S]

Thanks! Henry and Ruben for your inputs, We will review.

On Fri, Sep 4, 2020 at 9:30 PM Rubén A. Estrada Orozco <rulotec1 at gmail.com>
wrote:

> I've opened the issue here:
> https://code.vtiger.com/vtiger/vtigercrm/issues/1477
>
> Thanks for the links Henry!
>
> Saludos
>
> Rubén
>
>
> On Fri, Sep 4, 2020 at 7:19 AM Henry Cumbicus Rivera <hcumbicusr at gmail.com>
> wrote:
>
>> I agree with Rubén, in some cases it caused me problems and the solution
>> was simply to remove the closing tag.
>>
>> Cases and documentation:
>> https://www.php.net/basic-syntax.phptags
>> https://www.php.net/basic-syntax.instruction-separation
>>
>> https://stackoverflow.com/questions/4410704/why-would-one-omit-the-close-tag#:~:text=The%20reason%20you%20should%20leave,not%20add%20extra%20white%2Dspace
>> .
>>
>> https://gulvi.com/serie/trucos-php/capitulo/por-que-no-poner-etiqueta-cierre-php
>>
>>
>> El vie., 4 sept. 2020 a las 1:53, Uma S (<uma.s at vtiger.com>) escribió:
>>
>>> Hi Ruben,
>>>
>>> Thanks! for the proposed coding guideline on removal of php closing tag
>>> we will review this. Please do share if you have any supporting
>>> documentation.
>>>
>>> I am not clear on how this is impacting the excel files download, Please
>>> do describe the issue in detail. Reporting it on code.vtiger.com with
>>> an explanation will be good.
>>>
>>> On Fri, Sep 4, 2020 at 3:57 AM Rubén A. Estrada Orozco <
>>> rulotec1 at gmail.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Today I had to fix a  problem with excel files downloaded from the
>>>> documents module.  The files didn't display correctly, just a bunch of
>>>> unreadable characters like these:
>>>>
>>>> [image: image.png]
>>>>
>>>> The problem was that there was a new line at the end of the
>>>> config.inc.php file.
>>>>
>>>> Wouldn't it be a good idea to get rid of the closing "?>" part of the
>>>> php tag?
>>>>
>>>> I think that in general it would be good to avoid closing php tags.
>>>> There are projects like prestashop that set it as a coding guideline.
>>>>
>>>>
>>>>
>>>> Saludos
>>>>
>>>> Rubén
>>>> _______________________________________________
>>>> http://www.vtiger.com/
>>>
>>>
>>>
>>> --
>>> With
>>> Best Regards
>>> Uma.S
>>> Vtiger Team
>>> _______________________________________________
>>> http://www.vtiger.com/
>>
>>
>>
>> --
>>
>> ---------------------------------------------------------------
>> Henry C.
>> Tel.: 956727976
>> _______________________________________________
>> http://www.vtiger.com/
>
> _______________________________________________
> http://www.vtiger.com/



-- 
With
Best Regards
Uma.S
Vtiger Team
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200908/6eb012ba/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 95206 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200908/6eb012ba/attachment-0001.png>