[Vtigercrm-developers] Uploading att to comment

Wed Jun 24 15:46:22 GMT 2020

Great Uma!

I can confirm it's fixed:

However, there is this mustard colored border around the picture:

[image: image.png]

Saludos

Rubén

On Wed, Jun 24, 2020 at 6:49 AM Uma S <uma.s at vtiger.com> wrote:

> Hi Ruben,
>
> I checked through this case and noticed that the changes are not present
> in the package file, Due to which profile image in ModComments is breaking.
>
> Here are the commit
> <https://code.vtiger.com/vtiger/vtigercrm/commit/db615f422f9304e20c6599e779480e5361f8e16c>
> changes.
>
> On Mon, Jun 22, 2020 at 4:58 PM Uma S <uma.s at vtiger.com> wrote:
>
>> Hi,
>>
>> Thanks! For the alert, I will re-check with this case.
>>
>> On Fri, Jun 19, 2020 at 11:12 PM Rubén A. Estrada Orozco <
>> rulotec1 at gmail.com> wrote:
>>
>>> Hi Nilay,
>>>
>>> Yes I do have imagick installed and enabled.
>>>
>>> Saludos
>>>
>>> Rubén
>>>
>>>
>>> On Fri, Jun 19, 2020 at 3:05 AM nilay khatri <nilay.spartan at gmail.com>
>>> wrote:
>>>
>>>> Do you have the php-imagemagick extension installed?
>>>>
>>>> @uma srinivas <srinivas.uma306 at gmail.com>  even I tried the fresh
>>>> install and the results are not consistent. There is some issue with the
>>>> user profile image.
>>>>
>>>> On Thu, Jun 18, 2020 at 9:34 PM Rubén A. Estrada Orozco <
>>>> rulotec1 at gmail.com> wrote:
>>>>
>>>>> Hi Uma,
>>>>>
>>>>> I just did a test with a very recent version (I pulled it this same
>>>>> week from the master branch) and it's not working:
>>>>>
>>>>> [image: image.png]
>>>>>
>>>>> Same thing happens with a production instance that uses version 7.2.
>>>>>
>>>>>
>>>>> Saludos
>>>>>
>>>>> Rubén
>>>>>
>>>>>
>>>>> On Thu, Jun 18, 2020 at 12:38 AM Uma S <uma.s at vtiger.com> wrote:
>>>>>
>>>>>> Hi Ruben,
>>>>>>
>>>>>> Just do a hard refresh to re-login and try, I think that should work.
>>>>>>
>>>>>> On Wed, Jun 17, 2020 at 9:09 PM Rubén A. Estrada Orozco <
>>>>>> rulotec1 at gmail.com> wrote:
>>>>>>
>>>>>>> Hi Uma,
>>>>>>>
>>>>>>> Yes, that's exactly what I found. Users' profile pictures don't
>>>>>>> display in comments. What do you mean with cache issues? Should I clear a
>>>>>>> specific folder?
>>>>>>>
>>>>>>> Saludos
>>>>>>>
>>>>>>> Rubén
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Jun 17, 2020 at 3:15 AM Uma S <uma.s at vtiger.com> wrote:
>>>>>>>
>>>>>>>> Hi Ruben,
>>>>>>>>
>>>>>>>> I checked through the profile image display in comments, which
>>>>>>>> works fine now. I think there may be some cache issue while generating the
>>>>>>>> url.
>>>>>>>>
>>>>>>>> On Wed, Jun 17, 2020 at 10:24 AM Uma S <uma.s at vtiger.com> wrote:
>>>>>>>>
>>>>>>>>> Hi Ruben,
>>>>>>>>>
>>>>>>>>> I have checked for the user image in My preference and contacts
>>>>>>>>> profile image and product image upload at these places it looks fine.
>>>>>>>>>
>>>>>>>>> Now, I noticed that the user image in the comments section is not
>>>>>>>>> rendering properly. Are you pointing to the same issue? If not please do
>>>>>>>>> specify the case . So that i can re-check and address.
>>>>>>>>>
>>>>>>>>> On Tue, Jun 16, 2020 at 9:24 PM Rubén A. Estrada Orozco <
>>>>>>>>> rulotec1 at gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Hi, I don't know if it's related but I had problems with files
>>>>>>>>>> uploaded in vtiger 7.2. For example users' photos don't display correctly
>>>>>>>>>> and I also noticed those modified file names. Maybe some bugs were
>>>>>>>>>> introduced with this new feature.
>>>>>>>>>> Saludos
>>>>>>>>>>
>>>>>>>>>> Rubén
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Tue, Jun 16, 2020 at 10:16 AM Uma S <uma.s at vtiger.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Team,
>>>>>>>>>>>
>>>>>>>>>>> As file name disclosure will lead to an xss
>>>>>>>>>>> vulnerability through end-point, We have made these changes not to disclose
>>>>>>>>>>> filename.
>>>>>>>>>>>
>>>>>>>>>>> On Tue, Jun 16, 2020 at 1:04 PM Alan Lord <alanslists at gmail.com>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> There were several patches committed to master a while ago for
>>>>>>>>>>>> this:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> https://code.vtiger.com/vtiger/vtigercrm/merge_requests?%20utf8=%C3%A2%C2%9C%C2%93&issue_search=obscu&state=all&scope=all&assignee_id=&author_id=&milestone_id=&label_id=
>>>>>>>>>>>>
>>>>>>>>>>>> All attachments now are stored as an md5 hash.
>>>>>>>>>>>>
>>>>>>>>>>>> HTH
>>>>>>>>>>>>
>>>>>>>>>>>> Al
>>>>>>>>>>>>
>>>>>>>>>>>> On 16/06/2020 00:48, Tony Sandman wrote:
>>>>>>>>>>>> > Gents, while uploading attachment to ticket comment, the
>>>>>>>>>>>> original file
>>>>>>>>>>>> > name changing to 547094_033032447bc4a81fdfc7e50119360452.pdf
>>>>>>>>>>>> and similar.
>>>>>>>>>>>> > That random naming make document not accessible.
>>>>>>>>>>>> > Any tips on that?
>>>>>>>>>>>> >
>>>>>>>>>>>> > Cheers
>>>>>>>>>>>> >
>>>>>>>>>>>> > _______________________________________________
>>>>>>>>>>>> > http://www.vtiger.com/
>>>>>>>>>>>> >
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>> http://www.vtiger.com/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> With
>>>>>>>>>>> Best Regards
>>>>>>>>>>> Uma.S
>>>>>>>>>>> Vtiger Team
>>>>>>>>>>> _______________________________________________
>>>>>>>>>>> http://www.vtiger.com/
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> http://www.vtiger.com/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> With
>>>>>>>>> Best Regards
>>>>>>>>> Uma.S
>>>>>>>>> Vtiger Team
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> With
>>>>>>>> Best Regards
>>>>>>>> Uma.S
>>>>>>>> Vtiger Team
>>>>>>>> _______________________________________________
>>>>>>>> http://www.vtiger.com/
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> http://www.vtiger.com/
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> With
>>>>>> Best Regards
>>>>>> Uma.S
>>>>>> Vtiger Team
>>>>>> _______________________________________________
>>>>>> http://www.vtiger.com/
>>>>>
>>>>> _______________________________________________
>>>>> http://www.vtiger.com/
>>>>
>>>> _______________________________________________
>>>> http://www.vtiger.com/
>>>
>>> _______________________________________________
>>> http://www.vtiger.com/
>>
>>
>>
>> --
>> With
>> Best Regards
>> Uma.S
>> Vtiger Team
>>
>
>
> --
> With
> Best Regards
> Uma.S
> Vtiger Team
> _______________________________________________
> http://www.vtiger.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200624/ebcda926/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 16549 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200624/ebcda926/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 17888 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20200624/ebcda926/attachment-0003.png>