[Vtigercrm-developers] displaytype in fields

Thu Dec 3 17:43:53 GMT 2020

Uma I answered via GitLab,

I also have a question that maybe someone else can answer. What is the
difference between uitypes 5, 6, and 23?

const UITYPE_DATE = 5;
const UITYPE_ACTIVITY_DATE_START = 6;
const UITYPE_DATE_2 = 23;

As you can see I couldn't come up with a good name for uitype 23.

Saludos

Rubén

On Thu, Dec 3, 2020 at 8:49 AM Uma S <uma.s at vtiger.com> wrote:

> Hi Ruben,
>
> This looks good to me, Having descriptive constants for uitypes and
> display types.
>
> Whereas I am thinking about extensibility and cleanup of dependencies,
> i.e., Files using these constants like CRMEntity.php.
>
> Do you have any plans for this?
>
> On Thu, Dec 3, 2020 at 1:43 PM Martin Allen <martin.allen at clystnet.com>
> wrote:
>
>> Yes, this is the old UI Type documentation -
>> https://wiki.vtiger.com/index.php/UI_Types
>> As you'll see its very different compared to your list!!
>>
>> Like the idea of putting brief description as a comment in your list
>>
>> Martin Allen
>>
>>
>> *01392 248692 - Main Office01392 690659 - Direct Line*
>>
>> *[image: signature2]*
>>
>> Have you visited our website recently? https://www.clystnet.com
>> <http://www.clystnet.com/>
>>
>>
>> The information in this email is confidential If you are not the intended
>> recipient, you must not read or use that information. This email and any
>> attachments are believed to be virus free however no responsibility is
>> accepted by Clystnet for any loss or damage arising in any way from receipt
>> or use thereof. Clystnet Ltd (company reg number 7164503) is based at
>> Silverdown Park, Fair Oak Close, Clyst Honiton, EX5 2UX
>>
>>
>> On Wed, 2 Dec 2020 at 17:28, Rubén A. Estrada Orozco <rulotec1 at gmail.com>
>> wrote:
>>
>>> Martin, I think I did cover them all. I actually did something very
>>> similar to the query suggested by Alan. I ran:
>>>
>>> SELECT DISTINCT(uitype), fieldname, fieldlabel, tablename FROM
>>> vtiger_field ORDER BY uitype;
>>>
>>>
>>> With that query you see all fields that use a specific uitype side by
>>> side.
>>>
>>> I suspect that many of the uitypes were created because of a lack of
>>> awareness of already existing uitypes that could be used. I also suspect
>>> that uitype 255 was probably created by someone thinking the uitype was the
>>> length of the field.
>>>
>>> I'm not sure about the idea of creating documentation for uitypes. The
>>> problem with that is that the code and the documentation quickly start to
>>> diverge and then the only thing you can trust is the code itself. I prefer
>>> creating expressive code that doesn't need documentation. Maybe we could
>>> add more comments to each constant. If I recall correctly there used to be
>>> a uitypes list somewhere (the old wiki maybe?).
>>>
>>>
>>> Saludos
>>>
>>> Rubén
>>>
>>>
>>> On Wed, Dec 2, 2020 at 2:37 AM Martin Allen <martin.allen at clystnet.com>
>>> wrote:
>>>
>>>> Are all of those covered in your commit Ruben?
>>>>
>>>> Would be good if the vTiger developer documentation was updated to
>>>> include this full list and give an example of each field type and/or a
>>>> description of what's different about each one - i'm particularly intrigued
>>>> by :
>>>>
>>>> const UITYPE_POTENTIAL_REFERENCE = 76;
>>>> const UITYPE_QUOTES_REFERENCE = 78;
>>>> const UITYPE_SALESORDER_REFERENCE = 80;
>>>> const UITYPE_VENDOR_REFERENCE = 81;
>>>>
>>>> Why do these modules have their own reference field UI types??
>>>>
>>>> Martin Allen
>>>>
>>>>
>>>> *01392 248692 - Main Office01392 690659 - Direct Line*
>>>>
>>>> *[image: signature2]*
>>>>
>>>> Have you visited our website recently? https://www.clystnet.com
>>>> <http://www.clystnet.com/>
>>>>
>>>>
>>>> The information in this email is confidential If you are not the
>>>> intended recipient, you must not read or use that information. This email
>>>> and any attachments are believed to be virus free however no responsibility
>>>> is accepted by Clystnet for any loss or damage arising in any way from
>>>> receipt or use thereof. Clystnet Ltd (company reg number 7164503) is based
>>>> at Silverdown Park, Fair Oak Close, Clyst Honiton, EX5 2UX
>>>>
>>>>
>>>> On Wed, 2 Dec 2020 at 07:55, Alan Lord <alanslists at gmail.com> wrote:
>>>>
>>>>> On 02/12/2020 00:50, Rubén A. Estrada Orozco wrote:
>>>>> > Thanks Martin!
>>>>> >
>>>>> > It turns out there are a lot more uitype codes than I imagined. Many
>>>>> of
>>>>> > them seem to be redundant:
>>>>> >
>>>>> https://code.vtiger.com/ruben.estrada/vtigercrm/commit/a8fd66c525a59a174dc275985ce73e6c71793ab2
>>>>> >
>>>>>
>>>>>
>>>>> If you run "SELECT DISTINCT(utype) FROM `vtiger_field`;" you get:
>>>>>
>>>>> 1
>>>>> 2
>>>>> 3
>>>>> 4
>>>>> 5
>>>>> 6
>>>>> 7
>>>>> 8
>>>>> 9
>>>>> 10
>>>>> 11
>>>>> 12
>>>>> 13
>>>>> 15
>>>>> 16
>>>>> 17
>>>>> 19
>>>>> 20
>>>>> 21
>>>>> 22
>>>>> 23
>>>>> 24
>>>>> 25
>>>>> 26
>>>>> 27
>>>>> 28
>>>>> 30
>>>>> 31
>>>>> 32
>>>>> 51
>>>>> 52
>>>>> 53
>>>>> 55
>>>>> 56
>>>>> 57
>>>>> 58
>>>>> 59
>>>>> 61
>>>>> 63
>>>>> 66
>>>>> 69
>>>>> 70
>>>>> 71
>>>>> 72
>>>>> 73
>>>>> 75
>>>>> 76
>>>>> 77
>>>>> 78
>>>>> 80
>>>>> 81
>>>>> 83
>>>>> 98
>>>>> 99
>>>>> 101
>>>>> 104
>>>>> 105
>>>>> 106
>>>>> 115
>>>>> 116
>>>>> 117
>>>>> 156
>>>>> 255
>>>>> 357
>>>>>
>>>>> Al
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> http://www.vtiger.com/
>>>>
>>>> _______________________________________________
>>>> http://www.vtiger.com/
>>>
>>> _______________________________________________
>>> http://www.vtiger.com/
>>
>> _______________________________________________
>> http://www.vtiger.com/
>
>
>
> --
> With
> Best Regards
> Uma.S
> Vtiger Team
> _______________________________________________
> http://www.vtiger.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20201203/3ab316eb/attachment.html>