[Vtigercrm-developers] error in select all and mass edit ??

[Joe Bordes]

Hi Stefan,

I don't know if you had a chance to try the patch or not, but it has 
been working correctly for a few weeks now.
Today, my client found an error in the change.
I attach the complete patch with the additional change and an 
accumulative patch which can be applied upon the previous one.

Regards
Joe
TSolucio


On 03/05/13 18:29, Joe Bordes wrote:
> Hi Stefan,
>
> Thanks for your confirmation.
>
> I created the attached patch. It seems to be working.
> Can you give it a try and further validated it please?
> I will apply it to my client's install next week, see what they have 
> to say.
>
> Have a nice weekend
> Joe
> TSolucio
>
>
> El 03/05/13 14:02, Stefan Warnat escribió:
>> Hy,
>>
>> Yes. I can confirm this error in all of my 5.4.0 systems. Don't test 
>> any 6.0 system.
>>
>> Some clients ask for a solution, but until now, i couldn't found a 
>> bugfix.
>>
>> Stefan
>>
>> Am 03.05.2013 12:39, schrieb Joe Bordes:
>>> Hi,
>>>
>>> We have just detected and error when doing a mass edit on search 
>>> records. We had a look at the code and it looks like it is 
>>> incorrect, but I wanted to run it through the list before creating a 
>>> trac ticket or doing more investigation.
>>>
>>> - launch a search which returns more than one page full of information.
>>> - select all the records on the page
>>> - click on the "select all xx records" to select all the records 
>>> returned from the search
>>> - now click the mass edit button
>>>
>>> if you look at the parameters sent to the mass edit screen you will 
>>> see that the id list is set to "all" but no search parameters are 
>>> sent. The mass edit code does look for the search parameters but 
>>> since they aren't sent in you end up editing a whole bunch of 
>>> unrelated records.
>>>
>>> We tried this on a customized vtiger CRM where our client detected 
>>> it and the verified it on our internal vtiger CRM.
>>>
>>> We looked at the code in 5.4.0 security patch and 6.0.0 on the trac 
>>> and it is the same.
>>>
>>> Can anybody confirm that, please?
>>>
>>>
>>
>> _______________________________________________
>> http://www.vtiger.com/
>
>
>
> _______________________________________________
> http://www.vtiger.com/


-- 
Un saludo
Joe
TSolucio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130523/c3ee002d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MassEditSearchRestrictionSelectAllBug.diff
Type: text/x-patch
Size: 6684 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130523/c3ee002d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MassEditSearchRestrictionSelectAllBug_accum2.diff
Type: text/x-patch
Size: 1574 bytes
Desc: not available
URL: <http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20130523/c3ee002d/attachment-0001.bin>