[Vtigercrm-developers] Customerportal layout bugs in 5.10

[Alan Lord (News)]

I've fixed a couple of minor layout bugs with the customer portal that were:

* causing the white border of the main content area to break apart 
between the td containing loginSITopLeft.gif and it's neighbour.
* a missing td pair for the far right column of main content table was 
unsightly.

I tried to file a bug on trac but it just seemed to hang and I can't 
spend all day trying to submit a 4 line patch. Here it is... these 
errors are both fixed in footer.html.

--- ../vtigercrm-customerportal-5.1.0/footer.html       2009-06-22 
02:38:32.000000000 +0100
+++ footer.html 2009-09-08 14:44:25.000000000 +0100
@@ -17,11 +17,12 @@
                 </table>
                 <!-- Table with Tickets and FAQ tabs - Ends -->
                 </td>
+               <td width="6">&nbsp;</td>
         </tr>
         <tr>
-                <td width="2%">&nbsp;</td>
-                <td width="98%" align="right"><?php echo 
getTranslatedString(customerportal)." ".$version; ?></td>
-                <td width="2%">&nbsp;</td>
+                <td width="6">&nbsp;</td>
+                <td align="right"><?php echo 
getTranslatedString(customerportal)." ".$version; ?></td>
+                <td width="6">&nbsp;</td>
         </tr>

         </table>

These errors were visible in Firefox 3 and Google Chrome. (I don't use 
Windows and so have not checked in IE6,7,8 or Safari but the fix should 
be OK in those too)


There are a couple of other minor errors I've noticed. (See attached 
image, if it works. If not, click here: 
http://imagebin.ca/view/pu5-ZZ7H.html)

* A breakage in the layout with wider screen displays. The thin grey 
border that surrounds the main content of the customer portal breaks 
away from the menu on the right hand-side.

* A White block about 5px wide and taller than the header appears on the 
far right. Not sure where this has come from.

When I get a moment I'll try and look at these too.


As an aside, the judicious use of tables for laying out everything is 
not really good practice, causes hell for accessibility users 
(especially screen readers and the like) and should be discouraged.

Cheers

Al
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot-vtiger-CustomerPortal.png
Type: image/png
Size: 28426 bytes
Desc: not available
Url : http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20090908/d743ea65/attachment-0003.png