[Vtigercrm-developers] (no subject)

[Joe Bordes]

Hi,

Shouldn't the line:

if(type === 'Contacts' || $("cont_cv_list").value != 'None')


be

if(type === 'Contacts' && $("cont_cv_list").value != 'None')

Changed || for &&

Best place for this kind of contribution is to open a trac ticket.

Thanks for sharing.
Joe
TSolucio

Paproth, Stefan escribió:
> Hi there,
>
> I have the following problem:
>
> I’ve disabled the module "leads".  When selecting a campaign (
> “Marketing”->"Campaigns"),choosing "More Informations" and then trying
> to load a list by clicking on the button “Load List” the following
> JavaScript Error occurs.:
>
> $("lead_cv_list") is undefined
>
>  
>
> The attached patch should fix the problem. Could you integrate the
> patch into the next vtiger release?
>
>  
>
> best regards
>
> Stefan
>
>  
>
>  
>
> File can be found under "Smarty/templates"
>
>  
>
>  
>
> --- RelatedLists.tpl_BA 2009-08-25 14:44:55.000000000 +0200
> +++ RelatedLists.tpl    2009-08-25 14:47:00.000000000 +0200
> @@ -52,11 +52,9 @@
>  
>  function loadCvList(type,id)
>  {ldelim}
> -        if($("lead_cv_list").value != 'None' ||
> $("cont_cv_list").value != 'None')
> -        {ldelim}
> -               $("status").style.display="inline";
> -               if(type === 'Leads')
> +               if(type === 'Leads' && $("lead_cv_list").value != 'None')
>                 {ldelim}
> +               $("status").style.display="inline";
>                          new Ajax.Request(
>                          'index.php',
>                          {ldelim}queue: {ldelim}position: 'end',
> scope: 'command'{rdelim},
> @@ -70,8 +68,9 @@
>                         );
>                 {rdelim}
>  
> -               if(type === 'Contacts')
> +               if(type === 'Contacts' || $("cont_cv_list").value !=
> 'None')
>                 {ldelim}
> +               $("status").style.display="inline";
>                          new Ajax.Request(
>                          'index.php',
>                          {ldelim}queue: {ldelim}position: 'end',
> scope: 'command'{rdelim},
> @@ -84,7 +83,6 @@
>                          {rdelim}
>                         );
>                 {rdelim}
> -        {rdelim}
>  {rdelim}
>  </script>
>         {include file='Buttons_List1.tpl'}
>
>  
>
>  
>
>  
>
>  
>  
> ------------------------------------------------------------------------
>
> _______________________________________________
> Reach hundreds of potential candidates - http://jobs.vtiger.com 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20090825/e7fd3599/attachment-0003.html