[Vtigercrm-developers] [patch] Login, then "browser back" causes "mixed" screen

[Torsten Zenk]

Hello Kristof,
oh yes i can reproduce it with all of my browsers. After logging there 
is indeed this mixed screen.

But i´m sorry that i can´t reproduce the diff you provided. I am used to 
the way a diff is provided like this (this is the way drupal and joomla 
diffs are provided)

RCS file: 
/cvs/drupal-contrib/contributions/modules/imagefield/imagefield.module,v
retrieving revision 1.30.2.6.2.64
diff -u -p -r1.30.2.6.2.64 imagefield.module
--- imagefield.module    13 May 2008 00:02:02 -0000    1.30.2.6.2.64
+++ imagefield.module    10 Jul 2008 04:00:18 -0000
@@ -163,18 +163,16 @@ function imagefield_field_settings($op,
       $ext = array_pop(explode('.', $file->filename));
       $filename = $field['field_name'] .'.'. $ext;
       // verify the destination exists and is writeable...
-      $dst = file_create_path('imagefield_default_images/'. $filename);
+      $dst = 'imagefield_default_images/'. $filename;
       if (!imagefield_check_directory(dirname($dst))) {

So besides the filename in which the changes have to be made, here i 
have the functionname, the lines above and below the line that is 
changed AND the whole row that must be changed. In the way you provide 
your diff i can not reproduce the patch because:

1.

(isset($_SESSION["app_unique_key  <<< suddenly ends without any closing, what´s the reason for this?

2. it says 
1 files changed, 5 insertions(+), 0 deletions(-)

WHAT has to be changed and WHERE do i put the 5 lines that have to be added.

Maybe its just me misunderstanding the diff, but i would be glad if you could make it a little easier to understand, so i could provide a better feedback then this ;)


Best Regards

Torsten Zenk


Kristof Kovacs schrieb:
> Hello guys,
>
> On certain browsers, if the user hits a "browser back" after logging  
> in to vtiger, he is presented with a screen that has a menu on the  
> top, and the login screen in the middle. This is of course a minor  
> bug, but there were complaints, so we fixed, and here is the patch.
>
> To reproduce the bug on any browser: Log in, and then go to index.php? 
> action=Login&module=Users .
>
> Krist�f
>
> ---
>   index.php |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/index.php b/index.php
> index ae23b93..3781a08 100644
> --- a/index.php
> +++ b/index.php
> @@ -192,6 +192,11 @@ if(isset($_SESSION["authenticated_user_id"]) &&  
> (isset($_SESSION["app_unique_key
>           $use_current_login = true;
>   }
>
> +// Prevent loading Login again if there is an authenticated user in  
> the session.
> +if (isset($_SESSION['authenticated_user_id']) && $module == 'Users'  
> && $action == 'Login') {
> +        header("Location: index.php?action=$default_action&module= 
> $default_module");
> +}
> +
>   if($use_current_login)
>   {
>
>
>
> _______________________________________________
> Reach hundreds of potential candidates - http://jobs.vtiger.com 
>
>