From weigelt at metux.de Tue May 1 10:58:50 2007 From: weigelt at metux.de (Enrico Weigelt) Date: Tue, 1 May 2007 19:58:50 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> Message-ID: <20070501175850.GB26224@nibiru.local> * Jorge Torres schrieb: Hi, > I love PHP, and I thought that I could minimize it to what at this > moment I need, and in near future add more AJAX to it. I know that > may differ a lot from what vtiger golas might be, therefore I want > to start a new project at sourceforge.net based on vtigerCRM 5. Of course you're free to do your own fork, but I'd like to invite you to contribute to the upstream. If you're moving too far from the upstream, we cannot benefit from each other's work anymore. BTW: I'm currently working on my own branch for really porting it to postgresql. There're lots of things to clean up here. Once this is is done (and hopefully went to the upstream), I'm going to some works on making it easier to use (ie. switch off unused features). Maybe you'd like to join me ? cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service phone: +49 36207 519931 www: http://www.metux.de/ fax: +49 36207 519932 email: contact at metux.de cellphone: +49 174 7066481 --------------------------------------------------------------------- -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- --------------------------------------------------------------------- From jorge.torres.maldonado at gmail.com Tue May 1 12:48:36 2007 From: jorge.torres.maldonado at gmail.com (Jorge Torres) Date: Tue, 1 May 2007 14:48:36 -0500 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070501175850.GB26224@nibiru.local> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> Message-ID: <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> Enrico, Sure count me in, Can you send me some of your todo list, so I can check what I'm capable of helping with? That minimized branch you mentioned, would it still support MySQL? At this moment, I'm working on changing the pop-up windows, for WebWM windows, anyhow I will prepare a todo list I have in mind, so you get to see where we can join forces. Thank you, Jorge On 5/1/07, Enrico Weigelt wrote: > > * Jorge Torres schrieb: > > Hi, > > > I love PHP, and I thought that I could minimize it to what at this > > moment I need, and in near future add more AJAX to it. I know that > > may differ a lot from what vtiger golas might be, therefore I want > > to start a new project at sourceforge.net based on vtigerCRM 5. > > Of course you're free to do your own fork, but I'd like to invite > you to contribute to the upstream. If you're moving too far from the > upstream, we cannot benefit from each other's work anymore. > > BTW: I'm currently working on my own branch for really porting it to > postgresql. There're lots of things to clean up here. Once this is > is done (and hopefully went to the upstream), I'm going to some > works on making it easier to use (ie. switch off unused features). > > Maybe you'd like to join me ? > > > cu > -- > --------------------------------------------------------------------- > Enrico Weigelt == metux IT service > > phone: +49 36207 519931 www: http://www.metux.de/ > fax: +49 36207 519932 email: contact at metux.de > cellphone: +49 174 7066481 > --------------------------------------------------------------------- > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > --------------------------------------------------------------------- > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20070501/689d85dc/attachment.htm From weigelt at metux.de Tue May 1 13:05:52 2007 From: weigelt at metux.de (Enrico Weigelt) Date: Tue, 1 May 2007 22:05:52 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> Message-ID: <20070501200552.GC26224@nibiru.local> * Jorge Torres schrieb: Hi, > Can you send me some of your todo list, so I can check what > I'm capable of helping with? The most important, for now, is to replace all the $adb->query_result() calls, since a) it does not work with postgresql (adodb brokenness) and b) it's an huge resource waster. > That minimized branch you mentioned, would it still support MySQL? Yep. I don't intend to drop it. > At this moment, I'm working on changing the pop-up windows, for WebWM > windows, anyhow I will prepare a todo list I have in mind, so you get to see > where we can join forces. Ok. cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service phone: +49 36207 519931 www: http://www.metux.de/ fax: +49 36207 519932 email: contact at metux.de cellphone: +49 174 7066481 --------------------------------------------------------------------- -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- --------------------------------------------------------------------- From dome at tel.co.th Tue May 1 18:06:13 2007 From: dome at tel.co.th (Dome Charoenyost) Date: Wed, 2 May 2007 08:06:13 +0700 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070501200552.GC26224@nibiru.local> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> Message-ID: <8ccbff060705011806h329d10afwfb63c5ebd56b1a9c@mail.gmail.com> What's status of your poetgresql branch ? Can i test ? Dome C. On 5/2/07, Enrico Weigelt wrote: > * Jorge Torres schrieb: > > Hi, > > > Can you send me some of your todo list, so I can check what > > I'm capable of helping with? > > The most important, for now, is to replace all the $adb->query_result() > calls, since a) it does not work with postgresql (adodb brokenness) > and b) it's an huge resource waster. > > > That minimized branch you mentioned, would it still support MySQL? > > Yep. I don't intend to drop it. > > > At this moment, I'm working on changing the pop-up windows, for WebWM > > windows, anyhow I will prepare a todo list I have in mind, so you get to see > > where we can join forces. > > Ok. > > > cu > -- > --------------------------------------------------------------------- > Enrico Weigelt == metux IT service > > phone: +49 36207 519931 www: http://www.metux.de/ > fax: +49 36207 519932 email: contact at metux.de > cellphone: +49 174 7066481 > --------------------------------------------------------------------- > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > --------------------------------------------------------------------- > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > From gopals at vtiger.com Tue May 1 21:19:25 2007 From: gopals at vtiger.com (Gopal) Date: Wed, 02 May 2007 09:49:25 +0530 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> Message-ID: <4638114D.5010303@vtiger.com> Hi Jorge, Thanks for your interest in vtiger CRM project. Please see my response below (in blue color) Jorge Torres wrote: > Hi everyone, > > First I want to tell you developers that I admire your work. I first > downloaded vtiger a few days ago, for customer relationship management > at my uncles little ceramic factory, and I was amazed, but after I > showed it to him, well, it seems that it is too much for what my uncle > wants. * Gopal:* From the Security settings module, you can disable modules/fields that are not required. Please get back to me if you need any further clarifications. > I love PHP, and I thought that I could minimize it to what at this > moment I need, and in near future add more AJAX to it. I know that may > differ a lot from what vtiger golas might be, therefore I want to > start a new project at sourceforge.net based > on vtigerCRM 5. * Gopal:* Down the road, we are planning to make vtiger CRM - fully customizable so that business users configure the vtiger system instead of hacking the code. Could you please post your goals, so that we will cross-check our road map and let you know our position? > I don't understand to much about Open Source Licencing restrictions > and related stuff, so please excuse my ignorance. My question are: * Gopal:* vtiger CRM code base contains our _*own contributions*_ and many third-party packages. Our own contributions are released under _vtiger Public License (based on Mozilla Public License)_. Please refer to the following URL for details about licenses of third-party packages: http://wiki.vtiger.com/index.php/Third_Party_Software > > Can I start a new project at sourceforge based on vtiger? * Gopal:* In general there are no issues in forking open source projects, provided you are not violating the Open Source license of your predecessor. > If so, Would I have to cover it under some other new license type? *Gopal:* Release your contributions under some Open Source license which meets your requirements. > Do I need some permit from vtiger team to start such project? * Gopal:* _vtiger CRM code base_ is 100% open source by spirit. Hence you may not require special permission from our side. > I know about removing logos because of trademarks, what else do I have > to remove? * > * * Gopal:* Kindly review the vtiger and other third-party licenses with your Legal adviser (council) before modifying back-end/front-end code base. On a separate note, our community is actively participating in vtiger development. Most of the community members (developers/testers/writers/translators) are directly contributing to the core code base (For example: PostgreSQL & DMS branches in our SVN). http://vtiger.fosslabs.com We are also encouraging many add-on projects based on vtiger CRM, which cater to the need of user-specific requirements. For more details, please refer to our vtigerForge: http://vtigerforge.com Best wishes, Gopal (vtiger - Team Member) > > Well that's it for now, I will continue on my "trying to understand > vtiger's code" task, so I will probably have some questions related to > developing in short. > > Thank you very much, > > > Jorge > ------------------------------------------------------------------------ > > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20070502/48cab81f/attachment.html From jens at Strawberry.COM Tue May 1 23:20:57 2007 From: jens at Strawberry.COM (Jens Hamisch) Date: Wed, 2 May 2007 08:20:57 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070501200552.GC26224@nibiru.local>; from Enrico Weigelt on Tue, May 01, 2007 at 10:05:52PM +0200 References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> Message-ID: <20070502082057.D16394@Strawberry.COM> Hi, I already did a port to postgresql and have contributed my patches to Don and Ritchie so far. I do not agree that the $adb->query_results are broken as I'm running on postgresql since 5.0rc1 ... Jens On Tue, May 01, 2007 at 10:05:52PM +0200, Enrico Weigelt wrote: > * Jorge Torres schrieb: > > Hi, > > > Can you send me some of your todo list, so I can check what > > I'm capable of helping with? > > The most important, for now, is to replace all the $adb->query_result() > calls, since a) it does not work with postgresql (adodb brokenness) > and b) it's an huge resource waster. > > > That minimized branch you mentioned, would it still support MySQL? > > Yep. I don't intend to drop it. > > > At this moment, I'm working on changing the pop-up windows, for WebWM > > windows, anyhow I will prepare a todo list I have in mind, so you get to see > > where we can join forces. > > Ok. > > > cu > -- > --------------------------------------------------------------------- > Enrico Weigelt == metux IT service > > phone: +49 36207 519931 www: http://www.metux.de/ > fax: +49 36207 519932 email: contact at metux.de > cellphone: +49 174 7066481 > --------------------------------------------------------------------- > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > --------------------------------------------------------------------- > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com -- -------------------------------------------------------------------------------- s t r a w b e r r y e d v - s y s t e m e g m b h SSSSSSSSS Am Flosskanal 7 Jens Hamisch SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO SSSSS-----SSSSS ---SSSSS--------- fon (+49 8171) 41805-0 -----SSSSSSS----- fax (+49 8171) 41805-59 ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com SSSSS-----SSSSS mobil: (+49 172) 8104162 SSSSSSSSSSSSS Geschaeftsfuehrer/CEO SSSSSSSSS Jens Hamisch a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 From jens at Strawberry.COM Tue May 1 23:21:30 2007 From: jens at Strawberry.COM (Jens Hamisch) Date: Wed, 2 May 2007 08:21:30 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <8ccbff060705011806h329d10afwfb63c5ebd56b1a9c@mail.gmail.com>; from Dome Charoenyost on Wed, May 02, 2007 at 08:06:13AM +0700 References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <8ccbff060705011806h329d10afwfb63c5ebd56b1a9c@mail.gmail.com> Message-ID: <20070502082130.E16394@Strawberry.COM> You may use the 5.1_jens branch which is working. Jens On Wed, May 02, 2007 at 08:06:13AM +0700, Dome Charoenyost wrote: > What's status of your poetgresql branch ? > > Can i test ? > > Dome C. > > > On 5/2/07, Enrico Weigelt wrote: > > * Jorge Torres schrieb: > > > > Hi, > > > > > Can you send me some of your todo list, so I can check what > > > I'm capable of helping with? > > > > The most important, for now, is to replace all the $adb->query_result() > > calls, since a) it does not work with postgresql (adodb brokenness) > > and b) it's an huge resource waster. > > > > > That minimized branch you mentioned, would it still support MySQL? > > > > Yep. I don't intend to drop it. > > > > > At this moment, I'm working on changing the pop-up windows, for WebWM > > > windows, anyhow I will prepare a todo list I have in mind, so you get to see > > > where we can join forces. > > > > Ok. > > > > > > cu > > -- > > --------------------------------------------------------------------- > > Enrico Weigelt == metux IT service > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > fax: +49 36207 519932 email: contact at metux.de > > cellphone: +49 174 7066481 > > --------------------------------------------------------------------- > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > --------------------------------------------------------------------- > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com -- -------------------------------------------------------------------------------- s t r a w b e r r y e d v - s y s t e m e g m b h SSSSSSSSS Am Flosskanal 7 Jens Hamisch SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO SSSSS-----SSSSS ---SSSSS--------- fon (+49 8171) 41805-0 -----SSSSSSS----- fax (+49 8171) 41805-59 ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com SSSSS-----SSSSS mobil: (+49 172) 8104162 SSSSSSSSSSSSS Geschaeftsfuehrer/CEO SSSSSSSSS Jens Hamisch a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 From joe at tsolucio.com Wed May 2 03:35:59 2007 From: joe at tsolucio.com (Joe Bordes) Date: Wed, 02 May 2007 12:35:59 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <4638114D.5010303@vtiger.com> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <4638114D.5010303@vtiger.com> Message-ID: <1178102159.31989.24.camel@joesunix.int> Hi, I read this thread and I just keep asking myself: what am I doing wrong? You guys have branches and are participating. I have been asking to help for a long time now and I am just being ignored. I really would like to help and work together. Joe TSolucio El mi?, 02-05-2007 a las 09:49 +0530, Gopal escribi?: > Hi Jorge, > > Thanks for your interest in vtiger CRM project. > > Please see my response below (in blue color) > > Jorge Torres wrote: > > Hi everyone, > > > > First I want to tell you developers that I admire your work. I first > > downloaded vtiger a few days ago, for customer relationship > > management at my uncles little ceramic factory, and I was amazed, > > but after I showed it to him, well, it seems that it is too much for > > what my uncle wants. > > Gopal: From the Security settings module, you can disable > modules/fields that are not required. Please get back to me if you > need any further clarifications. > > I love PHP, and I thought that I could minimize it to what at this > > moment I need, and in near future add more AJAX to it. I know that > > may differ a lot from what vtiger golas might be, therefore I want > > to start a new project at sourceforge.net based on vtigerCRM 5. > > Gopal: Down the road, we are planning to make vtiger CRM - fully > customizable so that business users configure the vtiger system > instead of hacking the code. Could you please post your goals, so > that we will cross-check our road map and let you know our position? > > I don't understand to much about Open Source Licencing restrictions > > and related stuff, so please excuse my ignorance. My question are: > > Gopal: vtiger CRM code base contains our own contributions and many > third-party packages. Our own contributions are released under vtiger > Public License (based on Mozilla Public License). Please refer to the > following URL for details about licenses of third-party packages: > > http://wiki.vtiger.com/index.php/Third_Party_Software > > > > Can I start a new project at sourceforge based on vtiger? > > Gopal: In general there are no issues in forking open source projects, > provided you are not violating the Open Source license of your > predecessor. > > If so, Would I have to cover it under some other new license type? > Gopal: Release your contributions under some Open Source license which > meets your requirements. > > Do I need some permit from vtiger team to start such project? > > Gopal: vtiger CRM code base is 100% open source by spirit. Hence you > may not require special permission from our side. > > I know about removing logos because of trademarks, what else do I > > have to remove? > > Gopal: Kindly review the vtiger and other third-party licenses with > your Legal adviser (council) before modifying back-end/front-end code > base. > > On a separate note, our community is actively participating in vtiger > development. Most of the community members > (developers/testers/writers/translators) are directly contributing to > the core code base (For example: PostgreSQL & DMS branches in our > SVN). > > http://vtiger.fosslabs.com > > We are also encouraging many add-on projects based on vtiger CRM, > which cater to the need of user-specific requirements. For more > details, please refer to our vtigerForge: > > http://vtigerforge.com > > Best wishes, > Gopal > (vtiger - Team Member) > > > > Well that's it for now, I will continue on my "trying to understand > > vtiger's code" task, so I will probably have some questions related > > to developing in short. > > > > Thank you very much, > > > > > > Jorge > > > > ____________________________________________________________________ > > > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com From weigelt at metux.de Wed May 2 03:56:24 2007 From: weigelt at metux.de (Enrico Weigelt) Date: Wed, 2 May 2007 12:56:24 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <8ccbff060705011806h329d10afwfb63c5ebd56b1a9c@mail.gmail.com> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <8ccbff060705011806h329d10afwfb63c5ebd56b1a9c@mail.gmail.com> Message-ID: <20070502105624.GA5311@nibiru.local> * Dome Charoenyost schrieb: > What's status of your poetgresql branch ? Work is still in progress. > Can i test ? I'll try to get some patches ready today. Or should I upload to SVN (need some short howto, I'm not really expierenced w/ svn) ? cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service phone: +49 36207 519931 www: http://www.metux.de/ fax: +49 36207 519932 email: contact at metux.de cellphone: +49 174 7066481 --------------------------------------------------------------------- -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- --------------------------------------------------------------------- From weigelt at metux.de Wed May 2 04:13:36 2007 From: weigelt at metux.de (Enrico Weigelt) Date: Wed, 2 May 2007 13:13:36 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070502082057.D16394@Strawberry.COM> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> Message-ID: <20070502111336.GB5311@nibiru.local> * Jens Hamisch schrieb: Hi, > I already did a port to postgresql and have contributed my patches to > Don and Ritchie so far. I do not agree that the $adb->query_results are > broken as I'm running on postgresql since 5.0rc1 ... well, I can only speak for the latest release and my trunk checkout of last week. a) several things in schema create needed to be fixed b) schema update (ie. ALTER TABLE ...) was totally broken c) the adodb Move() method was completely missing in the postgres driver And the $adb->query_results() thing: Well, it's and really bad idea (even if pgsql->Move() would work). Too much complexity in- and outside, too long codepathes, too inefficient. I've introduced some new query functions: * $adb->run_query_allrecords($query) -> returns the result in an array/list records (associative arrays) * $adb->run_query_record($query) -> returns only the first record. * $adb->run_query_field($query,$field) -> returns given field from the first record * $adb->run_query_list($query,$field) -> returns an list of the values from given field. Now I'm in the process of rewriting the calls to query_result() to an appropriate of the new functions. cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service phone: +49 36207 519931 www: http://www.metux.de/ fax: +49 36207 519932 email: contact at metux.de cellphone: +49 174 7066481 --------------------------------------------------------------------- -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- --------------------------------------------------------------------- From jens at Strawberry.COM Wed May 2 06:24:47 2007 From: jens at Strawberry.COM (Jens Hamisch) Date: Wed, 2 May 2007 15:24:47 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070502111336.GB5311@nibiru.local>; from Enrico Weigelt on Wed, May 02, 2007 at 01:13:36PM +0200 References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <20070502111336.GB5311@nibiru.local> Message-ID: <20070502152447.A6085@Strawberry.COM> Hi, please have a look at the 5.1_jens branch at first! This is a 5.0.3 release sucessfully running on postgresql. This version is stable. The database fixes were introduced in an early 5.0 prerelease. I'm running vtiger on postgres since then. Part of the patches were already implemented in 5.0GA. The rest was posted to Richie/Don about 3 weeks ago. JenS On Wed, May 02, 2007 at 01:13:36PM +0200, Enrico Weigelt wrote: > * Jens Hamisch schrieb: > > Hi, > > > I already did a port to postgresql and have contributed my patches to > > Don and Ritchie so far. I do not agree that the $adb->query_results are > > broken as I'm running on postgresql since 5.0rc1 ... > > well, I can only speak for the latest release and my trunk checkout > of last week. > > a) several things in schema create needed to be fixed > b) schema update (ie. ALTER TABLE ...) was totally broken > c) the adodb Move() method was completely missing in the postgres driver > > And the $adb->query_results() thing: > Well, it's and really bad idea (even if pgsql->Move() would work). > Too much complexity in- and outside, too long codepathes, too inefficient. > > I've introduced some new query functions: > > * $adb->run_query_allrecords($query) > -> returns the result in an array/list records (associative arrays) > > * $adb->run_query_record($query) > -> returns only the first record. > > * $adb->run_query_field($query,$field) > -> returns given field from the first record > > * $adb->run_query_list($query,$field) > -> returns an list of the values from given field. > > Now I'm in the process of rewriting the calls to query_result() > to an appropriate of the new functions. > > > cu > -- > --------------------------------------------------------------------- > Enrico Weigelt == metux IT service > > phone: +49 36207 519931 www: http://www.metux.de/ > fax: +49 36207 519932 email: contact at metux.de > cellphone: +49 174 7066481 > --------------------------------------------------------------------- > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > --------------------------------------------------------------------- > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com -- -------------------------------------------------------------------------------- s t r a w b e r r y e d v - s y s t e m e g m b h SSSSSSSSS Am Flosskanal 7 Jens Hamisch SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO SSSSS-----SSSSS ---SSSSS--------- fon (+49 8171) 41805-0 -----SSSSSSS----- fax (+49 8171) 41805-59 ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com SSSSS-----SSSSS mobil: (+49 172) 8104162 SSSSSSSSSSSSS Geschaeftsfuehrer/CEO SSSSSSSSS Jens Hamisch a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 From dome at tel.co.th Wed May 2 06:45:38 2007 From: dome at tel.co.th (Dome Charoenyost) Date: Wed, 2 May 2007 20:45:38 +0700 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070502152447.A6085@Strawberry.COM> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <20070502111336.GB5311@nibiru.local> <20070502152447.A6085@Strawberry.COM> Message-ID: <8ccbff060705020645h295a1815x12d8089d2b01cb9c@mail.gmail.com> i still found error on 5.1_jens Fatal error: Call to a member function on a non-object in /home/ip/crmpgsql/include/database/PearDatabase.php on line 441 postgresql 8.1 php4.4 Debian etch Dome C. On 5/2/07, Jens Hamisch wrote: > > Hi, > > please have a look at the 5.1_jens branch at first! This is > a 5.0.3 release sucessfully running on postgresql. > This version is stable. The database fixes were introduced in > an early 5.0 prerelease. I'm running vtiger on postgres since > then. > > Part of the patches were already implemented in 5.0GA. The rest > was posted to Richie/Don about 3 weeks ago. > > JenS > > On Wed, May 02, 2007 at 01:13:36PM +0200, Enrico Weigelt wrote: > > * Jens Hamisch schrieb: > > > > Hi, > > > > > I already did a port to postgresql and have contributed my patches to > > > Don and Ritchie so far. I do not agree that the $adb->query_results are > > > broken as I'm running on postgresql since 5.0rc1 ... > > > > well, I can only speak for the latest release and my trunk checkout > > of last week. > > > > a) several things in schema create needed to be fixed > > b) schema update (ie. ALTER TABLE ...) was totally broken > > c) the adodb Move() method was completely missing in the postgres driver > > > > And the $adb->query_results() thing: > > Well, it's and really bad idea (even if pgsql->Move() would work). > > Too much complexity in- and outside, too long codepathes, too inefficient. > > > > I've introduced some new query functions: > > > > * $adb->run_query_allrecords($query) > > -> returns the result in an array/list records (associative arrays) > > > > * $adb->run_query_record($query) > > -> returns only the first record. > > > > * $adb->run_query_field($query,$field) > > -> returns given field from the first record > > > > * $adb->run_query_list($query,$field) > > -> returns an list of the values from given field. > > > > Now I'm in the process of rewriting the calls to query_result() > > to an appropriate of the new functions. > > > > > > cu > > -- > > --------------------------------------------------------------------- > > Enrico Weigelt == metux IT service > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > fax: +49 36207 519932 email: contact at metux.de > > cellphone: +49 174 7066481 > > --------------------------------------------------------------------- > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > --------------------------------------------------------------------- > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > -- > > -------------------------------------------------------------------------------- > > s t r a w b e r r y e d v - s y s t e m e g m b h > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > SSSSS-----SSSSS > ---SSSSS--------- fon (+49 8171) 41805-0 > -----SSSSSSS----- fax (+49 8171) 41805-59 > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > SSSSS-----SSSSS mobil: (+49 172) 8104162 > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > SSSSSSSSS Jens Hamisch > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > From dome at tel.co.th Wed May 2 06:46:16 2007 From: dome at tel.co.th (Dome Charoenyost) Date: Wed, 2 May 2007 20:46:16 +0700 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070502105624.GA5311@nibiru.local> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <8ccbff060705011806h329d10afwfb63c5ebd56b1a9c@mail.gmail.com> <20070502105624.GA5311@nibiru.local> Message-ID: <8ccbff060705020646h4c848925k30338b574e6c2d60@mail.gmail.com> Please send me patch Thanks. Dome C. On 5/2/07, Enrico Weigelt wrote: > * Dome Charoenyost schrieb: > > What's status of your poetgresql branch ? > > Work is still in progress. > > > Can i test ? > > I'll try to get some patches ready today. > > Or should I upload to SVN (need some short howto, I'm not > really expierenced w/ svn) ? > > > cu > -- > --------------------------------------------------------------------- > Enrico Weigelt == metux IT service > > phone: +49 36207 519931 www: http://www.metux.de/ > fax: +49 36207 519932 email: contact at metux.de > cellphone: +49 174 7066481 > --------------------------------------------------------------------- > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > --------------------------------------------------------------------- > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > From jens at Strawberry.COM Wed May 2 07:37:37 2007 From: jens at Strawberry.COM (Jens Hamisch) Date: Wed, 2 May 2007 16:37:37 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <8ccbff060705020645h295a1815x12d8089d2b01cb9c@mail.gmail.com>; from Dome Charoenyost on Wed, May 02, 2007 at 08:45:38PM +0700 References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <20070502111336.GB5311@nibiru.local> <20070502152447.A6085@Strawberry.COM> <8ccbff060705020645h295a1815x12d8089d2b01cb9c@mail.gmail.com> Message-ID: <20070502163737.B6085@Strawberry.COM> Hi, I'm running php 5.1.4. According to the installation manual, 5.0.x thru 5.2.x is supported only. Jens On Wed, May 02, 2007 at 08:45:38PM +0700, Dome Charoenyost wrote: > i still found error on 5.1_jens > Fatal error: Call to a member function on a non-object in > /home/ip/crmpgsql/include/database/PearDatabase.php on line 441 > > postgresql 8.1 > php4.4 > > Debian etch > > Dome C. > > > > On 5/2/07, Jens Hamisch wrote: > > > > Hi, > > > > please have a look at the 5.1_jens branch at first! This is > > a 5.0.3 release sucessfully running on postgresql. > > This version is stable. The database fixes were introduced in > > an early 5.0 prerelease. I'm running vtiger on postgres since > > then. > > > > Part of the patches were already implemented in 5.0GA. The rest > > was posted to Richie/Don about 3 weeks ago. > > > > JenS > > > > On Wed, May 02, 2007 at 01:13:36PM +0200, Enrico Weigelt wrote: > > > * Jens Hamisch schrieb: > > > > > > Hi, > > > > > > > I already did a port to postgresql and have contributed my patches to > > > > Don and Ritchie so far. I do not agree that the $adb->query_results are > > > > broken as I'm running on postgresql since 5.0rc1 ... > > > > > > well, I can only speak for the latest release and my trunk checkout > > > of last week. > > > > > > a) several things in schema create needed to be fixed > > > b) schema update (ie. ALTER TABLE ...) was totally broken > > > c) the adodb Move() method was completely missing in the postgres driver > > > > > > And the $adb->query_results() thing: > > > Well, it's and really bad idea (even if pgsql->Move() would work). > > > Too much complexity in- and outside, too long codepathes, too inefficient. > > > > > > I've introduced some new query functions: > > > > > > * $adb->run_query_allrecords($query) > > > -> returns the result in an array/list records (associative arrays) > > > > > > * $adb->run_query_record($query) > > > -> returns only the first record. > > > > > > * $adb->run_query_field($query,$field) > > > -> returns given field from the first record > > > > > > * $adb->run_query_list($query,$field) > > > -> returns an list of the values from given field. > > > > > > Now I'm in the process of rewriting the calls to query_result() > > > to an appropriate of the new functions. > > > > > > > > > cu > > > -- > > > --------------------------------------------------------------------- > > > Enrico Weigelt == metux IT service > > > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > > fax: +49 36207 519932 email: contact at metux.de > > > cellphone: +49 174 7066481 > > > --------------------------------------------------------------------- > > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > > --------------------------------------------------------------------- > > > _______________________________________________ > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > -- > > > > -------------------------------------------------------------------------------- > > > > s t r a w b e r r y e d v - s y s t e m e g m b h > > > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > > SSSSS-----SSSSS > > ---SSSSS--------- fon (+49 8171) 41805-0 > > -----SSSSSSS----- fax (+49 8171) 41805-59 > > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > > SSSSS-----SSSSS mobil: (+49 172) 8104162 > > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > > SSSSSSSSS Jens Hamisch > > > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com -- -------------------------------------------------------------------------------- s t r a w b e r r y e d v - s y s t e m e g m b h SSSSSSSSS Am Flosskanal 7 Jens Hamisch SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO SSSSS-----SSSSS ---SSSSS--------- fon (+49 8171) 41805-0 -----SSSSSSS----- fax (+49 8171) 41805-59 ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com SSSSS-----SSSSS mobil: (+49 172) 8104162 SSSSSSSSSSSSS Geschaeftsfuehrer/CEO SSSSSSSSS Jens Hamisch a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 From dome at tel.co.th Wed May 2 08:22:52 2007 From: dome at tel.co.th (Dome Charoenyost) Date: Wed, 2 May 2007 22:22:52 +0700 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070502163737.B6085@Strawberry.COM> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <20070502111336.GB5311@nibiru.local> <20070502152447.A6085@Strawberry.COM> <8ccbff060705020645h295a1815x12d8089d2b01cb9c@mail.gmail.com> <20070502163737.B6085@Strawberry.COM> Message-ID: <8ccbff060705020822h249304bajc8f6af8bf00590eb@mail.gmail.com> I'm test on php 5.2 found object to string error ( in log->debug) when create new contact Call to a member function Move() on a non-object in /var/www/crmpgsql/include/database/PearDatabase.php on line 441 Dome C. On 5/2/07, Jens Hamisch wrote: > Hi, > > I'm running php 5.1.4. According to the installation manual, 5.0.x thru > 5.2.x is supported only. > > Jens > > > On Wed, May 02, 2007 at 08:45:38PM +0700, Dome Charoenyost wrote: > > i still found error on 5.1_jens > > Fatal error: Call to a member function on a non-object in > > /home/ip/crmpgsql/include/database/PearDatabase.php on line 441 > > > > postgresql 8.1 > > php4.4 > > > > Debian etch > > > > Dome C. > > > > > > > > On 5/2/07, Jens Hamisch wrote: > > > > > > Hi, > > > > > > please have a look at the 5.1_jens branch at first! This is > > > a 5.0.3 release sucessfully running on postgresql. > > > This version is stable. The database fixes were introduced in > > > an early 5.0 prerelease. I'm running vtiger on postgres since > > > then. > > > > > > Part of the patches were already implemented in 5.0GA. The rest > > > was posted to Richie/Don about 3 weeks ago. > > > > > > JenS > > > > > > On Wed, May 02, 2007 at 01:13:36PM +0200, Enrico Weigelt wrote: > > > > * Jens Hamisch schrieb: > > > > > > > > Hi, > > > > > > > > > I already did a port to postgresql and have contributed my patches to > > > > > Don and Ritchie so far. I do not agree that the $adb->query_results are > > > > > broken as I'm running on postgresql since 5.0rc1 ... > > > > > > > > well, I can only speak for the latest release and my trunk checkout > > > > of last week. > > > > > > > > a) several things in schema create needed to be fixed > > > > b) schema update (ie. ALTER TABLE ...) was totally broken > > > > c) the adodb Move() method was completely missing in the postgres driver > > > > > > > > And the $adb->query_results() thing: > > > > Well, it's and really bad idea (even if pgsql->Move() would work). > > > > Too much complexity in- and outside, too long codepathes, too inefficient. > > > > > > > > I've introduced some new query functions: > > > > > > > > * $adb->run_query_allrecords($query) > > > > -> returns the result in an array/list records (associative arrays) > > > > > > > > * $adb->run_query_record($query) > > > > -> returns only the first record. > > > > > > > > * $adb->run_query_field($query,$field) > > > > -> returns given field from the first record > > > > > > > > * $adb->run_query_list($query,$field) > > > > -> returns an list of the values from given field. > > > > > > > > Now I'm in the process of rewriting the calls to query_result() > > > > to an appropriate of the new functions. > > > > > > > > > > > > cu > > > > -- > > > > --------------------------------------------------------------------- > > > > Enrico Weigelt == metux IT service > > > > > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > > > fax: +49 36207 519932 email: contact at metux.de > > > > cellphone: +49 174 7066481 > > > > --------------------------------------------------------------------- > > > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > > > --------------------------------------------------------------------- > > > > _______________________________________________ > > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > > > -- > > > > > > -------------------------------------------------------------------------------- > > > > > > s t r a w b e r r y e d v - s y s t e m e g m b h > > > > > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > > > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > > > SSSSS-----SSSSS > > > ---SSSSS--------- fon (+49 8171) 41805-0 > > > -----SSSSSSS----- fax (+49 8171) 41805-59 > > > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > > > SSSSS-----SSSSS mobil: (+49 172) 8104162 > > > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > > > SSSSSSSSS Jens Hamisch > > > > > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > > > _______________________________________________ > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > -- > > -------------------------------------------------------------------------------- > > s t r a w b e r r y e d v - s y s t e m e g m b h > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > SSSSS-----SSSSS > ---SSSSS--------- fon (+49 8171) 41805-0 > -----SSSSSSS----- fax (+49 8171) 41805-59 > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > SSSSS-----SSSSS mobil: (+49 172) 8104162 > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > SSSSSSSSS Jens Hamisch > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > From jens at Strawberry.COM Wed May 2 09:00:05 2007 From: jens at Strawberry.COM (Jens Hamisch) Date: Wed, 2 May 2007 18:00:05 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <8ccbff060705020822h249304bajc8f6af8bf00590eb@mail.gmail.com>; from Dome Charoenyost on Wed, May 02, 2007 at 10:22:52PM +0700 References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <20070502111336.GB5311@nibiru.local> <20070502152447.A6085@Strawberry.COM> <8ccbff060705020645h295a1815x12d8089d2b01cb9c@mail.gmail.com> <20070502163737.B6085@Strawberry.COM> <8ccbff060705020822h249304bajc8f6af8bf00590eb@mail.gmail.com> Message-ID: <20070502180005.A6711@Strawberry.COM> Hi Richie, didn't Mr. Priebsch tell us something about name space modifications between php 5.1.x and 5.2.0? In fact the version running at my side (php 5.1.4) seems run into problems on 5.2.0 ... Jens On Wed, May 02, 2007 at 10:22:52PM +0700, Dome Charoenyost wrote: > I'm test on php 5.2 found object to string error ( in log->debug) > > when create new contact > Call to a member function Move() on a non-object in > /var/www/crmpgsql/include/database/PearDatabase.php on line 441 > > Dome C. > > On 5/2/07, Jens Hamisch wrote: > > Hi, > > > > I'm running php 5.1.4. According to the installation manual, 5.0.x thru > > 5.2.x is supported only. > > > > Jens > > > > > > On Wed, May 02, 2007 at 08:45:38PM +0700, Dome Charoenyost wrote: > > > i still found error on 5.1_jens > > > Fatal error: Call to a member function on a non-object in > > > /home/ip/crmpgsql/include/database/PearDatabase.php on line 441 > > > > > > postgresql 8.1 > > > php4.4 > > > > > > Debian etch > > > > > > Dome C. > > > > > > > > > > > > On 5/2/07, Jens Hamisch wrote: > > > > > > > > Hi, > > > > > > > > please have a look at the 5.1_jens branch at first! This is > > > > a 5.0.3 release sucessfully running on postgresql. > > > > This version is stable. The database fixes were introduced in > > > > an early 5.0 prerelease. I'm running vtiger on postgres since > > > > then. > > > > > > > > Part of the patches were already implemented in 5.0GA. The rest > > > > was posted to Richie/Don about 3 weeks ago. > > > > > > > > JenS > > > > > > > > On Wed, May 02, 2007 at 01:13:36PM +0200, Enrico Weigelt wrote: > > > > > * Jens Hamisch schrieb: > > > > > > > > > > Hi, > > > > > > > > > > > I already did a port to postgresql and have contributed my patches to > > > > > > Don and Ritchie so far. I do not agree that the $adb->query_results are > > > > > > broken as I'm running on postgresql since 5.0rc1 ... > > > > > > > > > > well, I can only speak for the latest release and my trunk checkout > > > > > of last week. > > > > > > > > > > a) several things in schema create needed to be fixed > > > > > b) schema update (ie. ALTER TABLE ...) was totally broken > > > > > c) the adodb Move() method was completely missing in the postgres driver > > > > > > > > > > And the $adb->query_results() thing: > > > > > Well, it's and really bad idea (even if pgsql->Move() would work). > > > > > Too much complexity in- and outside, too long codepathes, too inefficient. > > > > > > > > > > I've introduced some new query functions: > > > > > > > > > > * $adb->run_query_allrecords($query) > > > > > -> returns the result in an array/list records (associative arrays) > > > > > > > > > > * $adb->run_query_record($query) > > > > > -> returns only the first record. > > > > > > > > > > * $adb->run_query_field($query,$field) > > > > > -> returns given field from the first record > > > > > > > > > > * $adb->run_query_list($query,$field) > > > > > -> returns an list of the values from given field. > > > > > > > > > > Now I'm in the process of rewriting the calls to query_result() > > > > > to an appropriate of the new functions. > > > > > > > > > > > > > > > cu > > > > > -- > > > > > --------------------------------------------------------------------- > > > > > Enrico Weigelt == metux IT service > > > > > > > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > > > > fax: +49 36207 519932 email: contact at metux.de > > > > > cellphone: +49 174 7066481 > > > > > --------------------------------------------------------------------- > > > > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > > > > --------------------------------------------------------------------- > > > > > _______________________________________________ > > > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > > > > > -- > > > > > > > > -------------------------------------------------------------------------------- > > > > > > > > s t r a w b e r r y e d v - s y s t e m e g m b h > > > > > > > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > > > > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > > > > SSSSS-----SSSSS > > > > ---SSSSS--------- fon (+49 8171) 41805-0 > > > > -----SSSSSSS----- fax (+49 8171) 41805-59 > > > > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > > > > SSSSS-----SSSSS mobil: (+49 172) 8104162 > > > > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > > > > SSSSSSSSS Jens Hamisch > > > > > > > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > > > > _______________________________________________ > > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > > > > _______________________________________________ > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > -- > > > > -------------------------------------------------------------------------------- > > > > s t r a w b e r r y e d v - s y s t e m e g m b h > > > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > > SSSSS-----SSSSS > > ---SSSSS--------- fon (+49 8171) 41805-0 > > -----SSSSSSS----- fax (+49 8171) 41805-59 > > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > > SSSSS-----SSSSS mobil: (+49 172) 8104162 > > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > > SSSSSSSSS Jens Hamisch > > > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com -- -------------------------------------------------------------------------------- s t r a w b e r r y e d v - s y s t e m e g m b h SSSSSSSSS Am Flosskanal 7 Jens Hamisch SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO SSSSS-----SSSSS ---SSSSS--------- fon (+49 8171) 41805-0 -----SSSSSSS----- fax (+49 8171) 41805-59 ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com SSSSS-----SSSSS mobil: (+49 172) 8104162 SSSSSSSSSSSSS Geschaeftsfuehrer/CEO SSSSSSSSS Jens Hamisch a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 From weigelt at metux.de Wed May 2 09:31:09 2007 From: weigelt at metux.de (Enrico Weigelt) Date: Wed, 2 May 2007 18:31:09 +0200 Subject: [Vtigercrm-developers] insert data function Message-ID: <20070502163109.GA19391@nibiru.local> Hi folks, JFYI: I've added an new function run_insert_data($table,$data) to the PearDatabase lass ($adb). It handles the cases where simply one record is inserted to some table. The sql query is built from an associative array (in fact this is done by sql_insert_data()), executed and if an error is detected, an error is thrown. I'm going to submit an patch this afternoon. cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service phone: +49 36207 519931 www: http://www.metux.de/ fax: +49 36207 519932 email: contact at metux.de cellphone: +49 174 7066481 --------------------------------------------------------------------- -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- --------------------------------------------------------------------- From jorge.torres.maldonado at gmail.com Wed May 2 12:13:25 2007 From: jorge.torres.maldonado at gmail.com (Jorge Torres) Date: Wed, 2 May 2007 14:13:25 -0500 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070502082057.D16394@Strawberry.COM> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> Message-ID: <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> Hi, Since it is now clear that postgres is supported, the only thing would be about Enrico's opinion of adb->query_results being resource wasting, which is very important regardless of mysql or postgres use, Enrico, what are you doing instead of using the query_results method? About the other thing here is a todo list which could possibly be common with vtiger's: - Use WebWM (webwm.sourceforge.net), instead of porpup windows which are blocked by internet explorer and sometimes firefox, also use WebWM for virtual windows, such as the ones in editing custom fields. - I don't know why imap email doest work, I get the message that email should be configured, even if it is in fact configured, well so i will try to fix that, + adding imap options to the Add user template, - DHTML Customizable pdf sheet creator for sales-orders and the others, - AJAX calendar refresh, and adding standard calendar view on a floating window. - Date field DHTML floating box. - Help DHTML widgets, which will soon be offered by the webwm framework. - Translation facility, probably a script that reads every lang file, and organizes it in a HTML form, and then form it regenerate the lang files, so language translation can be made from web, rather that getting into the code, + the fact of making it a lot more easier when adding new definitions and translating them to the other files. Well with that I think I have lot to play with for some time. Thank you, Jorge On 5/2/07, Jens Hamisch wrote: > > > Hi, > > I already did a port to postgresql and have contributed my patches to > Don and Ritchie so far. I do not agree that the $adb->query_results are > broken as I'm running on postgresql since 5.0rc1 ... > > Jens > > > On Tue, May 01, 2007 at 10:05:52PM +0200, Enrico Weigelt wrote: > > * Jorge Torres schrieb: > > > > Hi, > > > > > Can you send me some of your todo list, so I can check what > > > I'm capable of helping with? > > > > The most important, for now, is to replace all the $adb->query_result() > > calls, since a) it does not work with postgresql (adodb brokenness) > > and b) it's an huge resource waster. > > > > > That minimized branch you mentioned, would it still support MySQL? > > > > Yep. I don't intend to drop it. > > > > > At this moment, I'm working on changing the pop-up windows, for WebWM > > > windows, anyhow I will prepare a todo list I have in mind, so you get > to see > > > where we can join forces. > > > > Ok. > > > > > > cu > > -- > > --------------------------------------------------------------------- > > Enrico Weigelt == metux IT service > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > fax: +49 36207 519932 email: contact at metux.de > > cellphone: +49 174 7066481 > > --------------------------------------------------------------------- > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > --------------------------------------------------------------------- > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > -- > > > -------------------------------------------------------------------------------- > > s t r a w b e r r y e d v - s y s t e m e g m b h > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > SSSSS-----SSSSS > ---SSSSS--------- fon (+49 8171) 41805-0 > -----SSSSSSS----- fax (+49 8171) 41805-59 > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > SSSSS-----SSSSS mobil: (+49 172) 8104162 > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > SSSSSSSSS Jens Hamisch > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20070502/1c28fc7c/attachment.html From joe at tsolucio.com Wed May 2 12:37:14 2007 From: joe at tsolucio.com (Joe Bordes) Date: Wed, 02 May 2007 21:37:14 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> Message-ID: <4638E86A.70707@tsolucio.com> Hi Jorge, Jorge Torres escribi?: > Hi, > > Since it is now clear that postgres is supported, the only thing would > be about Enrico's opinion of adb->query_results being resource > wasting, which is very important regardless of mysql or postgres use, > Enrico, what are you doing instead of using the query_results method? > > About the other thing here is a todo list which could possibly be > common with vtiger's: > > - Use WebWM (webwm.sourceforge.net ), > instead of porpup windows which are blocked by internet explorer and > sometimes firefox, also use WebWM for virtual windows, such as the > ones in editing custom fields. > Really nice. Hope you can get somewhere. > - I don't know why imap email doest work, I get the message that email > should be configured, even if it is in fact configured, well so i will > try to fix that, + adding imap options to the Add user template, > > - DHTML Customizable pdf sheet creator for sales-orders and the others, > > - AJAX calendar refresh, and adding standard calendar view on a > floating window. > > - Date field DHTML floating box. > > - Help DHTML widgets, which will soon be offered by the webwm framework. > > - Translation facility, probably a script that reads every lang file, > and organizes it in a HTML form, and then form it regenerate the lang > files, so language translation can be made from web, rather that > getting into the code, + the fact of making it a lot more easier when > adding new definitions and translating them to the other files. > Try the Language Wizard in vtigerforge. This is what I use and I think it is a very good module, it does exactly what you are asking for. > Well with that I think I have lot to play with for some time. > > Thank you, > > Jorge > Joe TSolucio From jorge.torres.maldonado at gmail.com Wed May 2 12:59:12 2007 From: jorge.torres.maldonado at gmail.com (Jorge Torres) Date: Wed, 2 May 2007 14:59:12 -0500 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <4638E86A.70707@tsolucio.com> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> <4638E86A.70707@tsolucio.com> Message-ID: <530c7d700705021259r4d70223cmd6981af85d4d1360@mail.gmail.com> Thanks Joe, language module seems awesome On 5/2/07, Joe Bordes wrote: > > Hi Jorge, > > Jorge Torres escribi?: > > Hi, > > > > Since it is now clear that postgres is supported, the only thing would > > be about Enrico's opinion of adb->query_results being resource > > wasting, which is very important regardless of mysql or postgres use, > > Enrico, what are you doing instead of using the query_results method? > > > > About the other thing here is a todo list which could possibly be > > common with vtiger's: > > > > - Use WebWM (webwm.sourceforge.net ), > > instead of porpup windows which are blocked by internet explorer and > > sometimes firefox, also use WebWM for virtual windows, such as the > > ones in editing custom fields. > > > Really nice. Hope you can get somewhere. > > > - I don't know why imap email doest work, I get the message that email > > should be configured, even if it is in fact configured, well so i will > > try to fix that, + adding imap options to the Add user template, > > > > - DHTML Customizable pdf sheet creator for sales-orders and the others, > > > > - AJAX calendar refresh, and adding standard calendar view on a > > floating window. > > > > - Date field DHTML floating box. > > > > - Help DHTML widgets, which will soon be offered by the webwm framework. > > > > - Translation facility, probably a script that reads every lang file, > > and organizes it in a HTML form, and then form it regenerate the lang > > files, so language translation can be made from web, rather that > > getting into the code, + the fact of making it a lot more easier when > > adding new definitions and translating them to the other files. > > > Try the Language Wizard in vtigerforge. This is what I use and I think > it is a very good module, it does exactly what you are asking for. > > Well with that I think I have lot to play with for some time. > > > > Thank you, > > > > Jorge > > > Joe > TSolucio > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20070502/3ed19b0a/attachment-0001.htm From weigelt at metux.de Wed May 2 19:36:53 2007 From: weigelt at metux.de (Enrico Weigelt) Date: Thu, 3 May 2007 04:36:53 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> Message-ID: <20070503023653.GA29236@nibiru.local> * Jorge Torres schrieb: Hi, > Since it is now clear that postgres is supported, the only thing would be > about Enrico's opinion of adb->query_results being resource wasting, which > is very important regardless of mysql or postgres use, Enrico, what are > you doing instead of using the query_results method? As already said: introduced some new functions, which fetch either one record (run_query_record() and run_query_field()) or all records (run_query_allrecords() and run_query_list()) and simply return the data. There are several result types: a) just one scalar: -> run_query_field($query,$fieldname) --> returns an scalar b) just one record: -> run_query_record($query) --> returns an associative array c) an list of scalars -> run_query_list($query,$fieldname) --> returns an array/list of scalars d) an list of records: -> run_query_allreords($query) --> returns an array/list of ass. arrays cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service phone: +49 36207 519931 www: http://www.metux.de/ fax: +49 36207 519932 email: contact at metux.de cellphone: +49 174 7066481 --------------------------------------------------------------------- -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- --------------------------------------------------------------------- From gopals at vtiger.com Wed May 2 21:26:58 2007 From: gopals at vtiger.com (Gopal) Date: Thu, 03 May 2007 09:56:58 +0530 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <1178102159.31989.24.camel@joesunix.int> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <4638114D.5010303@vtiger.com> <1178102159.31989.24.camel@joesunix.int> Message-ID: <46396492.7010106@vtiger.com> Hi Joe, Sorry for the inconvenience. We don't have issues in providing separate branches for our developer community. Could you please send us your future development plans to philip at vtiger.com so that he will create branches based on your requirements. Regards, Gopal Joe Bordes wrote: > Hi, > > I read this thread and I just keep asking myself: > what am I doing wrong? > > You guys have branches and are participating. I have been asking to help > for a long time now and I am just being ignored. > > I really would like to help and work together. > > Joe > TSolucio > > El mi??, 02-05-2007 a las 09:49 +0530, Gopal escribi??: > >> Hi Jorge, >> >> Thanks for your interest in vtiger CRM project. >> >> Please see my response below (in blue color) >> >> Jorge Torres wrote: >> >>> Hi everyone, >>> >>> First I want to tell you developers that I admire your work. I first >>> downloaded vtiger a few days ago, for customer relationship >>> management at my uncles little ceramic factory, and I was amazed, >>> but after I showed it to him, well, it seems that it is too much for >>> what my uncle wants. >>> >> Gopal: From the Security settings module, you can disable >> modules/fields that are not required. Please get back to me if you >> need any further clarifications. >> >>> I love PHP, and I thought that I could minimize it to what at this >>> moment I need, and in near future add more AJAX to it. I know that >>> may differ a lot from what vtiger golas might be, therefore I want >>> to start a new project at sourceforge.net based on vtigerCRM 5. >>> >> Gopal: Down the road, we are planning to make vtiger CRM - fully >> customizable so that business users configure the vtiger system >> instead of hacking the code. Could you please post your goals, so >> that we will cross-check our road map and let you know our position? >> >>> I don't understand to much about Open Source Licencing restrictions >>> and related stuff, so please excuse my ignorance. My question are: >>> >> Gopal: vtiger CRM code base contains our own contributions and many >> third-party packages. Our own contributions are released under vtiger >> Public License (based on Mozilla Public License). Please refer to the >> following URL for details about licenses of third-party packages: >> >> http://wiki.vtiger.com/index.php/Third_Party_Software >> >>> Can I start a new project at sourceforge based on vtiger? >>> >> Gopal: In general there are no issues in forking open source projects, >> provided you are not violating the Open Source license of your >> predecessor. >> >>> If so, Would I have to cover it under some other new license type? >>> >> Gopal: Release your contributions under some Open Source license which >> meets your requirements. >> >>> Do I need some permit from vtiger team to start such project? >>> >> Gopal: vtiger CRM code base is 100% open source by spirit. Hence you >> may not require special permission from our side. >> >>> I know about removing logos because of trademarks, what else do I >>> have to remove? >>> >> Gopal: Kindly review the vtiger and other third-party licenses with >> your Legal adviser (council) before modifying back-end/front-end code >> base. >> >> On a separate note, our community is actively participating in vtiger >> development. Most of the community members >> (developers/testers/writers/translators) are directly contributing to >> the core code base (For example: PostgreSQL & DMS branches in our >> SVN). >> >> http://vtiger.fosslabs.com >> >> We are also encouraging many add-on projects based on vtiger CRM, >> which cater to the need of user-specific requirements. For more >> details, please refer to our vtigerForge: >> >> http://vtigerforge.com >> >> Best wishes, >> Gopal >> (vtiger - Team Member) >> >>> Well that's it for now, I will continue on my "trying to understand >>> vtiger's code" task, so I will probably have some questions related >>> to developing in short. >>> >>> Thank you very much, >>> >>> >>> Jorge >>> >>> ____________________________________________________________________ >>> >>> _______________________________________________ >>> Reach hundreds of potential candidates - http://jobs.vtiger.com >>> >> _______________________________________________ >> Reach hundreds of potential candidates - http://jobs.vtiger.com >> > > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20070503/f24f5451/attachment.html From jens at Strawberry.COM Wed May 2 23:54:27 2007 From: jens at Strawberry.COM (Jens Hamisch) Date: Thu, 3 May 2007 08:54:27 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070503023653.GA29236@nibiru.local>; from Enrico Weigelt on Thu, May 03, 2007 at 04:36:53AM +0200 References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> <20070503023653.GA29236@nibiru.local> Message-ID: <20070503085427.A9675@Strawberry.COM> Hi Enrico, my fixes adress syntactical postgres support only. However yours also seems to improove performance. Is there any chance to have both fixes implemented (@don,richie)? Jens On Thu, May 03, 2007 at 04:36:53AM +0200, Enrico Weigelt wrote: > * Jorge Torres schrieb: > > Hi, > > > Since it is now clear that postgres is supported, the only thing would be > > about Enrico's opinion of adb->query_results being resource wasting, which > > is very important regardless of mysql or postgres use, Enrico, what are > > you doing instead of using the query_results method? > > As already said: introduced some new functions, which fetch either > one record (run_query_record() and run_query_field()) or all records > (run_query_allrecords() and run_query_list()) and simply return the data. > > There are several result types: > > a) just one scalar: -> run_query_field($query,$fieldname) > --> returns an scalar > b) just one record: -> run_query_record($query) > --> returns an associative array > c) an list of scalars -> run_query_list($query,$fieldname) > --> returns an array/list of scalars > d) an list of records: -> run_query_allreords($query) > --> returns an array/list of ass. arrays > > cu > -- > --------------------------------------------------------------------- > Enrico Weigelt == metux IT service > > phone: +49 36207 519931 www: http://www.metux.de/ > fax: +49 36207 519932 email: contact at metux.de > cellphone: +49 174 7066481 > --------------------------------------------------------------------- > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > --------------------------------------------------------------------- > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com -- -------------------------------------------------------------------------------- s t r a w b e r r y e d v - s y s t e m e g m b h SSSSSSSSS Am Flosskanal 7 Jens Hamisch SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO SSSSS-----SSSSS ---SSSSS--------- fon (+49 8171) 41805-0 -----SSSSSSS----- fax (+49 8171) 41805-59 ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com SSSSS-----SSSSS mobil: (+49 172) 8104162 SSSSSSSSSSSSS Geschaeftsfuehrer/CEO SSSSSSSSS Jens Hamisch a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 From dome at tel.co.th Thu May 3 05:28:02 2007 From: dome at tel.co.th (Dome Charoenyost) Date: Thu, 3 May 2007 19:28:02 +0700 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070503085427.A9675@Strawberry.COM> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> <20070503023653.GA29236@nibiru.local> <20070503085427.A9675@Strawberry.COM> Message-ID: <8ccbff060705030528o2060726bubec16bac21a09e87@mail.gmail.com> Jens, I try to test your branch with lxampp 1.5.3a (php 5.1.4) found same error Fatal error: Call to a member function Move() on a non-object in /opt/lampp/htdocs/vtiger/include/database/PearDatabase.php on line 441 Please give me more information about php,postgresql version ? Dome C. On 5/3/07, Jens Hamisch wrote: > > Hi Enrico, > > my fixes adress syntactical postgres support only. However > yours also seems to improove performance. Is there any chance > to have both fixes implemented (@don,richie)? > > Jens > > > On Thu, May 03, 2007 at 04:36:53AM +0200, Enrico Weigelt wrote: > > * Jorge Torres schrieb: > > > > Hi, > > > > > Since it is now clear that postgres is supported, the only thing would be > > > about Enrico's opinion of adb->query_results being resource wasting, which > > > is very important regardless of mysql or postgres use, Enrico, what are > > > you doing instead of using the query_results method? > > > > As already said: introduced some new functions, which fetch either > > one record (run_query_record() and run_query_field()) or all records > > (run_query_allrecords() and run_query_list()) and simply return the data. > > > > There are several result types: > > > > a) just one scalar: -> run_query_field($query,$fieldname) > > --> returns an scalar > > b) just one record: -> run_query_record($query) > > --> returns an associative array > > c) an list of scalars -> run_query_list($query,$fieldname) > > --> returns an array/list of scalars > > d) an list of records: -> run_query_allreords($query) > > --> returns an array/list of ass. arrays > > > > cu > > -- > > --------------------------------------------------------------------- > > Enrico Weigelt == metux IT service > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > fax: +49 36207 519932 email: contact at metux.de > > cellphone: +49 174 7066481 > > --------------------------------------------------------------------- > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > --------------------------------------------------------------------- > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > -- > > -------------------------------------------------------------------------------- > > s t r a w b e r r y e d v - s y s t e m e g m b h > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > SSSSS-----SSSSS > ---SSSSS--------- fon (+49 8171) 41805-0 > -----SSSSSSS----- fax (+49 8171) 41805-59 > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > SSSSS-----SSSSS mobil: (+49 172) 8104162 > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > SSSSSSSSS Jens Hamisch > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > From jens at Strawberry.COM Thu May 3 06:40:04 2007 From: jens at Strawberry.COM (Jens Hamisch) Date: Thu, 3 May 2007 15:40:04 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <8ccbff060705030528o2060726bubec16bac21a09e87@mail.gmail.com>; from Dome Charoenyost on Thu, May 03, 2007 at 07:28:02PM +0700 References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> <20070503023653.GA29236@nibiru.local> <20070503085427.A9675@Strawberry.COM> <8ccbff060705030528o2060726bubec16bac21a09e87@mail.gmail.com> Message-ID: <20070503154004.D6711@Strawberry.COM> Hi, my port is running on Solaris 10, postgres 8.1.2, PHP 5.1.4 Jens On Thu, May 03, 2007 at 07:28:02PM +0700, Dome Charoenyost wrote: > Jens, > I try to test your branch with lxampp 1.5.3a (php 5.1.4) > found same error > Fatal error: Call to a member function Move() on a non-object in > /opt/lampp/htdocs/vtiger/include/database/PearDatabase.php on line 441 > > Please give me more information about php,postgresql version ? > > Dome C. > > On 5/3/07, Jens Hamisch wrote: > > > > Hi Enrico, > > > > my fixes adress syntactical postgres support only. However > > yours also seems to improove performance. Is there any chance > > to have both fixes implemented (@don,richie)? > > > > Jens > > > > > > On Thu, May 03, 2007 at 04:36:53AM +0200, Enrico Weigelt wrote: > > > * Jorge Torres schrieb: > > > > > > Hi, > > > > > > > Since it is now clear that postgres is supported, the only thing would be > > > > about Enrico's opinion of adb->query_results being resource wasting, which > > > > is very important regardless of mysql or postgres use, Enrico, what are > > > > you doing instead of using the query_results method? > > > > > > As already said: introduced some new functions, which fetch either > > > one record (run_query_record() and run_query_field()) or all records > > > (run_query_allrecords() and run_query_list()) and simply return the data. > > > > > > There are several result types: > > > > > > a) just one scalar: -> run_query_field($query,$fieldname) > > > --> returns an scalar > > > b) just one record: -> run_query_record($query) > > > --> returns an associative array > > > c) an list of scalars -> run_query_list($query,$fieldname) > > > --> returns an array/list of scalars > > > d) an list of records: -> run_query_allreords($query) > > > --> returns an array/list of ass. arrays > > > > > > cu > > > -- > > > --------------------------------------------------------------------- > > > Enrico Weigelt == metux IT service > > > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > > fax: +49 36207 519932 email: contact at metux.de > > > cellphone: +49 174 7066481 > > > --------------------------------------------------------------------- > > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > > --------------------------------------------------------------------- > > > _______________________________________________ > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > -- > > > > -------------------------------------------------------------------------------- > > > > s t r a w b e r r y e d v - s y s t e m e g m b h > > > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > > SSSSS-----SSSSS > > ---SSSSS--------- fon (+49 8171) 41805-0 > > -----SSSSSSS----- fax (+49 8171) 41805-59 > > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > > SSSSS-----SSSSS mobil: (+49 172) 8104162 > > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > > SSSSSSSSS Jens Hamisch > > > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com -- -------------------------------------------------------------------------------- s t r a w b e r r y e d v - s y s t e m e g m b h SSSSSSSSS Am Flosskanal 7 Jens Hamisch SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO SSSSS-----SSSSS ---SSSSS--------- fon (+49 8171) 41805-0 -----SSSSSSS----- fax (+49 8171) 41805-59 ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com SSSSS-----SSSSS mobil: (+49 172) 8104162 SSSSSSSSSSSSS Geschaeftsfuehrer/CEO SSSSSSSSS Jens Hamisch a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 From jens at Strawberry.COM Thu May 3 06:56:34 2007 From: jens at Strawberry.COM (Jens Hamisch) Date: Thu, 3 May 2007 15:56:34 +0200 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <8ccbff060705030528o2060726bubec16bac21a09e87@mail.gmail.com>; from Dome Charoenyost on Thu, May 03, 2007 at 07:28:02PM +0700 References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> <20070503023653.GA29236@nibiru.local> <20070503085427.A9675@Strawberry.COM> <8ccbff060705030528o2060726bubec16bac21a09e87@mail.gmail.com> Message-ID: <20070503155634.A11877@Strawberry.COM> Hi, I've verfied the 5.1_jens PearDatabase.php to my running version and found no differences. Could you please check the one attached to this mail to the one you're testing against? Kind regards, Jens Hamisch On Thu, May 03, 2007 at 07:28:02PM +0700, Dome Charoenyost wrote: > Jens, > I try to test your branch with lxampp 1.5.3a (php 5.1.4) > found same error > Fatal error: Call to a member function Move() on a non-object in > /opt/lampp/htdocs/vtiger/include/database/PearDatabase.php on line 441 > > Please give me more information about php,postgresql version ? > > Dome C. > > On 5/3/07, Jens Hamisch wrote: > > > > Hi Enrico, > > > > my fixes adress syntactical postgres support only. However > > yours also seems to improove performance. Is there any chance > > to have both fixes implemented (@don,richie)? > > > > Jens > > > > > > On Thu, May 03, 2007 at 04:36:53AM +0200, Enrico Weigelt wrote: > > > * Jorge Torres schrieb: > > > > > > Hi, > > > > > > > Since it is now clear that postgres is supported, the only thing would be > > > > about Enrico's opinion of adb->query_results being resource wasting, which > > > > is very important regardless of mysql or postgres use, Enrico, what are > > > > you doing instead of using the query_results method? > > > > > > As already said: introduced some new functions, which fetch either > > > one record (run_query_record() and run_query_field()) or all records > > > (run_query_allrecords() and run_query_list()) and simply return the data. > > > > > > There are several result types: > > > > > > a) just one scalar: -> run_query_field($query,$fieldname) > > > --> returns an scalar > > > b) just one record: -> run_query_record($query) > > > --> returns an associative array > > > c) an list of scalars -> run_query_list($query,$fieldname) > > > --> returns an array/list of scalars > > > d) an list of records: -> run_query_allreords($query) > > > --> returns an array/list of ass. arrays > > > > > > cu > > > -- > > > --------------------------------------------------------------------- > > > Enrico Weigelt == metux IT service > > > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > > fax: +49 36207 519932 email: contact at metux.de > > > cellphone: +49 174 7066481 > > > --------------------------------------------------------------------- > > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > > --------------------------------------------------------------------- > > > _______________________________________________ > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > -- > > > > -------------------------------------------------------------------------------- > > > > s t r a w b e r r y e d v - s y s t e m e g m b h > > > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > > SSSSS-----SSSSS > > ---SSSSS--------- fon (+49 8171) 41805-0 > > -----SSSSSSS----- fax (+49 8171) 41805-59 > > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > > SSSSS-----SSSSS mobil: (+49 172) 8104162 > > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > > SSSSSSSSS Jens Hamisch > > > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com -- -------------------------------------------------------------------------------- s t r a w b e r r y e d v - s y s t e m e g m b h SSSSSSSSS Am Flosskanal 7 Jens Hamisch SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO SSSSS-----SSSSS ---SSSSS--------- fon (+49 8171) 41805-0 -----SSSSSSS----- fax (+49 8171) 41805-59 ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com SSSSS-----SSSSS mobil: (+49 172) 8104162 SSSSSSSSSSSSS Geschaeftsfuehrer/CEO SSSSSSSSS Jens Hamisch a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 -------------- next part -------------- info("PearDatabse ->".print_r($msg,true)); } else { $log1->info("PearDatabase ->".$msg); } return $msg; } function setDieOnError($value){ $this->dieOnError = $value; } function setDatabaseType($type){ $this->dbType = $type; } function setUserName($name){ $this->userName = $name; } function setOption($name, $value){ if(isset($this->dbOptions)) $this->dbOptions[$name] = $value; if(isset($this->database)) $this->database->setOption($name, $value); } function setUserPassword($pass){ $this->userPassword = $pass; } function setDatabaseName($db){ $this->dbName = $db; } function setDatabaseHost($host){ $this->dbHostName = $host; } function getDataSourceName(){ return $this->dbType. "://".$this->userName.":".$this->userPassword."@". $this->dbHostName . "/". $this->dbName; } function startTransaction() { $this->checkConnection(); $this->println("TRANS Started"); $this->database->StartTrans(); } function completeTransaction() { if($this->database->HasFailedTrans()) $this->println("TRANS Rolled Back"); else $this->println("TRANS Commited"); $this->database->CompleteTrans(); $this->println("TRANS Completed"); } /* ADODB converted * function checkError($msg='', $dieOnError=false) * { * if($this->dbType == "mysql") * { * if (mysql_errno()) * { * if($this->dieOnError || $dieOnError) * { * $this->log->fatal("MySQL error ".mysql_errno().": ".mysql_error()); * die ($msg."MySQL error ".mysql_errno().": ".mysql_error()); * } else { * $this->log->error("MySQL error ".mysql_errno().": ".mysql_error()); * } * return true; * } * return false; * } * else * { * if(!isset($this->database)) * { * $this->log->error("Database Is Not Connected"); * return true; * } * if(DB::isError($this->database)) * { * if($this->dieOnError || $dieOnError) * { * $this->log->fatal($msg.$this->database->getMessage()); * die ($msg.$this->database->getMessage()); * } else { * $this->log->error($msg.$this->database->getMessage()); * } * return true; * } * } * return false; * } */ function checkError($msg='', $dieOnError=false) { /* * if($this->database->ErrorNo()) * { * if($this->dieOnError || $dieOnError) * { * $this->println("ADODB error ".$this->database->ErrorNo()); * die ($msg."ADODB error ".$this->database->ErrorNo()); * } else { * $this->log->error("MySQL error ".mysql_errno().": ".mysql_error()); * } * return true; * } */ if($this->dieOnError || $dieOnError) { $this->println("ADODB error ".$msg."->[".$this->database->ErrorNo()."]".$this->database->ErrorMsg()); die ($msg."ADODB error ".$msg."->".$this->database->ErrorMsg()); } else { $this->println("ADODB error ".$msg."->[".$this->database->ErrorNo()."]".$this->database->ErrorMsg()); } return false; } function change_key_case($arr) { return is_array($arr)?array_change_key_case($arr):$arr; } var $req_flist; /** * @return void * @desc checks if a connection exists if it does not it closes the connection * Portions created by SugarCRM are Copyright (C) SugarCRM, Inc.. * All Rights Reserved.. * Contributor(s): ______________________________________.. */ function checkConnection(){ global $log; if(!isset($this->database)) { $this->println("TRANS creating new connection"); /* * $flist=get_included_files(); * foreach($flist as $key=>$value) * { * if(!strstr($value,'\\modules') && !strstr($value,'\\data')) * unset($flist[$key]); * } * $this->println($flist); */ $this->connect(false); } else { //$this->println("checkconnect using old connection"); } } /* ADODB converted * function query($sql, $dieOnError=false, $msg='') * { * $this->println("query ".$sql); * $this->log->info('Query:' . $sql); * $this->checkConnection(); * $this->query_time = microtime(); * if($this->dbType == "mysql") * { * $result =& mysql_query($sql); * $this->lastmysqlrow = -1; * } else { * $result =& $this->database->query($sql); * } * $this->query_time = microtime() - $this->query_time; * $this->log->info('Query Execution Time:'.$this->query_time); * $this->checkError($msg.' Query Failed:' . $sql . '::', $dieOnError); * return $result; * } */ function query($sql, $dieOnError=false, $msg='') { global $log; //$this->println("ADODB query ".$sql); $log->debug('query being executed : '.$sql); $this->checkConnection(); $result = & $this->database->Execute($sql); $this->lastmysqlrow = -1; if(!$result)$this->checkError($msg.' Query Failed:' . $sql . '::', $dieOnError); return $result; } function getEmptyBlob() { //if(dbType=="oci8") return 'empty_blob()'; //else return 'null'; return 'null'; } function updateBlob($tablename, $colname, $id, $data) { $this->println("updateBlob t=".$tablename." c=".$colname." id=".$id); $this->checkConnection(); $result = $this->database->UpdateBlob($tablename, $colname, $data, $id); $this->println("updateBlob t=".$tablename." c=".$colname." id=".$id." status=".$result); return $result; } function updateBlobFile($tablename, $colname, $id, $filename) { $this->println("updateBlobFile t=".$tablename." c=".$colname." id=".$id." f=".$filename); $this->checkConnection(); $result = $this->database->UpdateBlobFile($tablename, $colname, $filename, $id); $this->println("updateBlobFile t=".$tablename." c=".$colname." id=".$id." f=".$filename." status=".$result); return $result; } /* ADODB converted * function limitQuery($sql,$start,$count, $dieOnError=false, $msg='') * { * if($this->dbType == "mysql") * return $this->query("$sql LIMIT $start,$count", $dieOnError, $msg); * $this->log->info('Limit Query:' . $sql. ' Start: ' .$start . ' count: ' . $count); * $this->lastsql = $sql; * * $this->checkConnection(); * $this->query_time = microtime(); * $result =& $this->database->limitQuery($sql,$start, $count); * $this->query_time = microtime() - $this->query_time; * $this->log->info('Query Execution Time:'.$this->query_time); * $this->checkError($msg.' Query Failed:' . $sql . '::', $dieOnError); * return $result; * } */ function limitQuery($sql,$start,$count, $dieOnError=false, $msg='') { global $log; //$this->println("ADODB limitQuery sql=".$sql." st=".$start." co=".$count); $log->debug(' limitQuery sql = '.$sql .' st = '.$start .' co = '.$count); $this->checkConnection(); $result =& $this->database->SelectLimit($sql,$count,$start); if(!$result) $this->checkError($msg.' Limit Query Failed:' . $sql . '::', $dieOnError); return $result; } /* ADODB converted * function getOne($sql, $dieOnError=false, $msg='') * { * $this->log->info('Get One:' . $sql); * $this->checkConnection(); * if($this->dbType == "mysql"){ * $queryresult =& $this->query($sql, $dieOnError, $msg); * $result =& mysql_result($queryresult,0); * } else { * $result =& $this->database->getOne($sql); * } * $this->checkError($msg.' Get One Failed:' . $sql . '::', $dieOnError); * return $result; * } */ function getOne($sql, $dieOnError=false, $msg='') { $this->println("ADODB getOne sql=".$sql); $this->checkConnection(); $result =& $this->database->GetOne($sql); if(!$result) $this->checkError($msg.' Get one Query Failed:' . $sql . '::', $dieOnError); return $result; } /* ADODB converted * function getFieldsArray(&$result) * { * $field_array = array(); * * if(! isset($result) || empty($result)) * { * return 0; * } * * if($this->dbType == "mysql") * { * $i = 0; * while ($i < mysql_num_fields($result)) * { * $meta = mysql_fetch_field($result, $i); * * if (!$meta) * { * return 0; * } * * array_push($field_array,$meta->name); * * $i++; * } * } * else * { * $arr = tableInfo($result); * foreach ($arr as $index=>$subarr) * { * array_push($field_array,$subarr['name']); * } * } * * return $field_array; * } */ function getFieldsArray(&$result) { //$this->println("ADODB getFieldsArray"); $field_array = array(); if(! isset($result) || empty($result)) { return 0; } $i = 0; $n = $result->FieldCount(); while ($i < $n) { $meta = $result->FetchField($i); if (!$meta) { return 0; } array_push($field_array,$meta->name); $i++; } //$this->println($field_array); return $field_array; } /* ADODB Converted * function getRowCount(&$result) * { * if(isset($result) && !empty($result)) * if($this->dbType == "mysql"){ * return mysql_numrows($result); * } else { * return $result->numRows(); * } * return 0; * } */ function getRowCount(&$result){ global $log; //$this->println("ADODB getRowCount"); if(isset($result) && !empty($result)) $rows= $result->RecordCount(); //$this->println("ADODB getRowCount rows=".$rows); //$log->debug('getRowCount rows= '.$rows); return $rows; } /* ADODB newly added. replacement for mysql_num_rows */ function num_rows(&$result) { return $this->getRowCount($result); } /* ADODB newly added. replacement form mysql_num_fields */ function num_fields(&$result) { return $result->FieldCount(); } /* ADODB newly added. replacement for mysql_fetch_array() */ function fetch_array(&$result) { if($result->EOF) { //$this->println("ADODB fetch_array return null"); return NULL; } return $this->change_key_case($result->FetchRow()); } /* ADODB newly added. replacement for mysql_result() */ function query_result(&$result, $row, $col=0) { //$this->println("ADODB query_result r=".$row." c=".$col); $result->Move($row); $rowdata = $this->change_key_case($result->FetchRow()); //$this->println($rowdata); //Commented strip_selected_tags and added to_html function for HTML tags vulnerability //$coldata = strip_selected_tags($rowdata[$col],'script'); $coldata = to_html($rowdata[$col]); //$this->println("ADODB query_result ". $coldata); return $coldata; } /* ADODB Converted * function getAffectedRowCount(&$result) * { * if($this->dbType == "mysql"){ * return mysql_affected_rows(); * } * else { * return $result->affectedRows(); * } * return 0; * } */ function getAffectedRowCount(&$result) { global $log; //$this->println("ADODB getAffectedRowCount"); $log->debug('getAffectedRowCount'); $rows =$this->database->Affected_Rows(); //$this->println("ADODB getAffectedRowCount rows=".rows); $log->debug('getAffectedRowCount rows = '.$rows); return $rows; } /* ADODB converted * function requireSingleResult($sql, $dieOnError=false,$msg='', $encode=true){ * $result = $this->query($sql, $dieOnError, $msg); * * if($this->getRowCount($result ) == 1) * return to_html($result, $encode); * $this->log->error('Rows Returned:'. $this->getRowCount($result) .' More than 1 row returned for '. $sql); * return ''; * } */ function requireSingleResult($sql, $dieOnError=false,$msg='', $encode=true) { $result = $this->query($sql, $dieOnError, $msg); if($this->getRowCount($result ) == 1) return $result; $this->log->error('Rows Returned:'. $this->getRowCount($result) .' More than 1 row returned for '. $sql); return ''; } /* ADODB converted * function fetchByAssoc(&$result, $rowNum = -1, $encode=true) * { * if(isset($result) && $rowNum < 0) * { * if($this->dbType == "mysql"){ * $row = mysql_fetch_assoc($result); * * if($encode&& is_array($row)) * return array_map('to_html', $row); * return $row; * } * $row = $result->fetchRow(DB_FETCHMODE_ASSOC); * } * if($this->dbType == "mysql"){ * if($this->getRowCount($result) > $rowNum){ * mysql_data_seek($result, $rowNum); * } * $this->lastmysqlrow = $rowNum; * * $row = mysql_fetch_assoc($result); * * if($encode&& is_array($row)) * return array_map('to_html', $row); * return $row; * } * $row = $result->fetchRow(DB_FETCHMODE_ASSOC, $rowNum); * if($encode) * return array_map('to_html', $row); * return $row; * } */ function fetchByAssoc(&$result, $rowNum = -1, $encode=true) { //$this->println("ADODB fetchByAssoc ".$rowNum." fetch mode=".$adb->database->$ADODB_FETCH_MODE); if($result->EOF) { $this->println("ADODB fetchByAssoc return null"); return NULL; } if(isset($result) && $rowNum < 0) { $row = $this->change_key_case($result->GetRowAssoc(false)); $result->MoveNext(); //print_r($row); //$this->println("ADODB fetchByAssoc r< 0 isarray r=".is_array($row)." r1=".is_array($row[1])); //$this->println($row); if($encode&& is_array($row)) return array_map('to_html', $row); //$this->println("ADODB fetchByAssoc r< 0 not array r1=".$row[1]); return $row; } //$this->println("ADODB fetchByAssoc after if ".$rowNum); if($this->getRowCount($result) > $rowNum) { $result->Move($rowNum); } $this->lastmysqlrow = $rowNum; //srini - think about this $row = $this->change_key_case($result->GetRowAssoc(false)); $result->MoveNext(); //print_r($row); $this->println($row); if($encode&& is_array($row)) return array_map('to_html', $row); return $row; } /* ADODB converted * function getNextRow(&$result, $encode=true) * { * if(isset($result)){ * $row = $result->fetchRow(); * if($encode&& is_array($row)) * return array_map('to_html', $row); * return $row; * } * return null; * } */ function getNextRow(&$result, $encode=true){ global $log; //$this->println("ADODB getNextRow"); $log->info('getNextRow'); if(isset($result)){ $row = $this->change_key_case($result->FetchRow()); if($row && $encode&& is_array($row)) return array_map('to_html', $row); return $row; } return null; } function fetch_row(&$result, $encode=true) { return $this->getNextRow($result); } function field_name(&$result, $col) { return $result->FetchField($col); } function getQueryTime(){ return $this->query_time; } /* * function execute($stmt, $data, $dieOnError=false, $msg=''){ * $this->log->info('Executing:'.$stmt); * $this->checkConnection(); * $this->query_time = microtime(); * $prepared = $this->database->prepare($stmt); * $result = execute($stmt, $data); * $this->query_time = microtime() - $this->query_time; * //$this->log->info('Query Execution Time:'.$this->query_time); * $this->checkError('Execute Failed:' . $stmt. '::', $dieOnError); * return $result; * } */ /* adodb converted * function connect($dieOnError = false){ * $this->println("connect"); * global $dbconfigoption; * if($this->dbType == "mysql" && $dbconfigoption['persistent'] == true){ * $this->database =@mysql_pconnect($this->dbHostName,$this->userName,$this->userPassword); * @mysql_select_db($this->dbName) or die( "Unable to select database"); * if(!$this->database){ * $this->connection = mysql_connect($this->dbHostName,$this->userName,$this->userPassword) or die("Could not connect to server ".$this->dbHostName." as ".$this->userName.".".mysql_error()); * if($this->connection == false && $dbconfigoption['persistent'] == true){ * $_SESSION['administrator_error'] = "Severe Performance Degradation: Persistent Database Connections not working. Please set \$dbconfigoption['persistent'] to false in your config.php file"; * } * } * } * else $this->database = DB::connect($this->getDataSourceName(), $this->dbOptions); * if($this->checkError('Could Not Connect:', $dieOnError)) * $this->log->info("connected to db"); * * } */ function connect($dieOnError = false) { //$this->println("ADODB connect"); global $dbconfigoption,$dbconfig; //$this->println("ADODB type=".$this->dbType." host=".$this->dbHostName." dbname=".$this->dbName." user=".$this->userName." password=".$this->userPassword); /* * $driver='mysql'; * $server='srinivasan'; * $user='root'; * $password=''; * $database='vtigercrm3_2'; * * $this->database = ADONewConnection($driver); * * #$this->database->debug = true; * $this->println("ADODB status=".$this->database->PConnect($server, $user, $password, $database)); */ /* * $this->dbHostName="srinivasan:1521"; * $this->userName="vt4"; * $this->userPassword="vt4"; * $this->dbName="srini"; * $this->dbType="oci8"; */ if(!isset($this->dbType)) { $this->println("ADODB Connect : DBType not specified"); return; } $this->database = ADONewConnection($this->dbType); //$this->database->debug = true; $this->database->PConnect($this->dbHostName, $this->userName, $this->userPassword, $this->dbName); $this->database->LogSQL($this->enableSQLlog); //$this->database->SetFetchMode(ADODB_FETCH_ASSOC); //$this->println("ADODB type=".$this->dbType." host=".$this->dbHostName." dbname=".$this->dbName." user=".$this->userName." password=".$this->userPassword); } /* * function PearDatabase(){ * //$this->println("PearDatabase"); * global $currentModule; * $this->log =& LoggerManager::getLogger('PearDatabase_'. $currentModule); * $this->resetSettings(); * } * * function resetSettings(){ * global $dbconfig, $dbconfigoption; * $this->disconnect(); * $this->setDatabaseType($dbconfig['db_type']); * $this->setUserName($dbconfig['db_username']); * $this->setUserPassword($dbconfig['db_password']); * $this->setDatabaseHost( $dbconfig['db_hostname']); * $this->setDatabaseName($dbconfig['db_name']); * $this->dbOptions = $dbconfigoption; * $this->enableSQLlog = ($dbconfig['log_sql'] == true); * //$this->println("resetSettings log=".$this->enableSQLlog); * //$this->println($dbconfig); * //if($this->dbType != "mysql"){ * // require_once( 'DB.php' ); * //} * } */ function PearDatabase($dbtype='',$host='',$dbname='',$username='',$passwd='') { //$this->println("PearDatabase"); global $currentModule; $this->log =& LoggerManager::getLogger('PearDatabase_'. $currentModule); $this->resetSettings($dbtype,$host,$dbname,$username,$passwd); } function resetSettings($dbtype,$host,$dbname,$username,$passwd) { global $dbconfig, $dbconfigoption; if($host == '') { $this->disconnect(); $this->setDatabaseType($dbconfig['db_type']); $this->setUserName($dbconfig['db_username']); $this->setUserPassword($dbconfig['db_password']); $this->setDatabaseHost( $dbconfig['db_hostname']); $this->setDatabaseName($dbconfig['db_name']); $this->dbOptions = $dbconfigoption; if($dbconfig['log_sql']) $this->enableSQLlog = ($dbconfig['log_sql'] == true); //$this->println("resetSettings log=".$this->enableSQLlog); //$this->println($dbconfig); /*if($this->dbType != "mysql"){ require_once( 'DB.php' ); }*/ } else { $this->disconnect(); $this->setDatabaseType($dbtype); $this->setDatabaseName($dbname); $this->setUserName($username); $this->setUserPassword($passwd); $this->setDatabaseHost( $host); } } function quote($string){ return $this->database->qstr($string); } /* ADODB converted * function disconnect() { * $this->println("disconnect"); * if(isset($this->database)){ * if($this->dbType == "mysql"){ * mysql_close($this->database); * } else { * $this->database->disconnect(); * } * unset($this->database); * } * } */ function disconnect() { $this->println("ADODB disconnect"); if(isset($this->database)){ if($this->dbType == "mysql"){ mysql_close($this->database); } else { $this->database->disconnect(); } unset($this->database); } } function setDebug($value) { $this->database->debug = $value; } // ADODB newly added methods function createTables($schemaFile, $dbHostName=false, $userName=false, $userPassword=false, $dbName=false, $dbType=false) { $this->println("ADODB createTables ".$schemaFile); if($dbHostName!=false) $this->dbHostName=$dbHostName; if($userName!=false) $this->userName=$userPassword; if($userPassword!=false) $this->userPassword=$userPassword; if($dbName!=false) $this->dbName=$dbName; if($dbType!=false) $this->dbType=$dbType; //$db = ADONewConnection($this->dbType); $this->checkConnection(); $db = $this->database; //$db->debug = true; //$this->println("ADODB createTables connect status=".$db->Connect($this->dbHostName, $this->userName, $this->userPassword, $this->dbName)); $schema = new adoSchema( $db ); //Debug Adodb XML Schema $sehema->XMLS_DEBUG = TRUE; //Debug Adodb $sehema->debug = true; $sql = $schema->ParseSchema( $schemaFile ); $this->println("--------------Starting the table creation------------------"); //$this->println($sql); //integer ExecuteSchema ([array $sqlArray = NULL], [boolean $continueOnErr = NULL]) $result = $schema->ExecuteSchema( $sql, true ); if($result) print $db->errorMsg(); // needs to return in a decent way $this->println("ADODB createTables ".$schemaFile." status=".$result); return $result; } function createTable($tablename, $flds) { $this->println("ADODB createTable table=".$tablename." flds=".$flds); $this->checkConnection(); //$dict = NewDataDictionary(ADONewConnection($this->dbType)); $dict = NewDataDictionary($this->database); $sqlarray = $dict->CreateTableSQL($tablename, $flds); $result = $dict->ExecuteSQLArray($sqlarray); $this->println("ADODB createTable table=".$tablename." flds=".$flds." status=".$result); return $result; } function alterTable($tablename, $flds, $oper) { $this->println("ADODB alterTableTable table=".$tablename." flds=".$flds." oper=".$oper); //$dict = NewDataDictionary(ADONewConnection($this->dbType)); $this->checkConnection(); $dict = NewDataDictionary($this->database); //$sqlarray = new Array(); if($oper == 'Add_Column') { $sqlarray = $dict->AddColumnSQL($tablename, $flds); } else if($oper == 'Delete_Column') { $sqlarray = $dict->DropColumnSQL($tablename, $flds); } $this->println("sqlarray"); $this->println($sqlarray); $result = $dict->ExecuteSQLArray($sqlarray); $this->println("ADODB alterTableTable table=".$tablename." flds=".$flds." oper=".$oper." status=".$result); return $result; } function getColumnNames($tablename) { $this->println("ADODB getColumnNames table=".$tablename); $this->checkConnection(); $adoflds = $this->database->MetaColumns($tablename); //$colNames = new Array(); $i=0; foreach($adoflds as $fld) { $colNames[$i] = $fld->name; $i++; } return $colNames; } function formatString($tablename,$fldname, $str) { //$this->println("ADODB formatString table=".$tablename." fldname=".$fldname." str=".$str); $this->checkConnection(); $adoflds = $this->database->MetaColumns($tablename); foreach ( $adoflds as $fld ) { //$this->println("ADODB formatString adofld =".$fld->name); if(strcasecmp($fld->name,$fldname)==0) { //$this->println("ADODB formatString fldname=".$fldname." fldtype =".$fld->type); $fldtype =strtoupper($fld->type); if(strcmp($fldtype,'CHAR')==0 || strcmp($fldtype,'VARCHAR') == 0 || strcmp($fldtype,'VARCHAR2') == 0 || strcmp($fldtype,'LONGTEXT')==0 || strcmp($fldtype,'TEXT')==0) { //$this->println("ADODB return else normal"); return $this->database->Quote($str); } else if(strcmp($fldtype,'DATE') ==0 || strcmp($fldtype,'TIMESTAMP')==0) { return $this->formatDate($str); } else { return $str; } } } $this->println("format String Illegal field name ".$fldname); return $str; } function formatDate($datetime) { $this->checkConnection(); //$db = ADONewConnection($this->dbType); $db = &$this->database; $date = $db->DBTimeStamp($datetime); //if($db->dbType=='mysql') return $this->quote($date); return $date; } function getDBDateString($datecolname) { $this->checkConnection(); $db = &$this->database; $datestr = $db->SQLDate("Y-m-d, H:i:s" ,$datecolname); return $datestr; } function getUniqueID($seqname) { global $log; $this->checkConnection(); if( $this->dbType == "pgsql") { $keytab = $this->database->MetaPrimaryKeys($seqname); if( count( $keytab) > 0) { $log->info("PearDatabase: Postgres getUniqueID hack: ".$seqname."_".$keytab[0]."_seq"); return $this->database->GenID($seqname."_".$keytab[0]."_seq",1); } else { $log->info("PearDatabase: Problem: getUniqueID but no key for '$seqname'"); } } return $this->database->GenID($seqname."_seq",1); } function get_tables() { $this->checkConnection(); $result = & $this->database->MetaTables('TABLES'); $this->println($result); return $result; } } /* End of class */ $adb = new PearDatabase(); $adb->connect(); //$adb->database->setFetchMode(ADODB_FETCH_NUM); ?> From dome at tel.co.th Thu May 3 07:40:59 2007 From: dome at tel.co.th (Dome Charoenyost) Date: Thu, 3 May 2007 21:40:59 +0700 Subject: [Vtigercrm-developers] vtiger contribution question In-Reply-To: <20070503155634.A11877@Strawberry.COM> References: <530c7d700704291651q203506e6xe6addd84858a08ed@mail.gmail.com> <20070501175850.GB26224@nibiru.local> <530c7d700705011248gfcccf56wf22cf099fbab1aa7@mail.gmail.com> <20070501200552.GC26224@nibiru.local> <20070502082057.D16394@Strawberry.COM> <530c7d700705021213n30198868p2f1f7bd4b55ef846@mail.gmail.com> <20070503023653.GA29236@nibiru.local> <20070503085427.A9675@Strawberry.COM> <8ccbff060705030528o2060726bubec16bac21a09e87@mail.gmail.com> <20070503155634.A11877@Strawberry.COM> Message-ID: <8ccbff060705030740u1f6df32cjd133c656035acfe8@mail.gmail.com> Same problem. when create contact Fatal error: Call to a member function Move() on a non-object in /opt/lampp/htdocs/vtiger/include/database/PearDatabase.php on line 441 When create new note Warning: mktime() expects parameter 6 to be long, string given in /opt/lampp/htdocs/vtiger/include/utils/CommonUtils.php on line 1388 Warning: mktime() expects parameter 1 to be long, string given in /opt/lampp/htdocs/vtiger/include/utils/CommonUtils.php on line 1389 Setting->orgunit Fatal error: Call to undefined method OrgUnit::getListQuery() in /opt/lampp/htdocs/vtiger/include/utils/ListViewUtils.php on line 2388 Dome C. On 5/3/07, Jens Hamisch wrote: > > Hi, > > I've verfied the 5.1_jens PearDatabase.php to my running version > and found no differences. Could you please check the one attached to > this mail to the one you're testing against? > > Kind regards, > Jens Hamisch > > On Thu, May 03, 2007 at 07:28:02PM +0700, Dome Charoenyost wrote: > > Jens, > > I try to test your branch with lxampp 1.5.3a (php 5.1.4) > > found same error > > Fatal error: Call to a member function Move() on a non-object in > > /opt/lampp/htdocs/vtiger/include/database/PearDatabase.php on line 441 > > > > Please give me more information about php,postgresql version ? > > > > Dome C. > > > > On 5/3/07, Jens Hamisch wrote: > > > > > > Hi Enrico, > > > > > > my fixes adress syntactical postgres support only. However > > > yours also seems to improove performance. Is there any chance > > > to have both fixes implemented (@don,richie)? > > > > > > Jens > > > > > > > > > On Thu, May 03, 2007 at 04:36:53AM +0200, Enrico Weigelt wrote: > > > > * Jorge Torres schrieb: > > > > > > > > Hi, > > > > > > > > > Since it is now clear that postgres is supported, the only thing would be > > > > > about Enrico's opinion of adb->query_results being resource wasting, which > > > > > is very important regardless of mysql or postgres use, Enrico, what are > > > > > you doing instead of using the query_results method? > > > > > > > > As already said: introduced some new functions, which fetch either > > > > one record (run_query_record() and run_query_field()) or all records > > > > (run_query_allrecords() and run_query_list()) and simply return the data. > > > > > > > > There are several result types: > > > > > > > > a) just one scalar: -> run_query_field($query,$fieldname) > > > > --> returns an scalar > > > > b) just one record: -> run_query_record($query) > > > > --> returns an associative array > > > > c) an list of scalars -> run_query_list($query,$fieldname) > > > > --> returns an array/list of scalars > > > > d) an list of records: -> run_query_allreords($query) > > > > --> returns an array/list of ass. arrays > > > > > > > > cu > > > > -- > > > > --------------------------------------------------------------------- > > > > Enrico Weigelt == metux IT service > > > > > > > > phone: +49 36207 519931 www: http://www.metux.de/ > > > > fax: +49 36207 519932 email: contact at metux.de > > > > cellphone: +49 174 7066481 > > > > --------------------------------------------------------------------- > > > > -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- > > > > --------------------------------------------------------------------- > > > > _______________________________________________ > > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > > > -- > > > > > > -------------------------------------------------------------------------------- > > > > > > s t r a w b e r r y e d v - s y s t e m e g m b h > > > > > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > > > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > > > SSSSS-----SSSSS > > > ---SSSSS--------- fon (+49 8171) 41805-0 > > > -----SSSSSSS----- fax (+49 8171) 41805-59 > > > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > > > SSSSS-----SSSSS mobil: (+49 172) 8104162 > > > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > > > SSSSSSSSS Jens Hamisch > > > > > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > > > _______________________________________________ > > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > > > > _______________________________________________ > > Reach hundreds of potential candidates - http://jobs.vtiger.com > > -- > > -------------------------------------------------------------------------------- > > s t r a w b e r r y e d v - s y s t e m e g m b h > > SSSSSSSSS Am Flosskanal 7 Jens Hamisch > SSSSSSSSSSSSS D-82515 Wolfratshausen Geschaeftsfuehrer/CEO > SSSSS-----SSSSS > ---SSSSS--------- fon (+49 8171) 41805-0 > -----SSSSSSS----- fax (+49 8171) 41805-59 > ---------SSSSS--- info at strawberry.com jens.hamisch at strawberry.com > SSSSS-----SSSSS mobil: (+49 172) 8104162 > SSSSSSSSSSSSS Geschaeftsfuehrer/CEO > SSSSSSSSS Jens Hamisch > > a g m u e n c h e n H R B 9 3 2 8 7 - D E 1 2 9 4 6 7 5 1 8 > > _______________________________________________ > Reach hundreds of potential candidates - http://jobs.vtiger.com > > From weigelt at metux.de Thu May 3 09:24:44 2007 From: weigelt at metux.de (Enrico Weigelt) Date: Thu, 3 May 2007 18:24:44 +0200 Subject: [Vtigercrm-developers] [PATCH] new functions and some cleanups Message-ID: <20070503162443.GA22625@nibiru.local> Hi folks, here are some patches (against latest trunk), which introduce the new functions and so some cleanups. cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service phone: +49 36207 519931 www: http://www.metux.de/ fax: +49 36207 519932 email: contact at metux.de cellphone: +49 174 7066481 --------------------------------------------------------------------- -- DSL ab 0 Euro. -- statische IP -- UUCP -- Hosting -- Webshops -- --------------------------------------------------------------------- -------------- next part -------------- ## ## takes db_port directly from the request variable, since register_globals ## is disabled most times and deprecated. ## diff -ruN upstream-10823/install/4createConfigFile.php working/install/4createConfigFile.php --- upstream-10823/install/4createConfigFile.php 2007-05-03 17:42:54.000000000 +0200 +++ working/install/4createConfigFile.php 2007-05-03 17:53:31.000000000 +0200 @@ -58,11 +58,14 @@ else { $db_hostname = $_REQUEST['db_hostname']; - if($db_type == "pgsql") - $db_port = '5432'; - else - $db_port = '3306'; - } + switch($_REQUEST{'db_type'}) + { + case 'pgsql': $db_port = '5432'; break; + case 'mysql': $db_port = '3306'; break; + default: + throw new Exception("unsupported db_type: \""+$_REQUEST{'db_type'}."\""); + } + } } if (isset($_REQUEST['db_username']))$db_username = $_REQUEST['db_username']; ## ## fixes error w/ duplicated class definitions. not sure if this is really correct ;-O ## diff -ruN upstream-10823/modules/Calendar/Date.php working/modules/Calendar/Date.php --- upstream-10823/modules/Calendar/Date.php 2007-05-03 17:43:39.000000000 +0200 +++ working/modules/Calendar/Date.php 2007-05-03 17:53:31.000000000 +0200 @@ -9,7 +9,7 @@ * ********************************************************************************/ -class DateTime +class X_DateTime { var $second = '00'; var $minute = '00'; -------------- next part -------------- ## ## adds new functions to the PearDatabase class to come around the whole ## broken query_result() idea ;-O ## diff -ruN cleaned/include/database/PearDatabase.php working/include/database/PearDatabase.php --- cleaned/include/database/PearDatabase.php 2007-05-03 17:50:00.000000000 +0200 +++ working/include/database/PearDatabase.php 2007-05-03 18:10:05.000000000 +0200 @@ -433,6 +433,144 @@ } return $this->change_key_case($result->FetchRow()); } + function run_query_record_html($query) + { + if (!is_array($rec = $this->run_query_record($query))) +// throw new Exception("no rec: $query"); + return $rec; + + foreach ($rec as $walk => $cur) + $r[$walk] = to_html($cur); + + return $r; + } + + function sql_quote($data) + { + if (is_array($data)) + { + switch($data{'type'}) + { + case 'text': + case 'numeric': + case 'integer': + case 'oid': + return $this->quote($data{'value'}); + break; + case 'timestamp': + return $this->formatDate($data{'value'}); + break; + default: + throw new Exception("unhandled type: ".serialize($cur)); + } + } + else + return $this->quote($data); + } + + function sql_insert_data($table, $data) + { + if (!$table) + throw new Exception("missing table name"); + if (!is_array($data)) + throw new Exception("data must be an array"); + if (!count($table)) + throw new Exception("no data given"); + + $sql_fields = ''; + $sql_data = ''; + foreach($data as $walk => $cur) + { + $sql_fields .= ($sql_fields?',':'').$walk; + $sql_data .= ($sql_data?',':'').$this->sql_quote($cur); + } + + return 'INSERT INTO '.$table.' ('.$sql_fields.') VALUES ('.$sql_data.')'; + } + + function run_insert_data($table,$data) + { + $query = $this->sql_insert_data($table,$data); + $res = $this->query($query); + $this->query("commit;"); + } + + function run_query_record($query) + { + $result = $this->query($query); + if (!$result) + return; +// throw new Exception("empty result !"); + + if (!is_object($result)) + throw new Exception("query \"$query\" failed: ".serialize($result)); + $res = $result->FetchRow(); + $rowdata = $this->change_key_case($res); + return $rowdata; + } + + function run_query_allrecords($query) + { + $result = $this->query($query); + $records = array(); + $sz = $this->num_rows($result); + for ($i=0; $i<$sz; $i++) + $records[$i] = $this->change_key_case($result->FetchRow()); + return $records; + } + + function run_query_field($query,$field) + { + $rowdata = $this->run_query_record($query); + return $rowdata{$field}; + } + + function run_query_list($query,$field) + { + $records = $this->run_query_allrecords($query); + foreach($records as $walk => $cur) + $list[] = $cur{$field}; + } + + function run_query_field_html($query,$field) + { + return to_html($this->run_query_field($query,$field)); + } + + function result_get_next_record($result) + { + return $this->change_key_case($result->FetchRow()); + } + + // create an IN expression from an array/list + function sql_expr_datalist($a) + { + if (!