[Vtigercrm-developers] errors in 4.2.4

[Joel Rydbeck]

I've started making changes.  Right now I'm watching for errors in Zend debugger (good tool, try the 30-day trial) and attacking those.
 
FYI folks, please make certain your variables are initialized.  There are a lot of cases like the following:
 
function iAmAnExample($x)
{
  if ($x == 2)
  {
    $var = 123;
  }
 
  return ($var + 4);  // error thrown here if $x wasn't 2; $var wasn't initialized
}
 
This stuff throws errors in PHP; presuming the 'IF' block didn't test true and execute, $var hasn't been initialized.  I've already nabbed 10 of these cases.
 
BTW Allan, I'm 100% behind frequent & small checkins --agreed, its a lot easier for everyone.
 
- Joel
 
 

________________________________

From: vtigercrm-developers-bounces at lists.vtigercrm.com on behalf of Allan Bush
Sent: Thu 6/15/2006 11:30 AM
To: vtigercrm-developers at lists.vtigercrm.com
Subject: Re: [Vtigercrm-developers] errors in 4.2.4



That was never targeted at 4.2.4.  Hopefully it can be resolved by
4.2.5.  I work on it periodically (and I'm pretty sure I made a couple
of checkins... I must have used ref instead of refs), but anyone is
free to do what they can.

If anyone want to work on it and doesn't have commit access, checkout
the latest code using SVN, make your changes, create a patch and
attach it to that bug (or #70 as they appear to be dups).  I'll make
sure to look over and check any patches in right away.  On a side note
it's better to make several small patches often rather then waiting
and making one large one.

On 6/15/06, Joel Rydbeck <Joel.Rydbeck at nubrek.com> wrote:
> Is anyone else working on ticket 748 (http://vtiger.fosslabs.com/cgi-bin/trac.cgi/ticket/748)?  There are still a lot of errors (e.g. "undefined variable") in parts of 4.2.4.
>
> - Joel
>
>
>
>
> _______________________________________________
> This vtiger.com email is sponsored by: Zoho Writer. Are you still using your desktop word processor for typing documents? Try the AJAX enabled, collaboration-friendly online word processor, Zoho Writer for FREE instead!
> http://zohowriter.com/?vt
>
>
_______________________________________________
This vtiger.com email is sponsored by: Zoho Writer. Are you still using your desktop word processor for typing documents? Try the AJAX enabled, collaboration-friendly online word processor, Zoho Writer for FREE instead!
http://zohowriter.com/?vt




-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/ms-tnef
Size: 6475 bytes
Desc: not available
Url : http://lists.vtigercrm.com/pipermail/vtigercrm-developers/attachments/20060615/a2a40065/attachment-0005.bin