[Vtigercrm-developers] [vtiger development] #51: Quotes are not created correctly form Potentials or from Quote screen

[vtiger development]

#51: Quotes are not created correctly form Potentials or from Quote screen
----------------------------------------------+-----------------------------
 Reporter:  onwealdandy <arodes at onweald.com>  |       Owner:  developer
     Type:  defect                            |      Status:  new      
 Priority:  major                             |   Milestone:           
Component:  vtigercrm                         |     Version:  5.0.0    
 Keywords:                                    |  
----------------------------------------------+-----------------------------
 Basically, you cannot create a quote from the potential screen in 4.2.x
 today.

 Here is the test case:
 Navigate to potential screen via potential tab click Drilldown on a
 potential from the returned list by clicking on the potential name (not
 sure If it matters, but the potentials I tested from were created from the
 lead screen -> convert to potential process) The system takes you to the
 potential detail view Scroll down to the Quotes section Click "New Quote"
 button System takes you to a new quote detail view and defaults the
 account name and defaults the potential name
 NOTE: today, the contact name is not brought over from the potential. This
 should probably be addressed in the future, but is not a bug, but is more
 of a new feature Fill in the required fields: Subject, billing address,
 shipping address Hit the Save button at the bottom of the form.

 Expected result:

 The system should save the quote, and return you to the detail potential
 screen where you can now see the quote listed in the quotes section under
 the potential.

 In 4.2.3 ... It appears to the user that the quote was created, but it
 never shows up on the potential screen nor in the list of all quotes via
 the quotes tab


 Summary of Code Changes:


 /modules/potentials/RenderRelatedListUI.php


 Changed the function getHiddenValues($id) to default the contact id to ''
 rather then the passed in $id since the passed in $id is the $id of the
 potential, NOT the contact

 /modules/quotes/save.php

 Added a check for incoming field values such that if the field name looks
 like a foreign key, we set the value to 'null' rather then just '' due to
 a mysql need.TODO: would be nice to make this more resilient to actually
 figure out if a column is a FK rather then just using some light logic
 like I am doing here.

-- 
Ticket URL: <http://vtiger.fosslabs.com/cgi-bin/trac.cgi/ticket/51>
vtiger development <http://vtiger.fosslabs.com/>
vtigerCRM