[Vtigercrm-commits] [Vtiger development] #8040: VT6 Reports module badly implemented

[Vtiger development]

#8040: VT6 Reports module badly implemented
-----------------------+------------------------
 Reporter:  alanlord   |      Owner:  developer
     Type:  defect     |     Status:  new
 Priority:  minor      |  Milestone:  Unassigned
Component:  vtigercrm  |    Version:  6.0.0
 Severity:  Low        |   Keywords:
-----------------------+------------------------
 As discussed on the mailing list I noticed that the Reports module totally
 fails to use the OOP architecture of the rest of the system. There is a
 great deal of duplication and it is very difficult to extend the
 functionality, e.g. add a new Meta Date filter.

 For example:


 {{{
 alanlord at web-dev:/var/www/vt6$ grep -rn '\$last30days =' *
 modules/Vtiger/models/Field.php:548:            $last30days =
 date("Y-m-d", mktime(0, 0, 0, date("m"), date("d") - 29, date("Y")));
 modules/Reports/ReportRun.php:1415:             $last30days =
 date("Y-m-d",mktime(0, 0, 0, date("m")  , date("d")-29, date("Y")));
 modules/Reports/Reports.php:946:                $last30days =
 date("Y-m-d",mktime(0, 0, 0, date("m")  , date("d")-29, date("Y")));
 modules/CustomView/CustomView.php:621:          $last30days =
 date("Y-m-d", mktime(0, 0, 0, date("m"), date("d") - 29, date("Y")));
 modules/CustomView/CustomView.php:1547:         $last30days =
 date("Y-m-d", mktime(0, 0, 0, date("m"), date("d") - 29, date("Y")));
 modules/CustomView/models/Record.php:644:       $last30days =
 date("Y-m-d", mktime(0, 0, 0, date("m"), date("d") - 29, date("Y")));
 }}}

--
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/8040>
Vtiger development <http://trac.vtiger.com/>
Vtiger CRM