[Vtigercrm-commits] [Vtiger development] #7243: hardcoded string in PDF Invoice filename

[Vtiger development]

#7243: hardcoded string in PDF Invoice filename
------------------------+---------------------
 Reporter:  srihari     |       Owner:  manu
     Type:  defect      |      Status:  closed
 Priority:  unassigned  |   Milestone:  6.2.0
Component:  vtigercrm   |     Version:  5.3.0
 Severity:  Medium      |  Resolution:  fixed
 Keywords:              |
------------------------+---------------------
Changes (by prasad):

 * status:  assigned => closed
 * resolution:   => fixed


Old description:

> {{{
> if(isset($_REQUEST['savemode']) && $_REQUEST['savemode'] == 'file') {
>     $id = vtlib_purify($_REQUEST['record']);
>     $filepath='test/product/'.$id.'_Invoice_'.$invoice_no.'.pdf';
>     $controller->Output($filepath,'F'); //added file name to make it work
> in IE, also forces the download giving the user the option to save
> } else {
>     $controller->Output('Invoice_'.$invoice_no.'.pdf', 'D')
> }}}
>
> we have hardcoded module name 'Invoice' in the file generation.

New description:

 {{{
 if(isset($_REQUEST['savemode']) && $_REQUEST['savemode'] == 'file') {
     $id = vtlib_purify($_REQUEST['record']);
     $filepath='test/product/'.$id.'_Invoice_'.$invoice_no.'.pdf';
     $controller->Output($filepath,'F'); //added file name to make it work
 in IE, also forces the download giving the user the option to save
 } else {
     $controller->Output('Invoice_'.$invoice_no.'.pdf', 'D')
 }}}

 we have hardcoded module name 'Invoice' in the file generation.

--

Comment:

 Changeset [14383]

--
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7243#comment:5>
Vtiger development <http://trac.vtiger.com/>
Vtiger CRM