[Vtigercrm-commits] [Vtiger development] #7176: ServiceContract.php uses !empty() where comparison to ZERO is required

Vtiger development vtiger-tickets at trac.vtiger.com
Mon Dec 15 10:53:20 GMT 2014


#7176: ServiceContract.php uses !empty() where comparison to ZERO is required
------------------------+------------------------
 Reporter:  gebhardt.p  |       Owner:  developer
     Type:  defect      |      Status:  closed
 Priority:  unassigned  |   Milestone:  6.2.0
Component:  vtigercrm   |     Version:  5.2.1
 Severity:  Critical    |  Resolution:  fixed
 Keywords:  empty,ZERO  |
------------------------+------------------------
Changes (by manu):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 hi gebhardt.p,

 The Divide by Zero error will appear only if it enters a if loop with
 $totalUnits value==0. The condition  "!empty($totalUnits)" prevent the
 controller to enter into the if  loop with zero value,though you  submit a
 $totalUnits value as "0.00".

--
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7176#comment:2>
Vtiger development <http://trac.vtiger.com/>
Vtiger CRM


More information about the vtigercrm-commits mailing list