[Vtigercrm-commits] [Vtiger development] #7627: Problem with browser/proxy cache of Module.js during custom module update

[Vtiger development]

#7627: Problem with browser/proxy cache of Module.js during custom module update
------------------------------+------------------------
 Reporter:  joffrey           |       Owner:  developer
     Type:  defect            |      Status:  new
 Priority:  unassigned        |   Milestone:  6.2.0
Component:  vtigercrm         |     Version:  5.4.0
 Severity:  Medium            |  Resolution:
 Keywords:  cache,javascript  |
------------------------------+------------------------
Changes (by prasad):

 * milestone:  6.0.0 => 6.2.0


Old description:

> Javascript files (eg: Module.js) can be in browser/proxy cache.
>
> When updating a custom module, the old version of javascript file could
> still be used with the new version of the module.
>
> Bugs have been encountered because of this cache issue.
>
> To solve this problem on server-side, it is advised to add a tag to the
> url. This tag will change whenever the file changes.
>
> Eg :
> <script type="text/javascript"
> src="modules/CustomModule/CustomModule.js?filemtime=1356077038"></script>
>
> The attached patch contains this proposed correction.

New description:

 Javascript files (eg: Module.js) can be in browser/proxy cache.

 When updating a custom module, the old version of javascript file could
 still be used with the new version of the module.

 Bugs have been encountered because of this cache issue.

 To solve this problem on server-side, it is advised to add a tag to the
 url. This tag will change whenever the file changes.

 Eg :
 <script type="text/javascript"
 src="modules/CustomModule/CustomModule.js?filemtime=1356077038"></script>

 The attached patch contains this proposed correction.

--

Comment:

 Having ?k=v parameter for resource file troubles the browser cache and
 lookup request would be issued for every page load. It may result with 304
 / 200 response. We will plan to provide resource url API to handle the
 same per version.

--
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7627#comment:1>
Vtiger development <http://trac.vtiger.com/>
Vtiger CRM